Permalink
Commits on Apr 30, 2012
  1. updated VERSION for 2.0.13

    fabpot committed Apr 30, 2012
  2. update CONTRIBUTORS for 2.0.13

    fabpot committed Apr 30, 2012
  3. updated CHANGELOG for 2.0.13

    fabpot committed Apr 30, 2012
  4. updated vendors for 2.0.13

    fabpot committed Apr 30, 2012
  5. merged branch johnkary/os400ConsoleBugFix (PR #4152)

    Commits
    -------
    
    5b92b9e [Console] Selectively output to STDOUT or OUTPUT stream
    
    Discussion
    ----------
    
    [Console] Selectively output to STDOUT or OUTPUT stream
    
    Originally opened in this PR targeting master, but asked to target 2.0 instead: #4148
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #1434
    Todo: -
    
    As noted in the ticket discussion and linked discussion threads, IBM i5 Series has issues with writing output to STDOUT when viewed via their QP2TERM console. The output is likely not being converted to the correct character-encoding on the system level.
    
    This PR changes the default output stream from `php://stdout` to `php://output` for OS400 environments, which does not exhibit this issue.
    
    I'm using `php_uname('s')` to check for the presence of "OS400", which is at least one of the IBM OS's exhibiting this issue. This check is only done once when executing a Console task and shouldn't see any adverse affects in speed on the 99% other platforms using Symfony.
    
    I'm not a native to the OS400 platform so I can't really anticipate any other possible regressions that might occur from switching output streams for that platform. On my Mac, this change would strip all color output, but the PR code only changes output for OS400 environment. To my knowledge the QP2TERM console doesn't even support color, so no loss there.
    
    I think this change is best to make the Console component at least usable out of the box for anyone else trying to build CLI applications for use on OS400.
    
    ---------------------------------------------------------------------------
    
    by igorw at 2012-04-29T19:41:21Z
    
    #4146 might also need a fix for this.
    
    ---------------------------------------------------------------------------
    
    by johnkary at 2012-04-29T20:21:39Z
    
    @igorw Hmm. In this case for #4152 when creating a CLI application, `Symfony\Component\Console\Output\ConsoleOutput` is the [default implementation](https://github.com/johnkary/symfony/blob/5b92b9ed432ea1d5f2c596517fc7f8aa825b1977/src/Symfony/Component/Console/Application.php#L113) used by `Symfony\Component\Console\Application` when not specifying your own `OutputInterface`. Our hard-coded defaults were causing problems out of the box.
    
    I haven't looked too closely at the PRs surrounding the additions of `StreamingResponse` and your recent `OutputStream` but are we assuming anywhere that `php://stdout` is the default stream used when creating a streaming response? If so it MAY require a check similar to what I implemented for Console. My addition was only necessary because the output was being sent to a CLI console. If output is sent to a browser, I don't believe this would be an issue.
    
    If you have something that needs testing on OS400 just ping me.
    fabpot committed Apr 30, 2012
  6. merged branch stof/fix_monolog_webprocessor (PR #4157)

    Commits
    -------
    
    b574de3 Fixed tests
    
    Discussion
    ----------
    
    Fix tests for the monolog webprocessor
    fabpot committed Apr 30, 2012
  7. Fixed tests

    stof committed Apr 30, 2012
Commits on Apr 29, 2012
  1. [Console] Selectively output to STDOUT or OUTPUT stream

    Addresses issues with writing console output for IBM i5 Series (OS400).
    The normal QP2TERM shell outputs garbage text when attempting to write
    directly to STDOUT, likely because of EBCDIC character-encoding used
    on IBM platforms. Writing to the OUTPUT mimics using 'echo' or 'print'
    and prints properly in the console.
    
    Fixes #1434
    johnkary committed Apr 29, 2012
  2. merged branch stof/fix_monolog_webprocessor (PR #4151)

    Commits
    -------
    
    689a40d [MonologBridge] Fixed the WebProcessor
    
    Discussion
    ----------
    
    [MonologBridge] Fixed the WebProcessor
    
    The WebProcessor can now be registered as a kernel.request listener to
    get the request instead of passing it as a constructor argument, which
    was broken as the request is not yet available when the logger is
    instantiated.
    
    I'm sending it to 2.0 even if the way to use the processor is not BC as this is really a bugfix. The processor was simply unusable with the previous way. Tell me if you think it should only be fixed for 2.1
    
    Fixes #3311
    fabpot committed Apr 29, 2012
Commits on Apr 25, 2012
  1. merged branch Seldaek/deps (PR #4103)

    Commits
    -------
    
    4633fa9 Bump monolog version
    
    Discussion
    ----------
    
    Bump monolog dependency in 2.0
    fabpot committed Apr 25, 2012
  2. Bump monolog version

    Seldaek committed Apr 25, 2012
Commits on Apr 24, 2012
  1. merged branch gajdaw/2_0_component_domcrawler_cs (PR #4091)

    Commits
    -------
    
    25fed13 [2.0][Component][DomCrawler] cs
    
    Discussion
    ----------
    
    [2.0][Component][DomCrawler] cs
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: [![Build Status](https://secure.travis-ci.org/gajdaw/symfony.png?branch=2_0_component_domcrawler_cs)](http://travis-ci.org/gajdaw/symfony)
    Fixes the following tickets: -
    Todo: -
    
    Code standard fix + some documentation.
    fabpot committed Apr 24, 2012
  2. merged branch willdurand/deprecated-error-handler (PR #4096)

    Commits
    -------
    
    c89f3d3 [HttpKernel] Added DEPRECATED errors
    
    Discussion
    ----------
    
    Deprecated error handler
    fabpot committed Apr 24, 2012
  3. [2.0][Component][DomCrawler] cs

    gajdaw committed Apr 23, 2012
Commits on Apr 23, 2012
  1. [MonologBridge] Fixed the WebProcessor

    The WebProcessor can now be registered as a kernel.request listener to
    get the request instead of passing it as a constructor argument, which
    was broken as the request is not yet available when the logger is
    instantiated.
    stof committed Apr 23, 2012
  2. merged branch stloyd/patch-2 (PR #4089)

    Commits
    -------
    
    fde94ca [Validator] Fixed example in README file (fixes #4088)
    
    Discussion
    ----------
    
    [Validator] Fixed example in README file (fixes #4088)
    fabpot committed Apr 23, 2012
  3. merged branch Ziumin/2.0 (PR #4076)

    Commits
    -------
    
    2e7d3b1 http_build_query fix
    de73de0 http_build_query fix
    3b7ee9a http_build_query fix
    
    Discussion
    ----------
    
    [2.0] http_build_query extra parameters
    
    Bug fix: yes
    
    arg_separator.output is not always "&", so it is better ini_set it or put an extra parameters to http_build_query
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-04-23T10:20:05Z
    
    Can you squash your commits? It will be much easier to get back to this change later on. Thanks.
    
    ---------------------------------------------------------------------------
    
    by Ziumin at 2012-04-23T10:46:35Z
    
    I have no idea how to do it using web interface. I'm not familiar with git (prefer hg). Sorry.
    fabpot committed Apr 23, 2012
  4. merged branch gajdaw/2_0_component_classloader_cs (PR #4072)

    Commits
    -------
    
    54ec687 [2.0][Component][ClassLoader] cs
    
    Discussion
    ----------
    
    [2.0][Component][ClassLoader] CS
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    fabpot committed Apr 23, 2012
  5. http_build_query fix

    Ziumin committed Apr 23, 2012
  6. http_build_query fix

    Ziumin committed Apr 23, 2012
  7. http_build_query fix

    Ziumin committed Apr 23, 2012
  8. [2.0][Component][ClassLoader] cs

    gajdaw committed Apr 23, 2012
Commits on Apr 21, 2012
  1. merged branch hhamon/request_getport_cleanup (PR #4052)

    Commits
    -------
    
    6dddb6b [HttpFoundation] removed useless else clause in Request::getPort() method.
    
    Discussion
    ----------
    
    Request getport cleanup
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    fabpot committed Apr 21, 2012
Commits on Apr 20, 2012
  1. merged branch vicb/transaltion_monitor (PR #4036)

    Commits
    -------
    
    7ddc8cb [FrameworkBundle] Monitor added/removed translations files in dev (fix #3653)
    
    Discussion
    ----------
    
    [FrameworkBundle] Monitor added/removed translations files in dev
    
    fix #3653
    
    ---------------------------------------------------------------------------
    
    by Koc at 2012-04-20T14:09:55Z
    
    maybe you also can fix #971 ?
    fabpot committed Apr 20, 2012
  2. merged branch jfsimon/issue-3896 (PR #4029)

    Commits
    -------
    
    686653a [HttpKernel] Fixed wache vary write (fixes #3896).
    
    Discussion
    ----------
    
    [HttpKernel] Fixed cache vary write (fixes #3896).
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #3896
    
    Same as #4001, but for write method.
    fabpot committed Apr 20, 2012
  3. [HttpKernel] Fixed wache vary write (fixes #3896).

    jeanfrancois.simon committed Apr 20, 2012
Commits on Apr 19, 2012
  1. merged branch ruian/issue-3992 (PR #4006)

    Commits
    -------
    
    45ada32 Add Support for boolean as to string into yaml extension
    
    Discussion
    ----------
    
    Add Support for boolean as to string into yaml extension
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: 3992
    Todo:
    - Maybe use only boolean checker instead of YamlDumper->dump
    fabpot committed Apr 19, 2012