Permalink
Commits on May 17, 2012
  1. updated VERSION for 2.0.14

    fabpot committed May 17, 2012
  2. update CONTRIBUTORS for 2.0.14

    fabpot committed May 17, 2012
  3. updated CHANGELOG for 2.0.14

    fabpot committed May 17, 2012
Commits on May 16, 2012
  1. merged branch aderuwe/issue-3216 (PR #4304)

    Commits
    -------
    
    6341de0 Be more specific in phpdoc (Fixes #3216)
    
    Discussion
    ----------
    
    Modify TwigEngine.php's signature (#3216)
    
    This fixes the "line-ending issues" in TwigEngine.php responsible for connection reset errors on windows (which do still occur on 2.0.13, when ```core.autocrlf``` is set to GitHub's recommendation rather than Symfony's), caused by factors out of Symfony's control.
    
    I acknowledge the comments on the above issue, but it seems this is trivial to do and it will save a bunch of time for people who find themselves in this situation.
    
    Bug fix: [no]
    Feature addition: [no]
    Backwards compatibility break: [no]
    Symfony2 tests pass: phpdoc changes
    Fixes the following tickets: [#3216]
    License of the code: MIT
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-16T19:35:55Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1348808) (merged 6341de0 into 980a062).
    fabpot committed May 16, 2012
  2. merged branch ouardisoft/2.0 (PR #4300)

    Commits
    -------
    
    d1c831d Change must-proxy-revalidate by proxy-revalidate
    
    Discussion
    ----------
    
    Change must-proxy-revalidate by proxy-revalidate
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-16T09:20:54Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1344060) (merged d1c831d into 8cd6cbc).
    fabpot committed May 16, 2012
  3. merged branch mvrhov/exchangeWidthHeight (PR #4299)

    Commits
    -------
    
    445fd2f In console terms columns are width and rows are height
    
    Discussion
    ----------
    
    [Console] Exchange terminal width and height
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    License of the code: MIT
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-16T09:20:08Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1344055) (merged 445fd2f into 8cd6cbc).
    fabpot committed May 16, 2012
  4. Change must-proxy-revalidate by proxy-revalidate

    ouardisoft committed May 16, 2012
  5. In console terms columns are width and rows are height

    Miha Vrhovnik committed May 16, 2012
  6. fixed some CS

    fabpot committed May 16, 2012
  7. [Console] fixed some CS

    fabpot committed May 15, 2012
  8. removed check_cs script

    fabpot committed May 16, 2012
Commits on May 15, 2012
  1. fixed phpdoc @param alignment

    fabpot committed May 15, 2012
  2. merged branch robocoder/autoloader (PR #4168)

    Commits
    -------
    
    b2afd9f use require instead of include
    1ed8b72 Autoloader should not throw exception because PHP will continue to call other registered autoloaders.
    
    Discussion
    ----------
    
    [DoctrineBundle] Proxy autoloader should not throw exception
    
    Also change 'require' to non-fatal '@include' in the event no file is generated.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-05-01T06:13:34Z
    
    The goal of the exception was to make debugging easier. And all Symfony2 autoloaders are using ``require``
    
    ---------------------------------------------------------------------------
    
    by robocoder at 2012-05-01T16:09:04Z
    
    I changed the include back to a require.
    
    Whether or not the exception makes debugging easier is debatable.  But throwing an exception from an autoloader is both unconventional and unexpected given that (1) exceptions are propagated while php calls other registered autoloaders, and (2) php will throw a fatal error where the usage actually occurs if the class doesn't exist.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-05-15T06:01:11Z
    
    ping @beberlei
    
    ---------------------------------------------------------------------------
    
    by beberlei at 2012-05-15T10:20:06Z
    
    Its tricky, the message does try to give some additional information - but later autoloaders could handle this issue anyways. I guess the PR makes sense as users have absolutely no control over this autoloader and it should therefore behave less strictly.
    fabpot committed May 15, 2012
  3. merged branch Romain-Geissler/read-only-form-datamapper-fix (PR #4280)

    Commits
    -------
    
    47605f6 [Form][DataMapper] Do not update form to data when form is read only
    
    Discussion
    ----------
    
    [Form] [DataMapper] Read only form datamapper fix
    
    The current 2.0.13 ``Symfony\Component\Form\Extension\Core\DataMapper\PropertyPathMapper`` enables to overwrite data from form values, no matter the form fields are read only or not.
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    License of the code: MIT
    Documentation PR: -
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-14T15:50:02Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1328279) (merged 47605f6 into 72b2f69).
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-05-14T18:06:41Z
    
    Forms don't bind when they are read only, so why is this change necessary?
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-05-14T19:29:45Z
    
    @bschussek A read-only child will not be bound but the setter will still be called on the parent object for this field (with the old value), making it mandatory to define setters for read-only fields.
    
    ---------------------------------------------------------------------------
    
    by Romain-Geissler at 2012-05-14T19:43:11Z
    
    In my case, the property is still set through a setter even if the field for this property is read only. The problem is the setter is not called with the legacy value it held, but with the value given by the form. In my case the value is transformed from a string to an object by a ``DataMapper``, which returns ``null`` for an empty string/value. Thus, the setter is called with ``null`` instead of the previous non ``null`` value (and not always the same) it held.
    
    This PR just prevent the setter for an object property marked as read only in the form definition from being called.
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-05-15T08:20:28Z
    
    Ok, 👍 then
    fabpot committed May 15, 2012
  4. merged branch odolbeau/cs (PR #4278)

    Commits
    -------
    
    3623580 Add missing PHPDoc
    
    Discussion
    ----------
    
    Add missing PHPDoc + correct PHPDoc alignment
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-14T15:19:29Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1327970) (merged 3623580 into 72b2f69).
    fabpot committed May 15, 2012
Commits on May 14, 2012
  1. Add missing PHPDoc

    odolbeau committed May 14, 2012
  2. merged branch sstok/spelling-fix (PR #4275)

    Commits
    -------
    
    bbf7183 [Routing] fixed spelling errors in phpdoc
    
    Discussion
    ----------
    
    [Routing] fixed spelling errors in phpdoc
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-14T11:17:26Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1326017) (merged bbf7183 into 8d7f7f5).
    fabpot committed May 14, 2012
Commits on May 13, 2012
Commits on May 12, 2012
  1. [CssSelector] removed an unneeded condition (taken care of afterward …

    …in the code) (closes #4269)
    fabpot committed May 12, 2012
Commits on May 11, 2012
  1. merged branch Tobion/patch-6 (PR #4248)

    Commits
    -------
    
    9af91a3 add composer to gitignore in 2.0
    
    Discussion
    ----------
    
    add composer to gitignore in 2.0
    
    it was missing in 2.0 (so switching from master to 2.0 made these files appear as new)
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-10T13:20:31Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1294729) (merged 9af91a3 into 68eca0f).
    fabpot committed May 11, 2012
  2. merged branch ondrowan/2.0 (PR #4247)

    Commits
    -------
    
    f2caf07 Fixed minor typo in slovak translation (validator.sk.xliff).
    
    Discussion
    ----------
    
    Fixed minor typo in slovak translation (validator.sk.xliff).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-10T13:14:39Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1294645) (merged f2caf07 into 68eca0f).
    fabpot committed May 11, 2012
Commits on May 10, 2012
  1. add composer to gitignore in 2.0

    Tobion committed May 10, 2012
  2. merged branch willdurand/fix-typo (PR #4240)

    Commits
    -------
    
    6f343b4 [Console] Fixed typo
    
    Discussion
    ----------
    
    Fix typo
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-09T16:45:36Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1286723) (merged 6f343b4 into 906f6f6).
    fabpot committed May 10, 2012
Commits on May 9, 2012
  1. [Console] Fixed typo

    willdurand committed May 9, 2012
Commits on May 7, 2012
Commits on May 3, 2012
  1. merged branch GromNaN/patch-2 (PR #4189)

    Commits
    -------
    
    970d0b4 [BrowserKit] Check class existence only when required.
    
    Discussion
    ----------
    
    [BrowserKit] Check class existence only when required.
    
    See PR #4177
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    
    Remove incorrect exception when doing $client->insulate(false)
    fabpot committed May 3, 2012
Commits on May 1, 2012