Skip to content
This repository

May 17, 2012

  1. Fabien Potencier

    updated VERSION for 2.0.14

    fabpot authored

May 16, 2012

  1. Alexander Deruwe

    Be more specific in phpdoc (Fixes #3216)

    aderuwe authored
  2. Fabien Potencier

    merged branch ouardisoft/2.0 (PR #4300)

    Commits
    -------
    
    d1c831d Change must-proxy-revalidate by proxy-revalidate
    
    Discussion
    ----------
    
    Change must-proxy-revalidate by proxy-revalidate
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-16T09:20:54Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1344060) (merged d1c831d into 8cd6cbc).
    fabpot authored
  3. ouardisoft

    Change must-proxy-revalidate by proxy-revalidate

    ouardisoft authored
  4. Miha Vrhovnik

    In console terms columns are width and rows are height

    mvrhov authored
  5. Fabien Potencier

    fixed some CS

    fabpot authored
  6. Fabien Potencier

    [Console] fixed some CS

    fabpot authored

May 15, 2012

  1. Fabien Potencier

    fixed phpdoc @param alignment

    fabpot authored
  2. Fabien Potencier

    [Finder] replaced static by self on a private variable

    fabpot authored
  3. Fabien Potencier

    merged branch robocoder/autoloader (PR #4168)

    Commits
    -------
    
    b2afd9f use require instead of include
    1ed8b72 Autoloader should not throw exception because PHP will continue to call other registered autoloaders.
    
    Discussion
    ----------
    
    [DoctrineBundle] Proxy autoloader should not throw exception
    
    Also change 'require' to non-fatal '@include' in the event no file is generated.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-05-01T06:13:34Z
    
    The goal of the exception was to make debugging easier. And all Symfony2 autoloaders are using ``require``
    
    ---------------------------------------------------------------------------
    
    by robocoder at 2012-05-01T16:09:04Z
    
    I changed the include back to a require.
    
    Whether or not the exception makes debugging easier is debatable.  But throwing an exception from an autoloader is both unconventional and unexpected given that (1) exceptions are propagated while php calls other registered autoloaders, and (2) php will throw a fatal error where the usage actually occurs if the class doesn't exist.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-05-15T06:01:11Z
    
    ping @beberlei
    
    ---------------------------------------------------------------------------
    
    by beberlei at 2012-05-15T10:20:06Z
    
    Its tricky, the message does try to give some additional information - but later autoloaders could handle this issue anyways. I guess the PR makes sense as users have absolutely no control over this autoloader and it should therefore behave less strictly.
    fabpot authored
  4. Fabien Potencier

    merged branch Romain-Geissler/read-only-form-datamapper-fix (PR #4280)

    Commits
    -------
    
    47605f6 [Form][DataMapper] Do not update form to data when form is read only
    
    Discussion
    ----------
    
    [Form] [DataMapper] Read only form datamapper fix
    
    The current 2.0.13 ``Symfony\Component\Form\Extension\Core\DataMapper\PropertyPathMapper`` enables to overwrite data from form values, no matter the form fields are read only or not.
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    License of the code: MIT
    Documentation PR: -
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-14T15:50:02Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1328279) (merged 47605f6 into 72b2f69).
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-05-14T18:06:41Z
    
    Forms don't bind when they are read only, so why is this change necessary?
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-05-14T19:29:45Z
    
    @bschussek A read-only child will not be bound but the setter will still be called on the parent object for this field (with the old value), making it mandatory to define setters for read-only fields.
    
    ---------------------------------------------------------------------------
    
    by Romain-Geissler at 2012-05-14T19:43:11Z
    
    In my case, the property is still set through a setter even if the field for this property is read only. The problem is the setter is not called with the legacy value it held, but with the value given by the form. In my case the value is transformed from a string to an object by a ``DataMapper``, which returns ``null`` for an empty string/value. Thus, the setter is called with ``null`` instead of the previous non ``null`` value (and not always the same) it held.
    
    This PR just prevent the setter for an object property marked as read only in the form definition from being called.
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-05-15T08:20:28Z
    
    Ok, :+1: then
    fabpot authored

May 14, 2012

  1. Romain Geissler

    [Form][DataMapper] Do not update form to data when form is read only

  2. Olivier Dolbeau

    Add missing PHPDoc

    odolbeau authored
  3. Sebastiaan Stok

    [Routing] fixed spelling errors in phpdoc

    sstok authored

May 13, 2012

  1. Fabien Potencier

    [CssSelector] updated upstream code repository

    fabpot authored
  2. Fabien Potencier

    [CssSelector] ignored an optional whitespace after a combinator

    fabpot authored

May 12, 2012

  1. Fabien Potencier

    [CssSelector] removed an unneeded condition (taken care of afterward …

    …in the code) (closes #4269)
    fabpot authored

May 11, 2012

  1. Fabien Potencier

    [HttpKernel] added some constant for better forward compatibility

    fabpot authored

May 10, 2012

  1. Ondrej Slinták

    Fixed minor typo in slovak translation (validator.sk.xliff).

    ondrowan authored

May 09, 2012

  1. William Durand

    [Console] Fixed typo

    willdurand authored

May 07, 2012

  1. Fabien Potencier

    [DependencyInjection] fixed private services removal when used as con…

    …figurators (closes #3758)
    fabpot authored

May 03, 2012

  1. Jérôme Tamarelle

    [BrowserKit] Check class existence only when required.

    GromNaN authored

May 01, 2012

  1. Anthon Pang

    use require instead of include

    robocoder authored
  2. Hugo Hamon

    [Security] fixed phpdoc.

    hhamon authored
  3. Hugo Hamon

    [Security] added some missing phpdoc for AbstractToken::setUser() and…

    … UsernamePasswordToken::__construct() methods.
    hhamon authored
  4. Anthon Pang

    Autoloader should not throw exception because PHP will continue to ca…

    …ll other registered autoloaders.
    
    Change 'require' to non-fatal '@include' in the event no file is generated.  Let PHP handle the undefined class, natively.
    robocoder authored

Apr 30, 2012

  1. Fabien Potencier

    bumped Symfony version to 2.0.14-DEV

    fabpot authored
  2. Uwe Jäger

    [Security] Configure ports in RetryAuthenticationEntryPoint according…

    … to router settings
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    
    Currently the ports in RetryAuthenticationEntryPoint are fixed in the constructor call, there is no way to set them when you run your application on different ports.
    
    With this fix the ports are taken from the router configuration.
    uwej711 authored
  3. Fabien Potencier

    updated VERSION for 2.0.13

    fabpot authored

Apr 29, 2012

  1. John Kary

    [Console] Selectively output to STDOUT or OUTPUT stream

    Addresses issues with writing console output for IBM i5 Series (OS400).
    The normal QP2TERM shell outputs garbage text when attempting to write
    directly to STDOUT, likely because of EBCDIC character-encoding used
    on IBM platforms. Writing to the OUTPUT mimics using 'echo' or 'print'
    and prints properly in the console.
    
    Fixes #1434
    johnkary authored
  2. Fabien Potencier

    merged branch stof/fix_monolog_webprocessor (PR #4151)

    Commits
    -------
    
    689a40d [MonologBridge] Fixed the WebProcessor
    
    Discussion
    ----------
    
    [MonologBridge] Fixed the WebProcessor
    
    The WebProcessor can now be registered as a kernel.request listener to
    get the request instead of passing it as a constructor argument, which
    was broken as the request is not yet available when the logger is
    instantiated.
    
    I'm sending it to 2.0 even if the way to use the processor is not BC as this is really a bugfix. The processor was simply unusable with the previous way. Tell me if you think it should only be fixed for 2.1
    
    Fixes #3311
    fabpot authored

Apr 24, 2012

  1. Fabien Potencier

    merged branch gajdaw/2_0_component_domcrawler_cs (PR #4091)

    Commits
    -------
    
    25fed13 [2.0][Component][DomCrawler] cs
    
    Discussion
    ----------
    
    [2.0][Component][DomCrawler] cs
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: [![Build Status](https://secure.travis-ci.org/gajdaw/symfony.png?branch=2_0_component_domcrawler_cs)](http://travis-ci.org/gajdaw/symfony)
    Fixes the following tickets: -
    Todo: -
    
    Code standard fix + some documentation.
    fabpot authored
  2. William Durand

    [HttpKernel] Added DEPRECATED errors

    willdurand authored
  3. Włodzimierz Gajda

    [2.0][Component][DomCrawler] cs

    gajdaw authored

Apr 23, 2012

  1. Christophe Coevoet

    [MonologBridge] Fixed the WebProcessor

    The WebProcessor can now be registered as a kernel.request listener to
    get the request instead of passing it as a constructor argument, which
    was broken as the request is not yet available when the logger is
    instantiated.
    stof authored
Something went wrong with that request. Please try again.