Skip to content
Commits on Jul 11, 2012
  1. @fabpot

    updated VERSION for 2.0.16

    fabpot committed Jul 11, 2012
  2. @fabpot

    update CONTRIBUTORS for 2.0.16

    fabpot committed Jul 11, 2012
  3. @fabpot

    updated CHANGELOG for 2.0.16

    fabpot committed Jul 11, 2012
Commits on Jul 10, 2012
  1. @fabpot
  2. @fabpot

    merged branch bschussek/issue4686 (PR #4828)

    Commits
    -------
    
    854daa8 [Form] Fixed errors not to be added onto non-synchronized forms
    
    Discussion
    ----------
    
    [Form] Fixed errors not to be added onto non-synchronized forms
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #4686
    Todo: -
    fabpot committed Jul 10, 2012
  3. @webmozart
Commits on Jul 9, 2012
  1. @fabpot
  2. @fabpot
  3. @fabpot

    merged branch eriksencosta/issue-4718 (PR #4794)

    Commits
    -------
    
    28f002d [Locale] fixed bug on the parsing of TYPE_INT64 integers in 32 bit and 64 bit environments, caused by PHP bug fix :) (closes #4718)
    
    Discussion
    ----------
    
    [Locale] fixed bug on the parsing of TYPE_INT64 integers in 32 bit and 64 bit environments, caused by PHP bug fix
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #4718
    License of the code: MIT
    
    [![Build Status](https://secure.travis-ci.org/eriksencosta/symfony.png?branch=issue-4718)](http://travis-ci.org/eriksencosta/symfony)
    
    Tests pass on PHP 5.3.3, 5.3.14 and 5.4.4 with ICU 4.2, 4.4 and 4.6 on 32 and 64 bit environments.
    fabpot committed Jul 9, 2012
  4. @themightyi

    [Locale] fixed bug on the parsing of TYPE_INT64 integers in 32 bit an…

    …d 64 bit environments, caused by PHP bug fix :) (closes #4718)
    themightyi committed Jul 8, 2012
Commits on Jul 1, 2012
  1. @msabramo @fabpot
Commits on Jun 29, 2012
  1. @fabpot

    updated vendors

    fabpot committed Jun 29, 2012
  2. @fabpot
  3. @fabpot
Commits on Jun 28, 2012
  1. @fabpot

    merged branch eriksencosta/issue-3841 (PR #4601)

    Commits
    -------
    
    a609d55 [Locale] fixed StubIntlDateFormatter to behave like the ext/intl implementation
    
    Discussion
    ----------
    
    [2.0][WIP][Locale] StubIntlDateFormatter should use the TZ environment variable instead of the PHP's date.timezone setting
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: yes
    Symfony2 tests pass: yes
    Fixes the following tickets: #3841
    Todo: Check ext/intl changes for the next PHP 5.4 release
    License of the code: MIT
    
    ![Build Status](https://secure.travis-ci.org/eriksencosta/symfony.png?branch=issue-3841)
    
    There were changes that need to be investigated for the next PHP 5.4 release:
    
     - [php-src @ eb346ef](php/php-src@eb346ef)
     - [php-src @ 888e77f](php/php-src@888e77f)
    
    A strong evidence of bug in ext/intl was found while testing `StubIntlDateFormatter`. See the comment available at the docblock of `StubIntlDateFormatterTest`'s `testFormatWithDefaultTimezoneIntlShouldUseTheTzEnvironmentVariableWhenAvailable()` method and the following Gist for test scripts: https://gist.github.com/2946342
    
    Maybe the upcoming PHP 5.4 release fix this bug since it will use the PHP's `date.timezone` when no time zone is provided. If confirmed the bug, it will need to be reported to the ext/intl maintainers.
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-18T05:02:05Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1644431) (merged a609d55 into cd0aa37).
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-06-28T14:09:08Z
    
    @eriksencosta Now that PHP 5.4.4 is out, our tests for the Locale components are broken. Is this PR ready to be merged?
    
    ---------------------------------------------------------------------------
    
    by eriksencosta at 2012-06-28T14:53:14Z
    
    @fabpot the failed test case seems unrelated to this issue. I will debug it.
    
    Failed test: `Locale\Tests\Stub\StubNumberFormatterTest::testParseTypeInt64IntlWith32BitIntegerInPhp32Bit`
    
    Recent build job: http://travis-ci.org/#!/symfony/symfony/jobs/1729618
    
    I just need to confirm mine todo note. If you want, merge it, I'll track this and make a new PR if needed (possibly only to remove the TODO note.)
    fabpot committed Jun 28, 2012
Commits on Jun 20, 2012
  1. @fabpot

    merged branch Maks3w/patch-4 (PR #4616)

    Commits
    -------
    
    fa050b7 [Security] Change return value in DocBlock
    
    Discussion
    ----------
    
    [Security] Change return value in DocBlock
    
    Change the return value for avoid confusions.
    
    ```php
    if (!$user instanceof UserInterface) {
        throw new AuthenticationServiceException('retrieveUser() must return a UserInterface.');
    }
    ```
    
    [UserAuthenticationProvider.php#L67](https://github.com/symfony/symfony/tree/2.0/src/Symfony/Component/Security/Core/Authentication/Provider/UserAuthenticationProvider.php#L67)
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-19T21:03:07Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1659148) (merged fa050b7 into e78a7ba).
    fabpot committed Jun 20, 2012
  2. @fabpot

    merged branch vicb/security/password_0 (PR #4624)

    Commits
    -------
    
    680b83c [Security] Allow "0" as a password
    
    Discussion
    ----------
    
    [Security] allow "0" as a password
    
    ```php
    <?php
    !"0" == true
    ```
    fabpot committed Jun 20, 2012
  3. @vicb

    [Security] Allow "0" as a password

    vicb committed Jun 20, 2012
Commits on Jun 19, 2012
  1. @Maks3w

    [Security] Change return value in DocBlock

    Change the return value for avoid confusions.
    Maks3w committed Jun 19, 2012
  2. @fabpot

    merged branch stof/composer_provide (PR #4614)

    Commits
    -------
    
    2c12ed3 Added a missing provide for the swiftmailer bridge
    
    Discussion
    ----------
    
    Composer provide
    
    Currently, the standalone bridge will be installed when a library requires it, even if you have the full framework, thus leading to weird issues if the versions missmatch (which is possible as the bridge does not have any hard requirement to a component in the composer.json which would enforce ``self.version``)
    fabpot committed Jun 19, 2012
  3. @stof
Commits on Jun 18, 2012
  1. @themightyi
Commits on Jun 16, 2012
  1. @fabpot

    tweaked the previous commit

    fabpot committed Jun 16, 2012
  2. @fabpot

    merged branch uwej711/only_redirect_on_get (PR #4580)

    Commits
    -------
    
    3ce8227 [Security] Only redirect to urls called with http method GET
    
    Discussion
    ----------
    
    [Security] Only redirect to urls called with http method GET
    
    Bug fix: [yes]
    Feature addition: [no]
    Backwards compatibility break: [no]
    Symfony2 tests pass: [yes]
    License of the code: MIT
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-14T12:01:32Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1619029) (merged 3ce8227 into 4e1e08e).
    fabpot committed Jun 16, 2012
Commits on Jun 14, 2012
  1. @uwej711
  2. @fabpot

    merged branch stof/use_statements (PR #4576)

    Commits
    -------
    
    0d67b9f Removed useless use statements
    a3c1299 [Form] Added a missing use statement and fix a phpdoc
    
    Discussion
    ----------
    
    Use statements
    
    This adds a missing use statements in the Form component (which would cause a fatal error if the exception was thrown) and removes useless use statements in the BrowserKit component (the use statement for the current class confuses the IDEs)
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-14T08:05:41Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1617154) (merged 0d67b9f into 41f48b7).
    fabpot committed Jun 14, 2012
  3. @stof

    Removed useless use statements

    stof committed Jun 14, 2012
  4. @stof
Commits on Jun 12, 2012
  1. @fabpot

    merged branch mvrhov/1813_regression (PR #4551)

    Commits
    -------
    
    5d88255 Authorization header should only be rebuild when Basic Auth scheme is used
    
    Discussion
    ----------
    
    [Regression fix] Authorization header should only be rebuild when Basic Auth scheme is used
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: fixes regression introduced by #1813
    Todo: N/A
    License of the code: MIT
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-11T14:40:28Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1592604) (merged cf5ee26a into 27100ba).
    
    ---------------------------------------------------------------------------
    
    by mvrhov at 2012-06-12T06:13:01Z
    
    fixed
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-12T06:14:55Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1598555) (merged 5d88255 into 27100ba).
    fabpot committed Jun 12, 2012
  2. @fabpot
  3. @mvrhov
Commits on Jun 9, 2012
  1. @fabpot

    merged branch jakzal/yamlDoubleQuotesDumperFix (PR #4320)

    Commits
    -------
    
    b631073 [Yaml] Fixed double quotes escaping in Dumper.
    
    Discussion
    ----------
    
    [Yaml] Fixed double quotes escaping in Dumper
    
    Issue #4308 is caused by Dumper::escapeWithDoubleQuotes() which uses [str_replace()](http://php.net/str_replace).
    
    From the php docs:
    
    > Because str_replace() replaces left to right, it might replace a previously inserted value when doing multiple replacements.
    
    We should be very careful in deciding about the order of elements in $escapees array. I'd really appreciate if someone reviewed my fix. Tests say I didn't break anything but I'm not sure what percentage of Yaml specification is covered by tests.
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: not that I know
    Symfony2 tests pass: [![Build Status](https://secure.travis-ci.org/jakzal/symfony.png?branch=yamlDoubleQuotesDumperFix)](http://travis-ci.org/jakzal/symfony)
    Fixes the following tickets: #4308
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-18T08:53:51Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1364279) (merged 5192722c into a04acc8).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-05-18T23:19:49Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1371539) (merged ecaa1aab into fc3c609).
    
    ---------------------------------------------------------------------------
    
    by dinamic at 2012-05-19T07:35:21Z
    
    Something is really wrong with this method. You can see clearly that multiple characters would fail proper escaping.
    
    Here's an example:
    ```
    $value = '\\\\"some value\n \"some quoted string\" and \'some single quotes one\'"';
    var_dump(Escaper::escapeWithDoubleQuotes($value));
    string(72) ""\\\"some value\n \\some quoted string\\ and 'some single quotes one'\"""
    ```
    
    To begin with the backslash - in the initial value you have 2 (escaped ones), that after escaping should result in 4, not in 1 (escaped). I guess this behavior has to be verified with the importer, but imho it does not seem right.
    
    Does anyone know why this escaping wasn't done using a regular expression in first place?
    
    ---------------------------------------------------------------------------
    
    by clemens-tolboom at 2012-05-19T10:18:58Z
    
    Searching for https://duckduckgo.com/?q=what+is+\xc2\x85 the table on http://stackoverflow.com/questions/6609895/efficiently-replace-bad-characters is interesting enough to decide we need way more documentation on this file.
    
    \xc2\x85 seems to be triple dot (ellipses)
    \xe2\x80\xa9 seems to be paragraph separator see http://drupal.org/node/914360#comment-3468550
    fabpot committed Jun 9, 2012
Commits on Jun 8, 2012
  1. @fabpot

    merged branch beberlei/GH-4491 (PR #4493)

    Commits
    -------
    
    4938080 MethodNotImplementedException -> MethodArgumentValueNotImplementedException
    789fc14 Accept calling setLenient(false)
    
    Discussion
    ----------
    
    GH-4491 - Move patch from master to 2.0
    
    A patch in PR-4469 fixed an issue with setLenient() and not having intl. This was only merged into master, although the original issue was created in the 2.0 branch. This PR cherry-picked the patches against 2.0 again.
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-06T15:29:19Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1527145) (merged 4938080 into 9a5e6c9).
    
    ---------------------------------------------------------------------------
    
    by kbond at 2012-06-06T17:42:40Z
    
    fixes #4491
    fabpot committed Jun 8, 2012
  2. @fabpot

    merged branch raulfraile/patch-3 (PR #4505)

    Commits
    -------
    
    26d416f Fixed typo in ConstraintValidatorFactoryInterface PHPDoc (2.0)
    
    Discussion
    ----------
    
    Fixed typo in ConstraintValidatorFactoryInterface PHPDoc: Constrain => Constraint.
    
    Bug fix: yes
    
Feature addition: no
    
Backwards compatibility break: no
    
Symfony2 tests pass: yes
    
    Fixed typo in ConstraintValidatorFactoryInterface PHPDoc: Constrain => Constraint.
    Fixes #4503
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-06T15:30:53Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1546330) (merged 26d416f into 9a5e6c9).
    fabpot committed Jun 8, 2012
Commits on Jun 6, 2012
  1. @raulfraile
Something went wrong with that request. Please try again.