Skip to content
Commits on Sep 25, 2011
  1. @fabpot

    updated VERSION for 2.0.2

    fabpot committed
  2. @fabpot

    update CONTRIBUTORS for 2.0.2

    fabpot committed
  3. @fabpot

    updated CHANGELOG for 2.0.2

    fabpot committed
  4. @fabpot

    updated vendors for 2.0.2

    fabpot committed
  5. @fabpot

    merged branch helmer/target_path (PR #2228)

    fabpot committed
    Commits
    -------
    
    022a9a7 [Security] Make saving target_path extendible
    
    Discussion
    ----------
    
    [Security] Make saving target_path extendible
    
    The problem lies in how Security component handles ``target_path`` - the latest request URI is always stored. This can lead to problems in following scenarios:
    a) The response type of the request is not HTML (think JSON, XML ..)
    b) The URI matches a route that does not listen to HTTP GET
    
    I opened a [PR](#604) months ago, to partly solve scenario A, which did not make it. Now I am proposing a different solution - user can extend ``ExceptionListener`` and override the logic behind setting the ``target_path`` to match his precise needs.
    
    In my simplified scenario, I would be using:
    
    ```
    protected function setTargetPath(Request $request)
    {
        if ($request->isXmlHttpRequest() || 'GET' !== $request->getMethod()) {
            return;
        }
    
        $request->getSession()->set('_security.target_path', $request->getUri());
    }
    ```
    
    @Seldaek, @schmittjoh, @lsmith77, thoughts?
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2011/09/21 02:37:02 -0700
    
    Seems like a better solution for flexibility's sake. Would be quite awesome if you could add a cookbook entry to symfony/symfony-docs about this, otherwise I'm afraid we'll have to explain it over and over again :)
    
    ---------------------------------------------------------------------------
    
    by helmer at 2011/09/21 03:38:57 -0700
    
    [Cookbook](helmer/symfony-docs@b22c5e6) entry done. Perhaps though I rushed ahead ..
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2011/09/21 03:52:01 -0700
    
    Thanks. You can already do a pull request against symfony-docs, just reference this pull request in it so it's not merged before this is merged.
Commits on Sep 23, 2011
  1. @fabpot

    merged branch weaverryan/2.0_readme_contributing (PR #2251)

    fabpot committed
    Commits
    -------
    
    c0494c4 [README] Adding a small section with information about contributing.
    
    Discussion
    ----------
    
    [WIP] Contributing addition to the README
    
    Hey guys-
    
    This adds a small section to the README about contributing. It's a WIP only because we need to wait for [this](symfony/symfony-docs@0892a2c) commit to be rendered so that the following link works (and takes you down to the new section):
    
    http://symfony.com/doc/current/contributing/code/patches.html#check-list
    
    Thanks!
  2. @fabpot
  3. @fabpot
  4. @fabpot

    merged branch geezmo/2.0 (PR #2249)

    fabpot committed
    Commits
    -------
    
    ae3aded Added PCRE_DOTALL modifier to RouteCompiler to allow urlencoded linefeed in route parameters.
    
    Discussion
    ----------
    
    Added PCRE_DOTALL modifier to RouteCompiler to allow urlencoded linefeed in route parameters.
    
    Reopened from PR 2220 on master branch.
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2011/09/23 07:59:58 -0700
    
    :+1: :)
  5. @weaverryan
  6. @geezmo

    Added PCRE_DOTALL modifier to RouteCompiler to allow urlencoded linef…

    geezmo committed
    …eed in route parameters.
  7. @fabpot
  8. @fabpot
Commits on Sep 22, 2011
  1. @fabpot
Commits on Sep 21, 2011
  1. @fabpot

    merged branch stealth35/ini_bool (PR #2235)

    fabpot committed
    Commits
    -------
    
    11c4412 [DependencyInjection] fix 2219 IniFileLoader accept Boolean
    
    Discussion
    ----------
    
    [DependencyInjection] fix #2219 IniFileLoader accept Boolean
    
    fix #2219
    accept : `true`, `false`, `null` like YAML
  2. @stealth35
  3. @fabpot

    merged branch alifity/trans-unit-41-id (PR #2234)

    fabpot committed
    Commits
    -------
    
    ad208d9 added trans-unit-41 for 2.0
    
    Discussion
    ----------
    
    Added indonesian translation for trans unit 41
  4. @fabpot
  5. @subosito

    added trans-unit-41 for 2.0

    subosito committed
  6. @mbontemps @fabpot
Commits on Sep 20, 2011
  1. @fabpot

    merged branch stealth35/patch-11 (PR #2224)

    fabpot committed
    Commits
    -------
    
    cf736cc [DomCrawler] Add test for ChoiceFormField without value
    bca551e [DomCrawler] ChoiceFormField should take the content when value is unavailable
    
    Discussion
    ----------
    
    [DomCrawler] ChoiceFormField should take the content when value is unavai
    
    [DomCrawler] ChoiceFormField should take the content when value is unavailable
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/09/20 09:15:21 -0700
    
    Can you some unit tests?
  2. @stealth35
  3. @stealth35
Commits on Sep 19, 2011
  1. @fabpot
Commits on Sep 18, 2011
  1. @fabpot

    merged branch hason/czech-2.0 (PR #2203)

    fabpot committed
    Commits
    -------
    
    620d44a [FrameworkBundle] updated Czech translation
    
    Discussion
    ----------
    
    [2.0] Updated Czech translation
  2. @fabpot

    merged branch stof/subrequest_fix (PR #2208)

    fabpot committed
    Commits
    -------
    
    ab8e760 Fixed the creation of the subrequests
    
    Discussion
    ----------
    
    Fixed the creation of the subrequests
    
    The subrequest must be created using an absolute path to keep the
    informations about the host and the base path.
    Closes #2168
Commits on Sep 17, 2011
  1. @stof

    Fixed the creation of the subrequests

    stof committed
    The subrequest must be created using an absolute path to keep the
    informations about the host and the base path.
    Closes #2168
  2. @fabpot

    [HttpKernel] fixed typo

    fabpot committed
  3. @hason
Commits on Sep 16, 2011
  1. @fabpot

    merged branch jalliot/fix-mirror-arg (PR #2050)

    fabpot committed
    Commits
    -------
    
    95dc7e1 Fixed fourth argument of Filesystem->mirror()
    
    Discussion
    ----------
    
    Fixed fourth argument of Filesystem->mirror()
    
    See #2027 and #2033 for discussion.
    
    @fabpot said that we don't want to use symlink at all on Windows so if this is confirmed, we should also change ``Filesystem->symlink()`` implementation.
    
    ---------------------------------------------------------------------------
    
    by alexandresalome at 2011/09/16 08:29:40 -0700
    
    Tested on Windows, OK for me
  2. @fabpot
  3. @fabpot

    merged branch schmittjoh/mbFix (PR #2194)

    fabpot committed
    Commits
    -------
    
    8e2cbe6 fixes usage of mb_*
    
    Discussion
    ----------
    
    Fixes usage of mb_strlen
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2011/09/16 05:33:45 -0700
    
    This will fail if the mbstring ext isn't enabled, you should still test for the mb_ function first.
  4. @schmittjoh

    fixes usage of mb_*

    schmittjoh committed
  5. @dklementjev @fabpot

    Profiler session import fixed.

    dklementjev committed with fabpot
Commits on Sep 15, 2011
  1. @schmittjoh @fabpot
Something went wrong with that request. Please try again.