Permalink
Commits on Jan 17, 2013
  1. [Yaml] fixed unneeded BC break

    fabpot committed Jan 17, 2013
  2. [DependencyInjection] fixed a bug in the YAML dumper where references…

    … where not converted to the @ notation
    fabpot committed Jan 17, 2013
  3. [Yaml] fixed typo

    fabpot committed Jan 17, 2013
  4. updated VERSION for 2.0.22

    fabpot committed Jan 17, 2013
  5. update CONTRIBUTORS for 2.0.22

    fabpot committed Jan 17, 2013
  6. updated CHANGELOG for 2.0.22

    fabpot committed Jan 17, 2013
  7. [Yaml] fixed default value

    fabpot committed Jan 17, 2013
  8. Added Yaml\Dumper::setIndentation() method to allow a custom indentat…

    …ion level of nested nodes.
    
    YAML does not specify an absolute indentation level, but a consistent indentation of nested nodes only: http://www.yaml.org/spec/1.2/spec.html#space/indentation/
    
    Projects that are generally using 2 spaces for indentation should be able to retain consistency with their coding standards by supplying a custom value for the new $indent parameter added to Yaml::dump(), or the new Dumper::setIndentation() method.
    
    The new parameter is a backwards-compatible API addition and defaults to the previous default of 4 (which was changed from 2 via PR #2242 only recently).
    
    Conflicts:
    	src/Symfony/Component/Yaml/Dumper.php
    	src/Symfony/Component/Yaml/Yaml.php
    sun committed with fabpot Aug 4, 2012
  9. added a way to enable/disable object support when parsing/dumping

    By default, object support is disabled, and instead of throwing an
    exception when an object is handled, null is returned.
    
    If you do need object support, enable it via:
    
        Yaml::dump($data, false, true);
    
    If you want an exception to be thrown in case an invalid type is handled
    (a PHP resource or a PHP object), pass true as the second argument:
    
        Yaml::dump($data, true, true);
    
    The same can be done when parsing:
    
        Yaml::parse($data, 2, false, true);
    fabpot committed Jan 17, 2013
  10. added a way to enable/disable PHP support when parsing a YAML input v…

    …ia Yaml::parse()
    
    PHP support when parsing a file has been disabled by default.
    If you do need PHP support when parsing a YAML file, enable it via:
    
        Yaml::setPhpParsing(true);
    
    As of Symfony 2.1, PHP support is disabled by default, and support will
    be removed in Symfony 2.3.
    fabpot committed Jan 17, 2013
Commits on Jan 11, 2013
  1. merged branch LawnGnome/PHP-5.5-compat-2.0 (PR #6699)

    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    c7bfce9 Fix version_compare() calls for PHP 5.5.
    
    Discussion
    ----------
    
    [2.0] [Form] [Locale] PHP 5.5 compatibility fixes
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: unknown, can't run the test suite on 2.0 due to `Doctrine\DBAL\Logging\DebugStack` not being found
    Fixes the following tickets: N/A
    Todo: None
    License of the code: MIT
    Documentation PR: N/A
    
    A backport of #6647 to the Symfony 2.0 branch, as requested. This affects a couple of files that aren't affected on 2.1.
    fabpot committed Jan 11, 2013
  2. Fix version_compare() calls for PHP 5.5.

    Until PHP 5.5 hits beta, the version number for Git builds is still 5.5.0-dev,
    which is less than 5.5.0alpha1 according to version_compare(). This means that
    the branches for 5.5 aren't being executed on 5.5 snapshots at present.
    LawnGnome committed Jan 11, 2013
Commits on Jan 10, 2013
  1. merged branch stloyd/bugfix/process_cwd (PR #6620)

    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    880da01 [Process] In edge cases `getcwd()` can return `false`, then `proc_open()` should get `null` to use default value (the working dir of the current PHP process)
    
    Discussion
    ----------
    
    [2.0][Process] In edge cases `getcwd()` can return `false`
    
    Bug fix: yes
    Feature addition: no
    BC break: no
    Symfony2 tests pass: yes
    
    In edge cases `getcwd()` can return `false`, then `proc_open()` should get `null` to use default value (the working dir of the current PHP process).
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2013-01-08T12:43:40Z
    
    I guess that this could be related to #6496, as error code `267` at Windows means:
    [`ERROR_DIRECTORY - The directory name is invalid.`](http://msdn.microsoft.com/en-us/library/ms681382%28v=vs.85%29.aspx#error_directory)
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2013-01-08T12:57:38Z
    
    If null already uses the current working directory, what's the point of calling getcwd() at all?
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2013-01-08T13:03:06Z
    
    @Seldaek TBH. I don't have idea =) It seems that it's there _from the beginning_, but yeah, I was a bit confused by usage of it too...
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2013-01-09T08:13:24Z
    
    What about removing the code altogether?
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2013-01-09T08:22:55Z
    
    @fabpot I'm ok with that, just not sure it will not be an BC break...
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2013-01-09T08:24:57Z
    
    php.net says `or NULL if you want to use the default value (the working
    dir of the current PHP process)` which sounds like getcwd() to me.
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2013-01-09T08:26:32Z
    
    For full BC though, `getWorkingDirectory` should `return $this->cwd ?:
    getcwd();` Then at least if that call fails the whole process isn't
    failing. I don't see why anyone would use that getter though.
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2013-01-10T12:43:59Z
    
    @fabpot @Seldaek What do you think about this now?
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2013-01-10T12:58:39Z
    
    👍
    fabpot committed Jan 10, 2013
  2. [Process] In edge cases `getcwd()` can return `false`, then `proc_ope…

    …n()` should get `null` to use default value (the working dir of the current PHP process)
    stloyd committed Jan 8, 2013
Commits on Jan 8, 2013
  1. merged branch hhamon/indentation_fix_esi_services_file (PR #6622)

    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    113271c [Bundle] [FrameworkBundle] fixed indentation in esi.xml services file.
    
    Discussion
    ----------
    
    [2.x] [Bundle] [FrameworkBundle] fixed indentation in esi.xml services file.
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Fixes the following tickets: -
    Todo: -
    License of the code: MIT
    fabpot committed Jan 8, 2013
  2. merged branch igorw/visibility-display (PR #6612)

    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    8da2b41 [TwigBundle] There is no CSS visibility of display, should be visible instead
    
    Discussion
    ----------
    
    [TwigBundle] There is no CSS visibility of display, should be visible instead
    fabpot committed Jan 8, 2013
Commits on Jan 7, 2013
  1. merged branch fabpot/strict-flag-bug (PR #6608)

    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    1d362b8 [DependencyInjection] fixed a bug where the strict flag on references were lost (closes #6607)
    
    Discussion
    ----------
    
    [DependencyInjection] fixed a bug where the strict flag on references were lost (closes #6607)
    fabpot committed Jan 7, 2013
  2. merged branch stloyd/bugfix/mimeguesser_functions (PR #6601)

    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    3195122 [HttpFoundation] Check if required shell functions for `FileBinaryMimeTypeGuesser` are not disabled
    
    Discussion
    ----------
    
    [HttpFoundation] Check if required shell functions are not disabled
    
    Rebased to `2.0` & squashed version of #6526.
    fabpot committed Jan 7, 2013
  3. [HttpFoundation] Check if required shell functions for `FileBinaryMim…

    …eTypeGuesser` are not disabled
    srsbiz committed with stloyd Dec 31, 2012
  4. merged branch stloyd/feature/request_phpdoc (PR #6599)

    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    666283c [HttpFoundation] Docblock for Request::isXmlHttpRequest() now points to Wikipedia
    
    Discussion
    ----------
    
    [2.0][HttpFoundation] Docblock for Request::isXmlHttpRequest()
    
    Docblock now points to [Wikipedia entry](http://en.wikipedia.org/wiki/List_of_Ajax_frameworks#JavaScript) instead of pointing all known JS frameworks.
    
    Replacement for #6444.
    fabpot committed Jan 7, 2013
  5. merged branch kosssi/bugfix/css-selector-empty (PR #6271)

    This PR was squashed before being merged into the 2.0 branch (closes #6271).
    
    Commits
    -------
    
    dbafc2c [CssSelector] added css selector with empty string
    
    Discussion
    ----------
    
    [CssSelector] added css selector with empty string
    
    ---------------------------------------------------------------------------
    
    by kosssi at 2012-12-14T18:29:40Z
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    License of the code: MIT
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2013-01-07T08:21:56Z
    
    @fabpot ping
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2013-01-07T10:28:54Z
    
    Sorry, but I don't understand the use case.
    
    ---------------------------------------------------------------------------
    
    by kosssi at 2013-01-07T10:36:31Z
    
    if you have this code :
        \<img src="..." alt="">
    
    you can find
        $this->assertCount(1, $crawler->filter('img[alt=""]'));
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2013-01-07T10:40:12Z
    
    Then, can you change the unit test with the real use case?
    
    ---------------------------------------------------------------------------
    
    by kosssi at 2013-01-07T11:05:50Z
    
    I don't know if it suits you
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2013-01-07T11:07:11Z
    
    thanks
    fabpot committed Jan 7, 2013
  6. [CssSelector] added css selector with empty string

    Simon Constans committed with fabpot Dec 11, 2012
Commits on Jan 6, 2013
Commits on Jan 5, 2013
  1. Revert "merged branch egeloen/f-2.0-terminal-width (PR #6571)"

    This reverts commit 5157693, reversing
    changes made to cd0a9d7.
    fabpot committed Jan 5, 2013
  2. merged branch fabpot/container-dumper-fixes (PR #6565)

    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    e0923ae [DependencyInjection] fixed PhpDumper optimizations when an inlined service depends on the current one indirectly
    cd15390 [DependencyInjection] fixed PhpDumper when an inlined service definition has some properties
    e939a42 [DependencyInjection] added some tests for PhpDumper when the container is compiled
    3827e3e [DependencyInjection] fixed CS
    
    Discussion
    ----------
    
    [DependencyInjection] Fixed PhpDumper when compiling inlined services
    fabpot committed Jan 5, 2013
  3. merged branch stloyd/patch-1 (PR #6572)

    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    ba2d035 Restrict Monolog version to be in version <1.3
    
    Discussion
    ----------
    
    [2.0] Restrict Monolog version to be in version <1.3
    
    Because of conflict between `HttpKernel\Log\LoggerInterface` and `Psr\Log\LoggerInterface` (PSR-3).
    
    Main `composer.json` already restricts to proper version, but bridge allows also conflicting version.
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2013-01-05T14:58:18Z
    
    Looks fine, I will try to wrap up the 1.3.0 soon so you can migrate the code to use it (well it can already be done I guess in the master branch).
    fabpot committed Jan 5, 2013
  4. Restrict Monolog version to be in version <1.3

    Because of conflict between `HttpKernel\Log\LoggerInterface` and `Psr\Log\LoggerInterface` (PSR-3)
    stloyd committed Jan 5, 2013
  5. merged branch egeloen/f-2.0-terminal-width (PR #6571)

    This PR was merged into the 2.0 branch.
    
    Commits
    -------
    
    f299bd0 [Console] Make getTerminalWith & getTerminalHeight public
    
    Discussion
    ----------
    
    [Console] Make getTerminalWith & getTerminalHeight public
    
    Bug fix: yes
    Feature addition: yes
    Backwards compatibility break: no
    Fixes the following tickets: ~
    Todo: -
    License of the code: MIT
    Documentation PR: ~
    
    After demand in #6567, I open an other one on the 2.0 branch.
    fabpot committed Jan 5, 2013
  6. [DependencyInjection] fixed PhpDumper optimizations when an inlined s…

    …ervice depends on the current one indirectly
    fabpot committed Jan 5, 2013