Permalink
Commits on Dec 8, 2011
  1. updated VERSION for 2.0.7

    fabpot committed Dec 8, 2011
  2. update CONTRIBUTORS for 2.0.7

    fabpot committed Dec 8, 2011
  3. updated CHANGELOG for 2.0.7

    fabpot committed Dec 8, 2011
  4. Adjust doctrine requirements

    Seldaek committed with fabpot Nov 25, 2011
  5. updated vendors for 2.0.7

    fabpot committed Dec 8, 2011
  6. merged branch asm89/remove-unused-variable-2.0 (PR #2803)

    Commits
    -------
    
    6c69592 [FrameworkBundle] Remove unused variable in TemplateLocator
    
    Discussion
    ----------
    
    [FrameworkBundle] Remove unused variable in TemplateLocator
    
    2.0 version of #2799
    fabpot committed Dec 8, 2011
Commits on Dec 7, 2011
  1. [Security] fixed cast

    fabpot committed Dec 7, 2011
  2. merged branch Seldaek/cookiefix (PR #2698)

    Commits
    -------
    
    e06cea9 [HttpFoundation] Cookie values should not be restricted
    
    Discussion
    ----------
    
    [HttpFoundation] Cookie values should not be restricted
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    
    The restriction I removed makes no sense IMO because we do not use setrawcookie() to send cookies. setrawcookie() does throw a warning when the cookie value contains incorrect characters, but not setcookie(). The latter will just urlencode() the value so it becomes valid. This is also what is done by `Cookie::__toString`, so this could be used in combination with header() to just send raw cookies that are valid, even with values that are invalid in their decoded form.
    
    PHP urldecodes cookies on input, so it all works fine.
    fabpot committed Dec 7, 2011
  3. [Validator] The current class isn't set in execution context when doi…

    …ng validateProperty()
    meze committed with fabpot Nov 12, 2011
Commits on Dec 3, 2011
  1. fixed typo

    fabpot committed Dec 3, 2011
  2. merged branch hhamon/doctrine_bridge_cs (PR #2775)

    Commits
    -------
    
    240796e [Bridge] [Doctrine] fixed coding conventions.
    
    Discussion
    ----------
    
    Doctrine bridge cs
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: none
    Todo: none
    fabpot committed Dec 3, 2011
Commits on Dec 2, 2011
  1. [Bridge] [Doctrine] fixed coding conventions.

    Hugo Hamon committed Dec 2, 2011
  2. merged branch proofek/domcrawlerform-radiodisabled (PR #2768)

    Commits
    -------
    
    36c7d03 Fixed GH-2720 - Fix disabled atrribute handling for radio form elements
    
    Discussion
    ----------
    
    Fixed GH-2720 - Fix disabled atrribute handling for radio form elements
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: - GH-2720
    
    I wasn't really sure about the correct approach. This one is very minimalistic and following the existing concept of not duplicating nodes of the same name, but only storing multiple values for the same node. If you think that should be changed, let me know. Hints appreciated.
    
    Thanks
    fabpot committed Dec 2, 2011
  3. [DoctrineBridge] fixed CS

    fabpot committed Dec 2, 2011
  4. merged branch beberlei/SecurityEntityRepositoryIdentifierFix (PR #2765)

    Commits
    -------
    
    3c83b89 [DoctrineBridge] Catch user-error when the identifier is not serialized with the User entity.
    
    Discussion
    ----------
    
    [DoctrineBridge] Catch user-error when the identifier is not serialized ...
    
    ...with the User entity.
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: GH-2670
    
    ---------------------------------------------------------------------------
    
    by stof at 2011/12/01 12:31:37 -0800
    
    is it still needed after doctrine/doctrine2@619a319 ?
    
    ---------------------------------------------------------------------------
    
    by beberlei at 2011/12/01 12:59:05 -0800
    
    Yes i think. It doesn't cost anything to have this check and gives a much better error message than the generic Doctrine one.
    
    ---------------------------------------------------------------------------
    
    by stof at 2011/12/01 13:22:05 -0800
    
    but it gives it only in one case (id missing). It will not handle the case of incomplete composite key which will go to the doctrine error.
    fabpot committed Dec 2, 2011
Commits on Dec 1, 2011
  1. [DoctrineBridge] Catch user-error when the identifier is not serializ…

    …ed with the User entity.
    beberlei committed Dec 1, 2011
  2. merged branch hhamon/xdebug_file_link_fix (PR #2758)

    Commits
    -------
    
    5e5050d [FrameworkBundle] fixed unescaped file_link_format parameter in CodeHelper that made the functional tests fail when checking a 4xx page. The generated file link format used in an HTML stack trace didn't contain an escaped ampersand (&) character. The resulting HTML code was not validable against its DTD and so the Crawler made the tests fail when checking a 4xx page.
    
    Discussion
    ----------
    
    Xdebug file link fix
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: tests suite was broken on my laptop before I changed the code...
    Fixes the following tickets: none
    Todo: none
    fabpot committed Dec 1, 2011
  3. [FrameworkBundle] fixed unescaped file_link_format parameter in CodeH…

    …elper that made the functional tests fail when checking a 4xx page. The generated file link format used in an HTML stack trace didn't contain an escaped ampersand (&) character. The resulting HTML code was not validable against its DTD and so the Crawler made the tests fail when checking a 4xx page.
    Hugo Hamon committed Dec 1, 2011
  4. merged branch pcampr/cs_translation_fix (PR #2737)

    Commits
    -------
    
    0be8820 [FrameworkBundle] fixed small typo in Czech translation
    
    Discussion
    ----------
    
    [FrameworkBundle] fixed small typo in Czech translation
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    
    fixed small typo in Czech translation in validators.cs.xliff
    fabpot committed Dec 1, 2011
  5. merged branch DavidChristmann/fix_gen_entities_namespace (PR #2746)

    Commits
    -------
    
    4a8f101 Fixed problem with multiple occurences of a given namespace. fix #2688
    
    Discussion
    ----------
    
    [Console] [Doctrine] Fixed: Entities are generated in wrong folder (doctrine:generate:entities Namespace)
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: no
    Fixes the following tickets: 2688
    Todo: -
    
    Bug-description:
    In our project we have some bundles from the same root-namespace "ABC" stored under "vendors/bundles/ABC" and some bundles under "src/ABC".
    
    Running the command "$php app/console doctrine:generate:entities ABC" from the commandline generates the entities from "src/ABC/" under "vendors/bundles/ABC/" or vice versa depending on their order in the bundle array in the Appkernel.php.
    
    The error does not occur when the entities are generated by bundlename or by classname.
    
    Bugfix:-description:
    Bugfix was to get the path for each entity class once more before generating the entities. Before the bugfix the path was taken form the first entity class of the namespace without checking if the following entities have a different path.
    fabpot committed Dec 1, 2011
  6. merged branch pscheit/master (PR #2742)

    Commits
    -------
    
    63e2a99 [CssSelector] Fixed Issue for XPathExprOr: missing prefix in string conversion
    
    Discussion
    ----------
    
    [CssSelector] Issue for XPathExprOr: missing prefix in string conversion
    
    Hi there,
    
    I created a small and dumb test for the issue. I looked at the original implementation and i think the problem is, that private properties are used in the parent class for xPathExprOr. so that the prefix cannot be accessd with $this->prefix in XPathExprOr
    However I think the distribution for the prefix should be put in the parts of the or-sub-expressions the way it is shown in the test.
    
    Hope this helps.
    
    Best regards
    Philipp
    fabpot committed Dec 1, 2011
  7. merged branch conf/test-fixes-for-ci.qa.php.net-2.0 (PR #2750)

    Commits
    -------
    
    c1a798e Another style fix.
    eba9de1 Code style fix.
    0b1abb3 1. Separated testing diacritic letters with additional check for mbstring in Symfony\Tests\Component\Console\Helper\FormatterHelperTest.php. 2. Added check if French locale was correctly set, skip the test otherwise in  Symfony\Tests\Component\Yaml\InlineTest.php. 3. Inverted check for Windows platform since testing finding php with suffixes has meaning only in Windows in Symfony\Tests\Component\Process\PhpExecutableFinderTest.php.
    
    Discussion
    ----------
    
    Test fixes for ci.qa.php.net 2.0
    
    This is remake of #2749 against 2.0 as requested by stof. Code style fix also applied.
    
    Original message below:
    My name is Shein Alexey and I'm writing on behalf of php-qa team. As you probably know we've set up build server for testing major php versions (5.3, 5.4 and trunk for now) on the url http://ci.qa.php.net. There's also an initiative also check these versions against major php projects with good test coverage like symfony.
    In our symfony builds some tests constantly fail (see http://ci.qa.php.net/view/php-userland/job/php-symfony2/420/testReport/ for example) so here are the fixes I come up with:
    
    Separated testing diacritic letters with additional check for mbstring in Symfony\Tests\Component\Console\Helper\FormatterHelperT
    Added check if French locale was correctly set, skip the test otherwise in Symfony\Tests\Component\Yaml\InlineTest.php.
    Inverted check for Windows platform since testing finding php with suffixes has meaning only in Windows in Symfony\Tests\Component\Process\PhpExecutableFinderTest.php.
    There is also erratic test Symfony\Tests\Component\HttpKernel\HttpCache\HttpCacheTest:testFetchesFullResponseWhenCacheStaleAndNoValidatorsPresent which randomly fails when Age header is non-zero, I'm not sure what to do here, maybe this check should be deleted since page can have age greater than zero.
    
    Let me know what you think.
    Thank you.
    fabpot committed Dec 1, 2011
  8. merged branch canni/fix_call (PR #2755)

    Commits
    -------
    
    769c17b Throw exceptions in case someone forgot to set method name in call.
    
    Discussion
    ----------
    
    [BugFix][DIC] Throw exception to avoid PHP fatal error in generated container class
    
    Bug fix: yes
    Feature add: no
    Symfony2 tests pass: yes
    Symfony2 tests added: yes
    
    In general without this exception generated by php dumper container class, will cause PHP fatal error, bacause method call will look like this: `$instance->(/* arguments*/);`.
    
    ---------------------------------------------------------------------------
    
    by canni at 2011/11/30 06:51:49 -0800
    
    @stof done.
    fabpot committed Dec 1, 2011
Commits on Nov 30, 2011
  1. Throw exceptions in case someone forgot to set method name in call.

    Bug fix: yes
    Feature add: no
    Symfony2 tests pass: yes
    Symfony2 tests added: yes
    
    In general without this exception generated by php dumper container class, will cause PHP fatal error, bacause method call will look like this: `$instance->(/* arguments*/);`.
    canni committed Nov 30, 2011
Commits on Nov 29, 2011
  1. Another style fix.

    conf committed Nov 29, 2011
  2. Code style fix.

    conf committed Nov 29, 2011
  3. 1. Separated testing diacritic letters with additional check for mbst…

    …ring in Symfony\Tests\Component\Console\Helper\FormatterHelperTest.php.
    
    2. Added check if French locale was correctly set, skip the test otherwise in  Symfony\Tests\Component\Yaml\InlineTest.php.
    3. Inverted check for Windows platform since testing finding php with suffixes has meaning only in Windows in Symfony\Tests\Component\Process\PhpExecutableFinderTest.php.
    conf committed Nov 29, 2011