Permalink
Commits on Dec 26, 2011
  1. updated VERSION for 2.0.8

    fabpot committed Dec 26, 2011
  2. update CONTRIBUTORS for 2.0.8

    fabpot committed Dec 26, 2011
  3. updated CHANGELOG for 2.0.8

    fabpot committed Dec 26, 2011
  4. updated vendors for 2.0.8

    fabpot committed Dec 26, 2011
Commits on Dec 25, 2011
  1. merged branch lsmith77/filesystem_forward_compat (PR #2956)

    Commits
    -------
    
    6e98730 added forwards compatibility for the Filesystem component
    
    Discussion
    ----------
    
    added forwards compatibility for the Filesystem component
    
    see #2949 and #2946
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2011/12/25 05:24:01 -0800
    
    👍
    
    ---------------------------------------------------------------------------
    
    by ManuelAC at 2011/12/25 06:38:44 -0800
    
    👍
    
    ---------------------------------------------------------------------------
    
    by NAYZO at 2011/12/25 07:45:55 -0800
    
    👍
    
    ---------------------------------------------------------------------------
    
    by avalanche123 at 2011/12/25 09:52:59 -0800
    
    I think extracting interface and committing it to both branches is preferable.
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/12/25 12:17:59 -0800
    
    what interface?
    
    ---------------------------------------------------------------------------
    
    by avalanche123 at 2011/12/25 12:19:03 -0800
    
    FilesystemInterface
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/12/25 12:22:31 -0800
    
    an interface doesn't really relate to this PR .. aka its a separate topic. the purpose of this PR is to make it easier to write code targeting with 2.0 and 2.1 with minimal impact.
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2011/12/25 12:23:51 -0800
    
    Seems overkill to add an interface here. I dont think there are different implementations.
    
    Le 25 déc. 2011 à 21:19, Bulat Shakirzyanov<reply@reply.github.com> a écrit :
    
    > FilesystemInterface
    >
    > ---
    > Reply to this email directly or view it on GitHub:
    > #2956 (comment)
    
    ---------------------------------------------------------------------------
    
    by avalanche123 at 2011/12/25 12:28:49 -0800
    
    @lsmith77 point taken, makes sense
    @willdurand there are plenty of alternatives to default filesystem (databases, s3, etc.)
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2011/12/25 12:52:58 -0800
    
    Gaufrette (KnpLabs) is suitable for what you describe. I don't know if this component is designed to handle various adapters.
    This is just a layer for files manipulations on disk.
    
    Le 25 déc. 2011 à 21:28, Bulat Shakirzyanov<reply@reply.github.com> a écrit :
    
    > @lsmith77 point taken, makes sense
    > @willdurand there are plenty of alternatives to default filesystem (databases, s3, etc.)
    >
    > ---
    > Reply to this email directly or view it on GitHub:
    > #2956 (comment)
    fabpot committed Dec 25, 2011
Commits on Dec 23, 2011
  1. [TwigBridge] simplified code

    fabpot committed Dec 23, 2011
Commits on Dec 22, 2011
  1. merged branch kriswallsmith/http/apache-request (PR #2940)

    Commits
    -------
    
    1b4aaa2 [HttpFoundation] fixed ApacheRequest
    
    Discussion
    ----------
    
    [HttpFoundation] fixed ApacheRequest
    
    Pathinfo was incorrect when using mod_rewrite.
    Added better test coverage.
    fabpot committed Dec 22, 2011
Commits on Dec 21, 2011
  1. [HttpFoundation] fixed ApacheRequest

    Pathinfo was incorrect when using mod_rewrite.
    Added better test coverage.
    kriswallsmith committed Dec 21, 2011
  2. merged branch marekkalnik/upload-flash (PR #2938)

    Commits
    -------
    
    8235848 [HttpFoundation][File] Add flv file default extension
    
    Discussion
    ----------
    
    [HttpFoundation][File] Add flv file default extension
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes (doesn't affect tests)
    Fixes the following tickets: -
    Todo: -
    
    This commit adds default extension for video/x-flv mime-type, which is a Flash Video file. Lack of this definition causes File::guessExtension() return null for this type of file, which breaks uploaded file in some user cases.
    fabpot committed Dec 21, 2011
  3. merged branch mdemirci/2.0 (PR #2937)

    Commits
    -------
    
    5a6c989 FrameworkBundle: Adding test-attribute in xsd-schema to write functional-tests if using xml-configurations
    
    Discussion
    ----------
    
    [FrameworkBundle] Adding test-attribute in xsd-schema
    
     to write functional-tests if using xml-configurations
    fabpot committed Dec 21, 2011
  4. FrameworkBundle: Adding test-attribute in xsd-schema to write functio…

    …nal-tests if using xml-configurations
    mdemirci committed Dec 21, 2011
Commits on Dec 20, 2011
  1. merged branch Tobion/patch-3 (PR #2931)

    Commits
    -------
    
    1eb5583 fixes #2906
    
    Discussion
    ----------
    
    Fix for #2906
    
    closes #2906
    fabpot committed Dec 20, 2011
  2. fixes #2906

    Tobion committed Dec 20, 2011
Commits on Dec 19, 2011
  1. merged branch aerialls/webprofiler (PR #2925)

    Commits
    -------
    
    b0987a3 [WebProfilerBundle] fixed toolbar height
    
    Discussion
    ----------
    
    [WebProfilerBundle] fixed toolbar height
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: none
    Todo: none
    fabpot committed Dec 19, 2011
  2. merged branch stof/entity_provider_proxy (PR #2922)

    Commits
    -------
    
    649fa52 [DoctrineBridge] Fixed the entity provider to support proxies
    29f4111 [DoctrineBridge] Added a failing test showing the issue for proxy users
    
    Discussion
    ----------
    
    Fixed the entity provider to support proxies
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: yes
    Symfony2 tests pass: yes
    
    If a proxy object was used, the ``supportsClass`` method would fail becasue it does a string comparison for the class name.
    
    This issue has not been reported by users yet because it is an edge case:
    
    - ``supportsClass`` is used only in the RememberMe system
    - getting a proxy in the entity provider is possible only if a listener running before the firewall loaded an object which has a relation to the user, which is far from being a standard use case.
    
    ---------------------------------------------------------------------------
    
    by schmittjoh at 2011/12/19 10:07:46 -0800
    
    How about using the new proxy tools that Doctrine has?
    
    ---------------------------------------------------------------------------
    
    by stof at 2011/12/19 10:20:37 -0800
    
    the new tool will only be available in 2.2 so only for Symfony 2.1. Once merged into master, we could eventually refactor it in the master branch to use ``Doctrine\Common\Util\ClassUtils``
    fabpot committed Dec 19, 2011
  3. [WebProfilerBundle] fixed toolbar height

    Julien Brochet committed Dec 19, 2011
Commits on Dec 18, 2011
  1. fixed CS

    fabpot committed Dec 18, 2011
  2. added a rule to check_cs

    fabpot committed Dec 18, 2011
  3. merged branch stloyd/profiler_design_fix (PR #2907)

    Commits
    -------
    
    d1fa8cc [WebProfiler] Fix some design glitches (closes #2867)
    
    Discussion
    ----------
    
    [WebProfiler] Fix some design glitches
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #2867
    
    ---------------------------------------------------------------------------
    
    by jalliot at 2011/12/17 04:54:11 -0800
    
    Thanks @stloyd.
    However it only fixes the second and third issues related in #2867. The filesystem provider bug is much more annoying!
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2011/12/17 05:38:13 -0800
    
    @jalliot Did you cleaned profiler dir after update to latest master commit ? This is mentioned and kinda known BC break... I'm asking because I cannot reproduce this issue.
    
    ---------------------------------------------------------------------------
    
    by jalliot at 2011/12/17 08:17:21 -0800
    
    @stloyd It has nothing to do with your recent PR adding HTTP method as I had the bug even before that.
    I've tested on a fresh Symfony (master) install (before and after the merge) and have the bug each time.
    I thought maybe it was related to some of the bundles I installed but the bug occurs even in a freshly installed SE.
    fabpot committed Dec 18, 2011
  4. merged branch canni/fix_type_hint (PR #2912)

    Commits
    -------
    
    e417153 [BugFix][Console] Fix type hint for output formatter
    
    Discussion
    ----------
    
    [BugFix][Console] Fix type hint for OutputFormatter in OutputStream constructors
    
    I consider this as a bug, cause it disables ability to change formatter implementation
    
    BugFix: yes
    Feature addition: no
    Sysmfony2 test pass: yes
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/12/18 00:23:05 -0800
    
    It's not a bug fix as existing code that extend these classes will now fail.
    
    ---------------------------------------------------------------------------
    
    by stof at 2011/12/18 03:51:38 -0800
    
    @fabpot does the constructor enforces its signature for child classes ? I don't think so.
    fabpot committed Dec 18, 2011
  5. tweaked the README files

    fabpot committed Dec 18, 2011
  6. merged branch lsmith77/component_readmes (PR #2561)

    Commits
    -------
    
    1e370d7 typo fix
    93d8d44 added some more infos about Config
    27efd59 added READMEs for the bridges
    34fc866 cosmetic tweaks
    d6af3f1 fixed README for Console
    6a72b8c added basic README files for all components
    
    Discussion
    ----------
    
    added basic README files for all components and bridges
    
    heavily based on http://fabien.potencier.org/article/49/what-is-symfony2 and the official Symfony2 documentation
    
    ---------------------------------------------------------------------------
    
    by jmikola at 2011/11/03 13:36:07 -0700
    
    Great work. For syntax highlighting on the PHP snippets, you could add "php" after the three backticks.
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/03 13:41:29 -0700
    
    done
    
    ---------------------------------------------------------------------------
    
    by stealth35 at 2011/11/03 13:49:31 -0700
    
    Nice job, but you also need to add `<?php`
    
    ex :
    
    ``` php
    <?php
    use Symfony\Component\DomCrawler\Crawler;
    
    $crawler = new Crawler();
    $crawler->addContent('<html><body><p>Hello World!</p></body></html>');
    
    print $crawler->filter('body > p')->text();
    ```
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/03 13:56:57 -0700
    
    done
    
    ---------------------------------------------------------------------------
    
    by ericclemmons at 2011/11/03 19:57:57 -0700
    
    @lsmith77 Well done!  This makes consumption of individual components that much easier, *especially* now that `composer.json` files have been added.
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/04 01:18:23 -0700
    
    ok .. fixed the issues you mentioned @fabpot
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/11 15:00:27 -0800
    
    @fabpot anything else left? seems like an easy merge .. and imho there is considerable benefit for our efforts to spread the word about the components with this PR merged.
    
    ---------------------------------------------------------------------------
    
    by drak at 2011/11/11 18:54:13 -0800
    
    You know, it might be a nice idea to put a link to the documentation for each component if there is some at symfony.com
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/12 00:59:14 -0800
    
    i did that in some. but i might have missed a few places.
    On 12.11.2011, at 03:54, Drak <reply@reply.github.com> wrote:
    
    > You know, it might be a nice idea to put a link to the documentation for each component if there is some at symfony.com
    >
    > ---
    > Reply to this email directly or view it on GitHub:
    > #2561 (comment)
    
    ---------------------------------------------------------------------------
    
    by breerly at 2011/11/21 10:28:36 -0800
    
    Pretty excited with this.
    
    ---------------------------------------------------------------------------
    
    by dbu at 2011/11/24 00:02:50 -0800
    
    is there anything we can help with to make this ready to be merged?
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/12/18 02:39:23 -0800
    
    @fabpot: seriously .. if you are not going to deliver something "better" and don't provide a reason what is wrong with this .. then its beyond frustrating. i obviously do not claim that these README's are perfect (and certainly still no replacement for proper documentation), but I do claim that in their current form they are a radical step forward to potential users of the Symfony2 components.
    fabpot committed Dec 18, 2011
Commits on Dec 17, 2011
  1. merged branch stloyd/set-cookie-fix (PR #2889)

    Commits
    -------
    
    5c41ec9 [HttpKernel][Client] Only simple (name=value without any other params) cookies can be stored in same line, so lets add every as standalone to be compliant with rfc6265
    
    Discussion
    ----------
    
    [HttpKernel][Client] Set cookie fix
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no(?)
    Symfony2 tests pass: yes
    Fixes the following tickets: #2881
    
    Only simple cookies can be stored in same line:
    
    * Used by now (__wrong__): `Set-Cookie: name1=value, name2=value`
    * Proper according to RFCs: `Set-Cookie: name1=value; name2=value`
    
    So lets add every as standalone ([next header](http://tools.ietf.org/html/rfc6265#section-3.1)) to be compliant with [RFC6265](http://tools.ietf.org/html/rfc6265). This fixes #2881.
    fabpot committed Dec 17, 2011
  2. merged branch stloyd/local_stub_cs (PR #2890)

    Commits
    -------
    
    ed353da [Locale][Stub] Fixed CS
    
    Discussion
    ----------
    
    [Locale][Stub] Fixed CS
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    
    Just fixed code according to Symfony2 CS.
    fabpot committed Dec 17, 2011
  3. fixed functional tests so that the cache/logs are specific to one ver…

    …sion of Symfony (to avoid weird side effects)
    fabpot committed Dec 17, 2011
Commits on Dec 16, 2011
  1. merged branch drak/frameworkbundle_moretests (PR #2904)

    Commits
    -------
    
    9b8cdab [FrameworkBundle] Prove client insulation and non-insulation works in session tests.
    ce66548 [FrameworkBundle] Add tests to prove functional testing works with simultaneous clients.
    ff0412a [FrameworkBundle] Small changes to test setup.
    
    Discussion
    ----------
    
    [FrameworkBundle] Added functional tests to prove multiple clients and client insulation.
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    References: #2898
    Todo: -
    
    @fabpot: I don't know what happened with the previous PR #2989 - seemed like some weird corruption as the tests passed locally and on travis except until after I fetched from the repo.  I suspect something was corrupted.  I asked @Seldaek to confirm the tests pass on his local setup before I submitted this PR.  I only got rid of the errors locally after recloning the repo!
    
    http://travis-ci.org/#!/drak/symfony/builds/413515
    
    [![Build Status](https://secure.travis-ci.org/drak/symfony.png)](http://travis-ci.org/drak/symfony?branch=frameworkbundle_moretests)
    fabpot committed Dec 16, 2011