Skip to content
Commits on Dec 26, 2011
  1. @fabpot

    updated VERSION for 2.0.8

    fabpot committed
Commits on Dec 25, 2011
  1. @fabpot

    merged branch lsmith77/filesystem_forward_compat (PR #2956)

    fabpot committed
    Commits
    -------
    
    6e98730 added forwards compatibility for the Filesystem component
    
    Discussion
    ----------
    
    added forwards compatibility for the Filesystem component
    
    see #2949 and #2946
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2011/12/25 05:24:01 -0800
    
    :+1:
    
    ---------------------------------------------------------------------------
    
    by ManuelAC at 2011/12/25 06:38:44 -0800
    
    :+1:
    
    ---------------------------------------------------------------------------
    
    by NAYZO at 2011/12/25 07:45:55 -0800
    
    :+1:
    
    ---------------------------------------------------------------------------
    
    by avalanche123 at 2011/12/25 09:52:59 -0800
    
    I think extracting interface and committing it to both branches is preferable.
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/12/25 12:17:59 -0800
    
    what interface?
    
    ---------------------------------------------------------------------------
    
    by avalanche123 at 2011/12/25 12:19:03 -0800
    
    FilesystemInterface
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/12/25 12:22:31 -0800
    
    an interface doesn't really relate to this PR .. aka its a separate topic. the purpose of this PR is to make it easier to write code targeting with 2.0 and 2.1 with minimal impact.
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2011/12/25 12:23:51 -0800
    
    Seems overkill to add an interface here. I dont think there are different implementations.
    
    Le 25 déc. 2011 à 21:19, Bulat Shakirzyanov<reply@reply.github.com> a écrit :
    
    > FilesystemInterface
    >
    > ---
    > Reply to this email directly or view it on GitHub:
    > #2956 (comment)
    
    ---------------------------------------------------------------------------
    
    by avalanche123 at 2011/12/25 12:28:49 -0800
    
    @lsmith77 point taken, makes sense
    @willdurand there are plenty of alternatives to default filesystem (databases, s3, etc.)
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2011/12/25 12:52:58 -0800
    
    Gaufrette (KnpLabs) is suitable for what you describe. I don't know if this component is designed to handle various adapters.
    This is just a layer for files manipulations on disk.
    
    Le 25 déc. 2011 à 21:28, Bulat Shakirzyanov<reply@reply.github.com> a écrit :
    
    > @lsmith77 point taken, makes sense
    > @willdurand there are plenty of alternatives to default filesystem (databases, s3, etc.)
    >
    > ---
    > Reply to this email directly or view it on GitHub:
    > #2956 (comment)
  2. @fabpot
  3. @lsmith77
Commits on Dec 23, 2011
  1. @fabpot

    [TwigBridge] simplified code

    fabpot committed
Commits on Dec 21, 2011
  1. @kriswallsmith

    [HttpFoundation] fixed ApacheRequest

    kriswallsmith committed
    Pathinfo was incorrect when using mod_rewrite.
    Added better test coverage.
  2. @fabpot

    merged branch marekkalnik/upload-flash (PR #2938)

    fabpot committed
    Commits
    -------
    
    8235848 [HttpFoundation][File] Add flv file default extension
    
    Discussion
    ----------
    
    [HttpFoundation][File] Add flv file default extension
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes (doesn't affect tests)
    Fixes the following tickets: -
    Todo: -
    
    This commit adds default extension for video/x-flv mime-type, which is a Flash Video file. Lack of this definition causes File::guessExtension() return null for this type of file, which breaks uploaded file in some user cases.
  3. @marekkalnik
  4. @mdemirci

    FrameworkBundle: Adding test-attribute in xsd-schema to write functio…

    mdemirci committed
    …nal-tests if using xml-configurations
Commits on Dec 20, 2011
  1. @Tobion

    fixes #2906

    Tobion committed
Commits on Dec 19, 2011
  1. @fabpot

    merged branch aerialls/webprofiler (PR #2925)

    fabpot committed
    Commits
    -------
    
    b0987a3 [WebProfilerBundle] fixed toolbar height
    
    Discussion
    ----------
    
    [WebProfilerBundle] fixed toolbar height
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: none
    Todo: none
  2. @aerialls
  3. @stof
Commits on Dec 18, 2011
  1. @fabpot

    fixed CS

    fabpot committed
  2. @fabpot

    merged branch stloyd/profiler_design_fix (PR #2907)

    fabpot committed
    Commits
    -------
    
    d1fa8cc [WebProfiler] Fix some design glitches (closes #2867)
    
    Discussion
    ----------
    
    [WebProfiler] Fix some design glitches
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #2867
    
    ---------------------------------------------------------------------------
    
    by jalliot at 2011/12/17 04:54:11 -0800
    
    Thanks @stloyd.
    However it only fixes the second and third issues related in #2867. The filesystem provider bug is much more annoying!
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2011/12/17 05:38:13 -0800
    
    @jalliot Did you cleaned profiler dir after update to latest master commit ? This is mentioned and kinda known BC break... I'm asking because I cannot reproduce this issue.
    
    ---------------------------------------------------------------------------
    
    by jalliot at 2011/12/17 08:17:21 -0800
    
    @stloyd It has nothing to do with your recent PR adding HTTP method as I had the bug even before that.
    I've tested on a fresh Symfony (master) install (before and after the merge) and have the bug each time.
    I thought maybe it was related to some of the bundles I installed but the bug occurs even in a freshly installed SE.
  3. @fabpot

    merged branch canni/fix_type_hint (PR #2912)

    fabpot committed
    Commits
    -------
    
    e417153 [BugFix][Console] Fix type hint for output formatter
    
    Discussion
    ----------
    
    [BugFix][Console] Fix type hint for OutputFormatter in OutputStream constructors
    
    I consider this as a bug, cause it disables ability to change formatter implementation
    
    BugFix: yes
    Feature addition: no
    Sysmfony2 test pass: yes
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/12/18 00:23:05 -0800
    
    It's not a bug fix as existing code that extend these classes will now fail.
    
    ---------------------------------------------------------------------------
    
    by stof at 2011/12/18 03:51:38 -0800
    
    @fabpot does the constructor enforces its signature for child classes ? I don't think so.
  4. @fabpot

    tweaked the README files

    fabpot committed
  5. @fabpot

    merged branch lsmith77/component_readmes (PR #2561)

    fabpot committed
    Commits
    -------
    
    1e370d7 typo fix
    93d8d44 added some more infos about Config
    27efd59 added READMEs for the bridges
    34fc866 cosmetic tweaks
    d6af3f1 fixed README for Console
    6a72b8c added basic README files for all components
    
    Discussion
    ----------
    
    added basic README files for all components and bridges
    
    heavily based on http://fabien.potencier.org/article/49/what-is-symfony2 and the official Symfony2 documentation
    
    ---------------------------------------------------------------------------
    
    by jmikola at 2011/11/03 13:36:07 -0700
    
    Great work. For syntax highlighting on the PHP snippets, you could add "php" after the three backticks.
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/03 13:41:29 -0700
    
    done
    
    ---------------------------------------------------------------------------
    
    by stealth35 at 2011/11/03 13:49:31 -0700
    
    Nice job, but you also need to add `<?php`
    
    ex :
    
    ``` php
    <?php
    use Symfony\Component\DomCrawler\Crawler;
    
    $crawler = new Crawler();
    $crawler->addContent('<html><body><p>Hello World!</p></body></html>');
    
    print $crawler->filter('body > p')->text();
    ```
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/03 13:56:57 -0700
    
    done
    
    ---------------------------------------------------------------------------
    
    by ericclemmons at 2011/11/03 19:57:57 -0700
    
    @lsmith77 Well done!  This makes consumption of individual components that much easier, *especially* now that `composer.json` files have been added.
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/04 01:18:23 -0700
    
    ok .. fixed the issues you mentioned @fabpot
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/11 15:00:27 -0800
    
    @fabpot anything else left? seems like an easy merge .. and imho there is considerable benefit for our efforts to spread the word about the components with this PR merged.
    
    ---------------------------------------------------------------------------
    
    by drak at 2011/11/11 18:54:13 -0800
    
    You know, it might be a nice idea to put a link to the documentation for each component if there is some at symfony.com
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/11/12 00:59:14 -0800
    
    i did that in some. but i might have missed a few places.
    On 12.11.2011, at 03:54, Drak <reply@reply.github.com> wrote:
    
    > You know, it might be a nice idea to put a link to the documentation for each component if there is some at symfony.com
    >
    > ---
    > Reply to this email directly or view it on GitHub:
    > #2561 (comment)
    
    ---------------------------------------------------------------------------
    
    by breerly at 2011/11/21 10:28:36 -0800
    
    Pretty excited with this.
    
    ---------------------------------------------------------------------------
    
    by dbu at 2011/11/24 00:02:50 -0800
    
    is there anything we can help with to make this ready to be merged?
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/12/18 02:39:23 -0800
    
    @fabpot: seriously .. if you are not going to deliver something "better" and don't provide a reason what is wrong with this .. then its beyond frustrating. i obviously do not claim that these README's are perfect (and certainly still no replacement for proper documentation), but I do claim that in their current form they are a radical step forward to potential users of the Symfony2 components.
Commits on Dec 17, 2011
  1. @canni
  2. @stloyd
  3. @fabpot

    merged branch stloyd/set-cookie-fix (PR #2889)

    fabpot committed
    Commits
    -------
    
    5c41ec9 [HttpKernel][Client] Only simple (name=value without any other params) cookies can be stored in same line, so lets add every as standalone to be compliant with rfc6265
    
    Discussion
    ----------
    
    [HttpKernel][Client] Set cookie fix
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no(?)
    Symfony2 tests pass: yes
    Fixes the following tickets: #2881
    
    Only simple cookies can be stored in same line:
    
    * Used by now (__wrong__): `Set-Cookie: name1=value, name2=value`
    * Proper according to RFCs: `Set-Cookie: name1=value; name2=value`
    
    So lets add every as standalone ([next header](http://tools.ietf.org/html/rfc6265#section-3.1)) to be compliant with [RFC6265](http://tools.ietf.org/html/rfc6265). This fixes #2881.
  4. @fabpot

    merged branch stloyd/local_stub_cs (PR #2890)

    fabpot committed
    Commits
    -------
    
    ed353da [Locale][Stub] Fixed CS
    
    Discussion
    ----------
    
    [Locale][Stub] Fixed CS
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    
    Just fixed code according to Symfony2 CS.
  5. @fabpot

    fixed functional tests so that the cache/logs are specific to one ver…

    fabpot committed
    …sion of Symfony (to avoid weird side effects)
Commits on Dec 16, 2011
  1. [FrameworkBundle] Prove client insulation and non-insulation works in…

    Drak committed
    … session tests.
  2. [FrameworkBundle] Add tests to prove functional testing works with si…

    Drak committed
    …multaneous clients.
  3. @aboks

    [DoctrineBundle] Fixed incorrectly shown params

    aboks committed
    After the changes in #2733, the parameters to Doctrine queries were
    always shown as 'Array' in the profiler. This commit puts back the
    yaml_encode that is still needed after all.
Commits on Dec 15, 2011
  1. @fabpot

    [SwiftmailerBundle] fixed the send email command when the queue does …

    fabpot committed
    …not extends Swift_ConfigurableSpool
  2. @stloyd

    [Locale][Stub] Fixed CS

    stloyd committed
  3. @stloyd

    [HttpKernel][Client] Only simple (name=value without any other params…

    stloyd committed
    …) cookies can be stored in same line, so lets add every as standalone to be compliant with rfc6265
  4. @fabpot

    merged branch drak/securitybundle_test (PR #2888)

    fabpot committed
    Commits
    -------
    
    62f3dc4 [SecurityBundle] Changed environment to something unique.
    
    Discussion
    ----------
    
    [SecurityBundle] Fix name clash with functional tests
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    
    Functional tests need a unique environment or it will produce class redeclare errors when multiple bundles are functional tested at the same time.
  5. [FrameworkBundle] Added functional tests.

    Drak committed
    Added functional tests to prove session attributes and flashes in practice.
  6. @stloyd
  7. @jmikola

    [Console] Improve input definition output for Boolean defaults

    jmikola committed
    Previously, Boolean defaults were printed as strings, which lead to true and false being printed as "1" and "", respectively. With this change, they are now printed as "true" and "false".
  8. [SecurityBundle] Changed environment to something unique.

    Drak committed
    If you run functional tests from different bundles you it will cause a redeclare error
    because the DIC appKernel name is not unique.
Something went wrong with that request. Please try again.