Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Jan 6, 2012
  1. @fabpot

    updated VERSION for 2.0.9

    fabpot authored
  2. @fabpot
Commits on Jan 5, 2012
  1. @Tobion
  2. @fabpot

    merged branch justinrainbow/2_0_framework_bundle_fix (PR #3039)

    fabpot authored
    Commits
    -------
    
    7c8bd3d [FrameworkBundle] Invalid composer ref fix
    
    Discussion
    ----------
    
    [FrameworkBundle] Invalid composer ref fix
    
    Changes the `composer.json` reference in the FrameworkBundle to use the `symfony/translation` package rather than the current `symfony/translator` (which doesn't exist).
  3. @justinrainbow

    [FrameworkBundle] Invalid composer ref fix

    justinrainbow authored
    The composer.json was referencing a "symfony/translator" package
    which does not exist.  This has been updated to use the
    "symfony/translation" package.
  4. @fabpot
  5. @fabpot

    merged branch tystr/sanitize_queries_fix (PR #3032)

    fabpot authored
    Commits
    -------
    
    261325d Cast $query['params'] to array to ensure it is a valid argument for the foreach.
    
    Discussion
    ----------
    
    [DoctrineBridge] Account for $query['params'] being null in DoctrineDataCollector's sanitizeQueries method
    
    I was getting this error because inside the sanitizeQueries method of DoctrineDataCollector, there's no handling for $query['params'] being null.
    
    ErrorException: Warning: Invalid argument supplied for foreach() in .../vendor/symfony/src/Symfony/Bridge/Doctrine/DataCollector/DoctrineDataCollector.php line 91
  6. @franmomu
Commits on Jan 4, 2012
  1. @tystr

    Cast $query['params'] to array to ensure it is a valid argument for t…

    tystr authored
    …he foreach.
    
    This prevents errors if $query['params'] is null
Commits on Jan 1, 2012
  1. slovenian validators translations correction

    Peter Kokot authored
Commits on Dec 29, 2011
  1. @hhamon
Commits on Dec 28, 2011
  1. @fabpot

    merged branch ericclemmons/2884-parameterbag-with-spaces (PR #2976)

    fabpot authored
    Commits
    -------
    
    85ca8e3 ParameterBag no longer resolves parameters that have spaces.
    99011ca Added tests for ParameterBag parameters with spaces
    
    Discussion
    ----------
    
    [DependencyInjection] Parameters with spaces are not resolved
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no (not likely, according to convention)
    Symfony2 tests pass: yes
    Fixes the following tickets: #2884
    
    `ParameterBag` currently resolves anything between two `%` signs, which creates issues for any parameters in the DIC that are legitimate text.  This PR enforces the [documented parameter convention](http://symfony.com/doc/2.0/book/service_container.html#service-parameters) so that only `%parameters.with.no_spaces%` are resolved.
    
    I was considering using instead `^%([^\w\._-]+)%$`, but felt that was too constricting & could easily introduce issues with existing applications.
  2. @fabpot

    merged branch havvg/patch-1 (PR #2957)

    fabpot authored
    Commits
    -------
    
    41950a6 [WebProfilerBundle] add margin-bottom to caption
    
    Discussion
    ----------
    
    [WebProfilerBundle] add margin-bottom to caption
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2011/12/26 13:15:57 -0800
    
    What does it fix?
    
    ---------------------------------------------------------------------------
    
    by havvg at 2011/12/27 02:46:16 -0800
    
    Just a minor design issue with table captions.
    
    Without: http://dl.dropbox.com/u/548684/PR2957/without-margin.png
    With: http://dl.dropbox.com/u/548684/PR2957/with-margin.png
    
    I currently hold it in a custom css, but thought it is generic enough to be put into the bundle.
    
    ---------------------------------------------------------------------------
    
    by henrikbjorn at 2011/12/27 04:03:53 -0800
    
    @havvg What custom bundle is that ? and what does it show? look interesting
    
    ---------------------------------------------------------------------------
    
    by havvg at 2011/12/27 04:40:18 -0800
    
    @henrikbjorn It's a bundle (not published yet, https://github.com/havvg/HavvgCloudcontrolBundle) adding features to fully utilize applications on http://cloudcontrol.com PaaS.
  3. @fabpot

    merged branch javiereguiluz/phpdoc-console-component (PR #2978)

    fabpot authored
    Commits
    -------
    
    3f2e1b0 [Console] Updated tests to reflect the change from `program` to `application`
    2b64944 [Console][Output] Fixed some minor typos and grammatical errors
    96997f1 [Console][Input] Added missing PHPDoc and fixed some minor typos and grammatical errors
    855b8af [Console][Helper] Added missing PHPDoc and fixed some minor typos and grammatical errors
    3ad02bd [Console][Formatter] Added missing PHPDoc @throws and fixed some minor typos and grammatical errors
    33e3f11 [Console] Added a missing PHPDoc and replaced `program` by `application`
    
    Discussion
    ----------
    
    [Console] Fixed and completed PHPDoc
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    
    Fixes the following tickets: -
    
    * Fixed minor typos and grammatical errors
    * Added missing PHPDoc for some methods
    * Added missing @throws
  4. @javiereguiluz
  5. @javiereguiluz
  6. @javiereguiluz
  7. @javiereguiluz

    [Console][Formatter] Added missing PHPDoc @throws and fixed some mino…

    javiereguiluz authored
    …r typos and grammatical errors
  8. @javiereguiluz
Commits on Dec 27, 2011
  1. @ericclemmons

    ParameterBag no longer resolves parameters that have spaces.

    ericclemmons authored
    They must be strictly "%some.parameter%" or similar.
  2. @fabpot
  3. @fabpot

    merged branch lsmith77/forward_compat_filesystem (PR #2971)

    fabpot authored
    Commits
    -------
    
    aacb2de use the forward compat version in the Filesystem service
    
    Discussion
    ----------
    
    use the forward compat version in the Filesystem service
    
    Bug fix: no
    Feature addition: yes
    Backwards compatibility break: no
    Symfony2 tests pass: ![Build Status](https://secure.travis-ci.org/lsmith77/symfony.png?branch=forward_compat_filesystem)
    Fixes the following tickets: -
    
    by changing the service it should fix any type hints for the Filesystem class inside 2.1, but it shouldn't affect anyone still type hinting the old location in 2.0 since the new forward compat file extends the old file.
    
    See
    liip/LiipImagineBundle@00c988b#commitcomment-820879
    
    ---------------------------------------------------------------------------
    
    by tobiassjosten at 2011/12/26 18:41:45 -0800
    
    :+1:
Commits on Dec 26, 2011
  1. @lsmith77
  2. @fabpot

    merged branch javiereguiluz/add-unique-entity-spanish-translation (PR #…

    fabpot authored
    …2968)
    
    Commits
    -------
    
    eb2d6e6 [FrameworkBundle] Added UniqueEntity message translation for Spanish
    
    Discussion
    ----------
    
    [FrameworkBundle] Added UniqueEntity message translation for Spanish
  3. @javiereguiluz
  4. @weaverryan
  5. @fabpot

    updated VERSION for 2.0.8

    fabpot authored
Commits on Dec 25, 2011
  1. @fabpot

    merged branch lsmith77/filesystem_forward_compat (PR #2956)

    fabpot authored
    Commits
    -------
    
    6e98730 added forwards compatibility for the Filesystem component
    
    Discussion
    ----------
    
    added forwards compatibility for the Filesystem component
    
    see #2949 and #2946
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2011/12/25 05:24:01 -0800
    
    :+1:
    
    ---------------------------------------------------------------------------
    
    by ManuelAC at 2011/12/25 06:38:44 -0800
    
    :+1:
    
    ---------------------------------------------------------------------------
    
    by NAYZO at 2011/12/25 07:45:55 -0800
    
    :+1:
    
    ---------------------------------------------------------------------------
    
    by avalanche123 at 2011/12/25 09:52:59 -0800
    
    I think extracting interface and committing it to both branches is preferable.
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/12/25 12:17:59 -0800
    
    what interface?
    
    ---------------------------------------------------------------------------
    
    by avalanche123 at 2011/12/25 12:19:03 -0800
    
    FilesystemInterface
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2011/12/25 12:22:31 -0800
    
    an interface doesn't really relate to this PR .. aka its a separate topic. the purpose of this PR is to make it easier to write code targeting with 2.0 and 2.1 with minimal impact.
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2011/12/25 12:23:51 -0800
    
    Seems overkill to add an interface here. I dont think there are different implementations.
    
    Le 25 déc. 2011 à 21:19, Bulat Shakirzyanov<reply@reply.github.com> a écrit :
    
    > FilesystemInterface
    >
    > ---
    > Reply to this email directly or view it on GitHub:
    > #2956 (comment)
    
    ---------------------------------------------------------------------------
    
    by avalanche123 at 2011/12/25 12:28:49 -0800
    
    @lsmith77 point taken, makes sense
    @willdurand there are plenty of alternatives to default filesystem (databases, s3, etc.)
    
    ---------------------------------------------------------------------------
    
    by willdurand at 2011/12/25 12:52:58 -0800
    
    Gaufrette (KnpLabs) is suitable for what you describe. I don't know if this component is designed to handle various adapters.
    This is just a layer for files manipulations on disk.
    
    Le 25 déc. 2011 à 21:28, Bulat Shakirzyanov<reply@reply.github.com> a écrit :
    
    > @lsmith77 point taken, makes sense
    > @willdurand there are plenty of alternatives to default filesystem (databases, s3, etc.)
    >
    > ---
    > Reply to this email directly or view it on GitHub:
    > #2956 (comment)
  2. @fabpot
  3. @havvg
  4. @lsmith77
Commits on Dec 23, 2011
  1. @fabpot

    [TwigBridge] simplified code

    fabpot authored
Commits on Dec 21, 2011
  1. @kriswallsmith

    [HttpFoundation] fixed ApacheRequest

    kriswallsmith authored
    Pathinfo was incorrect when using mod_rewrite.
    Added better test coverage.
  2. @fabpot

    merged branch marekkalnik/upload-flash (PR #2938)

    fabpot authored
    Commits
    -------
    
    8235848 [HttpFoundation][File] Add flv file default extension
    
    Discussion
    ----------
    
    [HttpFoundation][File] Add flv file default extension
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes (doesn't affect tests)
    Fixes the following tickets: -
    Todo: -
    
    This commit adds default extension for video/x-flv mime-type, which is a Flash Video file. Lack of this definition causes File::guessExtension() return null for this type of file, which breaks uploaded file in some user cases.
  3. @marekkalnik
Something went wrong with that request. Please try again.