Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Sep 6, 2012
  1. @fabpot

    updated VERSION for 2.1.0

    fabpot authored
  2. @fabpot

    Merge branch '2.0'

    fabpot authored
    * 2.0:
      bumped Symfony version to 2.0.18-DEV
    
    Conflicts:
    	src/Symfony/Component/HttpKernel/Kernel.php
Commits on Sep 5, 2012
  1. @fabpot

    Revert "merged branch Tobion/strictrequirements (PR #5181)"

    fabpot authored
    This reverts commit 2da2a44, reversing
    changes made to 5885547.
  2. @fabpot

    Revert "merged branch Tobion/requirementscheck (PR #5187)"

    fabpot authored
    This reverts commit 2cf50b7, reversing
    changes made to 569e29d.
  3. @fabpot

    Revert "merged branch Tobion/uselessparamdefaults (PR #5400)"

    fabpot authored
    This reverts commit 0f61b2e, reversing
    changes made to 5e7723f.
Commits on Sep 4, 2012
  1. @fabpot

    merged branch beberlei/RevertDbalAcl (PR #5253)

    fabpot authored
    Commits
    -------
    
    1b5ad17 Revert "Removed MySQL-exclusive usage of unsigned integer from table creation"
    
    Discussion
    ----------
    
    [Security][DBAL] Revert MySQL unsigned removal
    
    Revert "Removed MySQL-exclusive usage of unsigned integer from table creation"
    
    This reverts commit 57694aa.
    
    The problem is underlying in Doctrine DBAL change tracking and should
    either be fixed or ignored there.
    
    I opened a ticket on Doctrine Jira http://doctrine-project.org/jira/browse/DBAL-322
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-14T06:40:47Z
    
    I will merge this PR after we have a release of DBAL that includes the fix for DBAL-322.
    
    ---------------------------------------------------------------------------
    
    by acasademont at 2012-08-20T08:01:48Z
    
    This was already fixed 2 weeks ago in doctrine/dbal#183 so i guess this can be closed
    
    ---------------------------------------------------------------------------
    
    by acasademont at 2012-08-20T08:02:06Z
    
    merged i mean
  2. @fabpot

    merged branch eventhorizonpl/100ptc_component_httpfundation (PR #5409)

    fabpot authored
    Commits
    -------
    
    3036b00 JsonResponseTest
    
    Discussion
    ----------
    
    JsonResponseTest
    
    Hi,
    
    This patch adds some tests for JsonResponse.
    
    Best regards,
    Michal
    
    ---------------------------------------------------------------------------
    
    by eventhorizonpl at 2012-09-01T07:09:12Z
    
    Done. Thanks for the review!
  3. @fabpot

    merged branch eventhorizonpl/100_ptc_symfony_component_class_loader_p…

    fabpot authored
    …3 (PR #5412)
    
    Commits
    -------
    
    8a3c8c9 load test
    
    Discussion
    ----------
    
    load test
    
    Hi,
    
    This patch add test that covers this situation
    
    public static function load($classes, $cacheDir, $name, $autoReload, $adaptive = false, $extension = '.php')
    {
      // each $name can only be loaded once per PHP process
      if (isset(self::$loaded[$name])) {
         return;
    }
    
    Best regards,
    Michal
  4. @fabpot

    merged branch eventhorizonpl/100ptc_component_httpfundation_p2 (PR #5413

    fabpot authored
    )
    
    Commits
    -------
    
    0af8778 Response tests
    
    Discussion
    ----------
    
    Response tests
    
    Hi,
    
    This patch adds some tests to ResponseTest.
    
    Best regards,
    Michal
    
    ---------------------------------------------------------------------------
    
    by eventhorizonpl at 2012-09-01T09:45:16Z
    
    Fixed, thanks for the review.
    
    ---------------------------------------------------------------------------
    
    by eventhorizonpl at 2012-09-02T19:39:26Z
    
    CS fixed. Thanks for the review :)
  5. @fabpot

    merged branch eventhorizonpl/100ptc_component_httpfundation_p3 (PR #5414

    fabpot authored
    )
    
    Commits
    -------
    
    c74d9a9 ResponseHeaderBag tests
    
    Discussion
    ----------
    
    ResponseHeaderBag tests
    
    Hi,
    
    This patch adds some ResponseHeaderBag tests. Now ResponseHeaderBag got 100% test coverage :)
    
    Best regards,
    Michal
  6. @fabpot

    merged branch eventhorizonpl/100ptc_component_httpfundation_p4 (PR #5415

    fabpot authored
    )
    
    Commits
    -------
    
    b89d4ee StreamedResponseTest
    
    Discussion
    ----------
    
    StreamedResponseTest
    
    Hi,
    
    This patch adds one test to StreamedResponseTest and fixes another. StreamedResponse has 100% test coverage.
    
    Best regards,
    Michal
  7. @fabpot

    merged branch eventhorizonpl/100ptc_component_httpfundation_p5 (PR #5416

    fabpot authored
    )
    
    Commits
    -------
    
    21a5841 RedirectResponse tests
    
    Discussion
    ----------
    
    RedirectResponse tests
    
    Hi,
    
    This patch adds 100% test coverage for RedirectResponse class.
    
    Best regards,
    Michal
  8. @fabpot

    merged branch armetiz/patch-2 (PR #5429)

    fabpot authored
    Commits
    -------
    
    6d49bfb Remove "you" word.
    
    Discussion
    ----------
    
    Remove "you" word.
  9. @armetiz

    Remove "you" word.

    armetiz authored
Commits on Sep 2, 2012
  1. @eventhorizonpl

    Response tests

    eventhorizonpl authored
    fix things pointed out by Koc
    
    fix things pointed out by stof
Commits on Sep 1, 2012
  1. @eventhorizonpl

    RedirectResponse tests

    eventhorizonpl authored
  2. @eventhorizonpl

    StreamedResponseTest

    eventhorizonpl authored
  3. @eventhorizonpl
  4. @eventhorizonpl

    load test

    eventhorizonpl authored
  5. @eventhorizonpl

    JsonResponseTest

    eventhorizonpl authored
  6. @sebastianbergmann @fabpot
  7. @fabpot

    merged branch bschussek/issue4670 (PR #5406)

    fabpot authored
    Commits
    -------
    
    04fd5f1 [Form] Fixed PropertyPath to not modify Collection instances (not even their clones)
    
    Discussion
    ----------
    
    [Form] Fixed PropertyPath to not modify Collection instances
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #4670
    Todo: -
    
    ---------------------------------------------------------------------------
    
    by pocallaghan at 2012-08-31T14:20:52Z
    
    As far as I can see the pull request does fix the issue, which makes sense based on the code change (I didn't know iterator_to_array existed, good call). One thing I would say, I'm not sure on the use in the change to the test case. It's not clear to me what additional protection this extra assertion gives, as both the old and new code seem to pass.
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-31T14:21:46Z
    
    The new assertion is there because not even the old code (`clone`) was tested.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-31T14:37:38Z
    
    @bschussek but was it failing without the code change ?
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-31T22:12:00Z
    
    @stof It was not, but I was unable to write a good test for the change within reasonable time. I added an explanatory comment instead.
Commits on Aug 31, 2012
  1. @fabpot

    [Security] fixed typo in a test

    fabpot authored
  2. @webmozart
  3. @fabpot

    merged branch stof/fix_testsuite (PR #5403)

    fabpot authored
    Commits
    -------
    
    7ef6295 Removed the unnecessary file include
    
    Discussion
    ----------
    
    Removed the unnecessary file include
    
    As of Doctrine 2.2, the ORM annotations can be found by the autoloader directly.
    
    This will also avoid breaking the testsuite in case the dev deps have not been installed as the ORM would not be available in this case (the tests relying on the ORM should already be skipped when it is not available). See #5402
  4. @stof

    Removed the unnecessary file include

    stof authored
    As of Doctrine 2.2, the ORM annotations can be found by the autoloader
    directly.
  5. @fabpot

    merged branch Tobion/uselessparamdefaults (PR #5400)

    fabpot authored
    Commits
    -------
    
    cb7e3f5 [Routing] added route compile check to identify a default value of a required variable that does not match the requirement
    
    Discussion
    ----------
    
    [Routing] added route compile check to identify a bad default value
    
    BC break: yes but only for strange route definitions
    
    See the exception message in code for the reasoning.
    
    An exception is thrown for a __required__ variable that __has a default__ that __doesn't match__ the requirement.
    So optional variables can of course still have a default that don't meet the requirement, which is useful.
    This helps to identify useless route definitions at compile time instead of when generating or matching a URL.
  6. @fabpot

    merged branch janmarek/patch-1 (PR #5202)

    fabpot authored
    Commits
    -------
    
    890aea2 FileLocatorInterface used in typehint instead of FileLocator
    
    Discussion
    ----------
    
    FileLocatorInterface used in typehint instead of FileLocator
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-30T22:09:39Z
    
    @fabpot this makes sense (and it is BC)
    
    ---------------------------------------------------------------------------
    
    by mvrhov at 2012-08-31T08:34:17Z
    
    What's wrong with Interface hint? I always hint interface when available as this means that I can inject whatever class implementing that interface.
  7. @Tobion

    [Routing] added route compile check to identify a default value of a …

    Tobion authored
    …required variable that does not match the requirement
Commits on Aug 30, 2012
  1. @fabpot

    merged branch Tobion/requirementscheck (PR #5187)

    fabpot authored
    Commits
    -------
    
    3363832 extended phpdoc of ConfigurableRequirementsInterface
    5f64503 [Routing] added test for disabled requirements check
    4225869 [Routing] allow disabling the requirements check on URL generation
    
    Discussion
    ----------
    
    [Routing] allow disabling the requirements check on URL generation
    
    This adds the possibility to disable the requirements check (`strict_requirements = null`) on URL generation.
    
    To sum up, here the possibilities:
    - `strict_requirements = true`: throw exception for mismatching requirements (most useful in development environment).
    - `strict_requirements = false`: don't throw exception but return null as URL for mismatching requirements and log it (useful when you cannot control all params because they come from third party libs or something but don't want to have a 404 in production environment. it logs the mismatch so you can review it).
    - `strict_requirements = null`: Return the URL with the given parameters without checking the requirements at all. When generating an URL you should either trust your params or you validated them beforehand because otherwise it would break your link anyway (just as with strict_requirements=false). So in production environment you should know that params allways pass the requirements. Thus you could disable the check on each URL generation for performance reasons. If you have 300 links on a page and each URL at least one param you safe 300 unneeded `preg_match` calls. I tested the performance in one of my projects. The rendering time of a single template that contains ~300 links with several params was reduced from avg. 46ms to avg. 42ms. That are 8.7% reduction in the twig layer where the links are created on each request. So this option combines the improved usability of strict_requirements=false with an additional increased performance.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-30T13:40:38Z
    
    Can you put the comment about all the possibilities you have mentioned here in the phpdoc for future reference? Thanks.
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-30T13:49:25Z
    
    In `ConfigurableRequirementsInterface` or which phpdoc would you like to have it? Because `ConfigurableRequirementsInterface` already has it explained. But I can extend its description if thats what you mean.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-30T13:50:40Z
    
    The comment in the PR is more explicit and more detailed than the one in the interface. So, yes, basically, it would be great if you can move all the information in the interface phpdoc.
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-30T14:35:59Z
    
    Done.
  2. @Tobion
  3. @Tobion
  4. @Tobion
  5. @fabpot

    merged branch romainneutron/ProcessExitCode (PR #5386)

    fabpot authored
    Commits
    -------
    
    407db65 Add @Seldaek remote modifications
    3bfb976 Add unit test demonstrating bad exit code getter for a failing process
    
    Discussion
    ----------
    
    Add unit test demonstrating bad exit code getter for a failing process
    
    Since symfony/symfony@7b63428 exit code are not well handled anymore.
    
    The unit test provided with this PR demonstrates it
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-30T11:05:05Z
    
    ping @Seldaek
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-30T11:13:13Z
    
    We probably need to enable the workaround only when sigchild is used.
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2012-08-30T12:51:22Z
    
    Ok I figured out the problem, the hack is even hackier I guess now, but it should work for people with and without --enable-sigchild at least.
  6. @romainneutron
Something went wrong with that request. Please try again.