Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Sep 6, 2012
  1. @fabpot

    updated VERSION for 2.1.0

    fabpot authored
Commits on Sep 5, 2012
  1. @fabpot

    Revert "merged branch Tobion/strictrequirements (PR #5181)"

    fabpot authored
    This reverts commit 2da2a44, reversing
    changes made to 5885547.
  2. @fabpot

    Revert "merged branch Tobion/requirementscheck (PR #5187)"

    fabpot authored
    This reverts commit 2cf50b7, reversing
    changes made to 569e29d.
  3. @fabpot

    Revert "merged branch Tobion/uselessparamdefaults (PR #5400)"

    fabpot authored
    This reverts commit 0f61b2e, reversing
    changes made to 5e7723f.
Commits on Sep 4, 2012
  1. @fabpot

    merged branch beberlei/RevertDbalAcl (PR #5253)

    fabpot authored
    Commits
    -------
    
    1b5ad17 Revert "Removed MySQL-exclusive usage of unsigned integer from table creation"
    
    Discussion
    ----------
    
    [Security][DBAL] Revert MySQL unsigned removal
    
    Revert "Removed MySQL-exclusive usage of unsigned integer from table creation"
    
    This reverts commit 57694aa.
    
    The problem is underlying in Doctrine DBAL change tracking and should
    either be fixed or ignored there.
    
    I opened a ticket on Doctrine Jira http://doctrine-project.org/jira/browse/DBAL-322
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-14T06:40:47Z
    
    I will merge this PR after we have a release of DBAL that includes the fix for DBAL-322.
    
    ---------------------------------------------------------------------------
    
    by acasademont at 2012-08-20T08:01:48Z
    
    This was already fixed 2 weeks ago in doctrine/dbal#183 so i guess this can be closed
    
    ---------------------------------------------------------------------------
    
    by acasademont at 2012-08-20T08:02:06Z
    
    merged i mean
  2. @fabpot

    merged branch eventhorizonpl/100ptc_component_httpfundation (PR #5409)

    fabpot authored
    Commits
    -------
    
    3036b00 JsonResponseTest
    
    Discussion
    ----------
    
    JsonResponseTest
    
    Hi,
    
    This patch adds some tests for JsonResponse.
    
    Best regards,
    Michal
    
    ---------------------------------------------------------------------------
    
    by eventhorizonpl at 2012-09-01T07:09:12Z
    
    Done. Thanks for the review!
  3. @fabpot

    merged branch eventhorizonpl/100_ptc_symfony_component_class_loader_p…

    fabpot authored
    …3 (PR #5412)
    
    Commits
    -------
    
    8a3c8c9 load test
    
    Discussion
    ----------
    
    load test
    
    Hi,
    
    This patch add test that covers this situation
    
    public static function load($classes, $cacheDir, $name, $autoReload, $adaptive = false, $extension = '.php')
    {
      // each $name can only be loaded once per PHP process
      if (isset(self::$loaded[$name])) {
         return;
    }
    
    Best regards,
    Michal
  4. @fabpot

    merged branch eventhorizonpl/100ptc_component_httpfundation_p2 (PR #5413

    fabpot authored
    )
    
    Commits
    -------
    
    0af8778 Response tests
    
    Discussion
    ----------
    
    Response tests
    
    Hi,
    
    This patch adds some tests to ResponseTest.
    
    Best regards,
    Michal
    
    ---------------------------------------------------------------------------
    
    by eventhorizonpl at 2012-09-01T09:45:16Z
    
    Fixed, thanks for the review.
    
    ---------------------------------------------------------------------------
    
    by eventhorizonpl at 2012-09-02T19:39:26Z
    
    CS fixed. Thanks for the review :)
  5. @fabpot

    merged branch eventhorizonpl/100ptc_component_httpfundation_p3 (PR #5414

    fabpot authored
    )
    
    Commits
    -------
    
    c74d9a9 ResponseHeaderBag tests
    
    Discussion
    ----------
    
    ResponseHeaderBag tests
    
    Hi,
    
    This patch adds some ResponseHeaderBag tests. Now ResponseHeaderBag got 100% test coverage :)
    
    Best regards,
    Michal
  6. @fabpot

    merged branch eventhorizonpl/100ptc_component_httpfundation_p4 (PR #5415

    fabpot authored
    )
    
    Commits
    -------
    
    b89d4ee StreamedResponseTest
    
    Discussion
    ----------
    
    StreamedResponseTest
    
    Hi,
    
    This patch adds one test to StreamedResponseTest and fixes another. StreamedResponse has 100% test coverage.
    
    Best regards,
    Michal
  7. @fabpot

    merged branch eventhorizonpl/100ptc_component_httpfundation_p5 (PR #5416

    fabpot authored
    )
    
    Commits
    -------
    
    21a5841 RedirectResponse tests
    
    Discussion
    ----------
    
    RedirectResponse tests
    
    Hi,
    
    This patch adds 100% test coverage for RedirectResponse class.
    
    Best regards,
    Michal
Commits on Sep 2, 2012
  1. @eventhorizonpl

    Response tests

    eventhorizonpl authored
    fix things pointed out by Koc
    
    fix things pointed out by stof
Commits on Sep 1, 2012
  1. @eventhorizonpl

    RedirectResponse tests

    eventhorizonpl authored
  2. @eventhorizonpl

    StreamedResponseTest

    eventhorizonpl authored
  3. @eventhorizonpl
  4. @eventhorizonpl

    load test

    eventhorizonpl authored
  5. @eventhorizonpl

    JsonResponseTest

    eventhorizonpl authored
  6. @fabpot

    merged branch bschussek/issue4670 (PR #5406)

    fabpot authored
    Commits
    -------
    
    04fd5f1 [Form] Fixed PropertyPath to not modify Collection instances (not even their clones)
    
    Discussion
    ----------
    
    [Form] Fixed PropertyPath to not modify Collection instances
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #4670
    Todo: -
    
    ---------------------------------------------------------------------------
    
    by pocallaghan at 2012-08-31T14:20:52Z
    
    As far as I can see the pull request does fix the issue, which makes sense based on the code change (I didn't know iterator_to_array existed, good call). One thing I would say, I'm not sure on the use in the change to the test case. It's not clear to me what additional protection this extra assertion gives, as both the old and new code seem to pass.
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-31T14:21:46Z
    
    The new assertion is there because not even the old code (`clone`) was tested.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-31T14:37:38Z
    
    @bschussek but was it failing without the code change ?
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-31T22:12:00Z
    
    @stof It was not, but I was unable to write a good test for the change within reasonable time. I added an explanatory comment instead.
Commits on Aug 31, 2012
  1. @fabpot

    [Security] fixed typo in a test

    fabpot authored
  2. @webmozart
  3. @fabpot

    merged branch Tobion/uselessparamdefaults (PR #5400)

    fabpot authored
    Commits
    -------
    
    cb7e3f5 [Routing] added route compile check to identify a default value of a required variable that does not match the requirement
    
    Discussion
    ----------
    
    [Routing] added route compile check to identify a bad default value
    
    BC break: yes but only for strange route definitions
    
    See the exception message in code for the reasoning.
    
    An exception is thrown for a __required__ variable that __has a default__ that __doesn't match__ the requirement.
    So optional variables can of course still have a default that don't meet the requirement, which is useful.
    This helps to identify useless route definitions at compile time instead of when generating or matching a URL.
  4. @fabpot

    merged branch janmarek/patch-1 (PR #5202)

    fabpot authored
    Commits
    -------
    
    890aea2 FileLocatorInterface used in typehint instead of FileLocator
    
    Discussion
    ----------
    
    FileLocatorInterface used in typehint instead of FileLocator
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-08-30T22:09:39Z
    
    @fabpot this makes sense (and it is BC)
    
    ---------------------------------------------------------------------------
    
    by mvrhov at 2012-08-31T08:34:17Z
    
    What's wrong with Interface hint? I always hint interface when available as this means that I can inject whatever class implementing that interface.
  5. @Tobion

    [Routing] added route compile check to identify a default value of a …

    Tobion authored
    …required variable that does not match the requirement
Commits on Aug 30, 2012
  1. @Tobion
  2. @Tobion
  3. @Tobion
  4. @romainneutron
  5. @romainneutron
  6. @fabpot

    merged branch rdohms/html5-regexp (PR #5382)

    fabpot authored
    Commits
    -------
    
    7503ec9 Issue #5307: HTML regexp when match is false
    
    Discussion
    ----------
    
    Issue #5307: HTML regexp when match is false
    
    When match is false the html5 validation regexp should be either inverted or not added.
    Since we are in RC added a fix where this is not added, but marked a @todo so that this
    can be revisited and we try to inverse the regexp instead.
    
    Discussed in #5307.
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-30T08:40:06Z
    
    :+1: once the CS issue is fixed.
    
    ---------------------------------------------------------------------------
    
    by rdohms at 2012-08-30T09:23:57Z
    
    Could swear that was the CS in PSR-1 or 2, anyway, fixed.
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-08-30T09:26:07Z
    
    Can you squash your commits before I merge? Thanks.
    
    ---------------------------------------------------------------------------
    
    by rdohms at 2012-08-30T09:54:26Z
    
    @fabpot done.
  7. @rdohms

    Issue #5307: HTML regexp when match is false

    rdohms authored
    When match is false the html5 validation regexp should be either inverted or not added.
    Since we are in RC added a fix where this is not added, but marked a @todo so that this
    can be revisited and we try to inverse the regexp instead.
  8. @fabpot

    merged branch mpiecko/master (PR #5280)

    fabpot authored
    Commits
    -------
    
    58ebd1b [Form] Fixed error bubbling from DateTime widget - Issue #5270
    8ea1607 Update src/Symfony/Component/Form/Extension/Core/Type/DateTimeType.php
    
    Discussion
    ----------
    
    [Form] Fixed error bubbling from DateTime widget - Issue #5270
    
    This is related to #5270
    
    ---------------------------------------------------------------------------
    
    by mpiecko at 2012-08-16T19:37:45Z
    
    Travisbot shows something like this in it's log:
    
        [Composer\Downloader\TransportException] The "http://nodeload.github.com/phingofficial/phing/zipball/2.4.12" file could not be downloaded (HTTP/1.1 500 Internal Server Error)
    
    So is it my PR ot Travis CI who fails ... ? I saw this error in some other PR's ...
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2012-08-16T20:40:39Z
    
    It's GitHub =)
    
    ---------------------------------------------------------------------------
    
    by mpiecko at 2012-08-17T09:36:31Z
    
    Bad GitHub :)
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-17T11:21:39Z
    
    Could you please add a test to DateTimeTypeTest?
    
    ---------------------------------------------------------------------------
    
    by mpiecko at 2012-08-17T12:23:40Z
    
    Sure!
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-08-30T08:20:08Z
    
    :+1:
  9. @fabpot

    fixed typo

    fabpot authored
  10. @fabpot

    merged branch Tobion/strictrequirements (PR #5181)

    fabpot authored
    Commits
    -------
    
    0706d18 [Routing] fixed 4 bugs in the UrlGenerator
    
    Discussion
    ----------
    
    [Routing] UrlGenerator: fixed missing query param and some ignored requirements
    
    This was pretty hard to figure out. I could fix 4 bugs and refactor the code to safe 2 variables and several assignments. Sorry for doing this in one commit, but they were highly interdependent.
    See the added tests for what was fixed. The most obvious bug was that a query param was ignored if it had by accident the same name as a default param (but wasn't used in the path).
    In 3 cases it generated the wrong URL that wouldn't match this route. The generator wrongly ignored either the requirements or the passed parameter. I had to adjust one test that was asserting something wrong (see comments).
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-13T14:22:35Z
    
    ping @fabpot
    
    ---------------------------------------------------------------------------
    
    by Tobion at 2012-08-29T17:53:07Z
    
    @fabpot I think it's important to merge this before 2.1 final.
  11. @fabpot
  12. @fabpot

    merged branch Baachi/test-refactoring (PR #5379)

    fabpot authored
    Commits
    -------
    
    f2d8a8a Refactor the unit test for the "MongoDbSessionHandler"
    
    Discussion
    ----------
    
    [HttpFoundation] Refactor the unit test for the "MongoDbSessionHandler"
    
    Bug fix: no
    Feature addition: yes
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
    Todo: -
    License of the code: MIT
    Documentation PR: -
    
    ---------------------------------------------------------------------------
    
    by drak at 2012-08-29T19:49:49Z
    
    Big +1 from me. Exactly how these kind of tests should be written.
Something went wrong with that request. Please try again.