Commits on Sep 20, 2012
  1. @fabpot

    updated VERSION for 2.1.2

    fabpot committed Sep 20, 2012
  2. @fabpot

    updated CHANGELOG for 2.1.2

    fabpot committed Sep 20, 2012
Commits on Sep 19, 2012
  1. @fabpot
  2. @fabpot

    merged branch romainneutron/FixProcessStop (PR #5543)

    Commits
    -------
    
    7bafc69 Add a Sigchild compatibility mode (set to false by default)
    
    Discussion
    ----------
    
    [2.1][Process] Fix stop in non-sigchild environments
    
    Bug fix: yes
    Feature addition: yes
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    License of the code: MIT
    
    Fix #5030 in half way.
    
     - `proc_terminate` now sends the `SIGTERM` to the real process, not the sh (add the exec prefix to remove the wrapper as suggested by @schmittjoh). So now, process will stop, except if you're working with a PHP compiled with `--enable-sigchild`
     - Add a Sigchild compatibility mode (activated only if PHP has been compiled with it)
    
    This mode is required to use a hack to determine if the process finished with success when PHP has been compiled with the --enable-sigchild option
    
    #5030 will be totally fixed in 2.2 with #5476 as it would allow to send a `SIGKILL` after timeout
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-09-18T21:19:50Z
    
    This will also fix the error reported in Behat/MinkZombieDriver#10
    The stop method was broken because of the sigchild workaround introduced in the latest 2.1-RC times
    fabpot committed Sep 19, 2012
Commits on Sep 18, 2012
  1. @romainneutron

    Add a Sigchild compatibility mode (set to false by default)

    This mode is required to use a hack to determine if the process finished with success when PHP has been compiled with the --enable-sigchild option
    romainneutron committed Sep 9, 2012
  2. @fabpot

    merged branch havvg/2.1 (PR #5540)

    Commits
    -------
    
    8dd19d8 fix Fatal error: Cannot access private property
    
    Discussion
    ----------
    
    fix Fatal error: Cannot access private property
    
    The testsuite fails with fatal error with message:
    
    ```plain
    PHP Fatal error: Cannot access private property Symfony\Component\HttpFoundation\Tests\Session\Storage\Handler\MongoDbSessionHandlerTest::$options
    in src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MongoDbSessionHandlerTest.php on line 85
    ```
    
    on this system:
    
    ```plain
    PHP 5.3.13 with Suhosin-Patch (cli) (built: Jun 20 2012 17:05:20)
    Copyright (c) 1997-2012 The PHP Group
    Zend Engine v2.3.0, Copyright (c) 1998-2012 Zend Technologies
        with Xdebug v2.1.3, Copyright (c) 2002-2012, by Derick Rethans
    ```
    
    ```plain
    PHPUnit 3.6.11 by Sebastian Bergmann
    ```
    fabpot committed Sep 18, 2012
  3. @havvg

    fix Fatal error: Cannot access private property

    PHP Fatal error: Cannot access private property Symfony\Component\HttpFoundation\Tests\Session\Storage\Handler\MongoDbSessionHandlerTest::$options
    in src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MongoDbSessionHandlerTest.php on line 85
    havvg committed Sep 18, 2012
Commits on Sep 17, 2012
  1. @fabpot

    merged 2.0

    fabpot committed Sep 17, 2012
  2. @fabpot

    merged branch jmikola/2.0-contributing-file (PR #5533)

    Commits
    -------
    
    71d8148 Create CONTRIBUTING.md file for auto-linking in PR's
    
    Discussion
    ----------
    
    Create CONTRIBUTING.md file for auto-linking in PR's
    
    See: https://github.com/blog/1184-contributing-guidelines
    
    ---------------------------------------------------------------------------
    
    by kbond at 2012-09-17T17:35:26Z
    
    @jmikola won the race
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-09-17T17:37:35Z
    
    and this should be updated according to the discussion on the dev mailing-list
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-09-17T17:42:28Z
    
    Instead of duplicating the information, I would just linked to the documentation.
    
    ---------------------------------------------------------------------------
    
    by jmikola at 2012-09-17T18:42:29Z
    
    I reduced the file to the "Contributing" block from the readme.
    
    ---------------------------------------------------------------------------
    
    by lsmith77 at 2012-09-17T19:36:36Z
    
    +1
    fabpot committed Sep 17, 2012
  3. @jmikola
  4. @fabpot

    merged branch RoumenMe/translation-2.1 (PR #5534)

    Commits
    -------
    
    3269014 Added Bulgarian translation
    
    Discussion
    ----------
    
    Added Bulgarian translation
    
    Bulgarian translation of validator messages
    fabpot committed Sep 17, 2012
  5. @RoumenDamianoff

    Added Bulgarian translation

    Bulgarian translation of validator messages
    RoumenDamianoff committed Sep 17, 2012
  6. @fabpot

    merged branch AndreyChernykh/2.1 (PR #5524)

    Commits
    -------
    
    580d5a7 Typo fix
    
    Discussion
    ----------
    
    Typo fix
    
    Typo fix in "Range" validator constraints.
    fabpot committed Sep 17, 2012
  7. @fabpot

    merged branch armetiz/patch-7 (PR #5530)

    Commits
    -------
    
    de6658b [Profiler]Use the abstract method to get client IP
    
    Discussion
    ----------
    
    [Profiler]Use the abstract method to get client IP
    
    ---------------------------------------------------------------------------
    
    by armetiz at 2012-09-17T13:37:19Z
    
    This PR is also done for master branch : #5527
    fabpot committed Sep 17, 2012
  8. @armetiz
  9. @AndreyChernykh

    Typo fix

    AndreyChernykh committed Sep 17, 2012
  10. @fabpot

    merged branch richardmiller/fixing_twig_lint_description (PR #5523)

    Commits
    -------
    
    2bcb6f2 Fixing incorrect word in twig:lint command description
    
    Discussion
    ----------
    
    [TwigBundle} Fixing incorrect word in twig:lint command description
    fabpot committed Sep 17, 2012
Commits on Sep 16, 2012
  1. @richardmiller
  2. @fabpot

    merged branch aderuwe/patch-1 (PR #5505)

    Commits
    -------
    
    c2f8563 Rename $key parameter to $name for consistency
    
    Discussion
    ----------
    
    [DependencyInjection] Rename $key parameter to $name for consistency
    
    When I worked on #5478, I noticed an inconsistency in parameter naming in the ```ParameterBag#remove``` method. This PR brings things in line with the rest of the class.
    
    Bug fix: no
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    License of the code: MIT
    fabpot committed Sep 16, 2012
Commits on Sep 13, 2012
  1. @aderuwe
Commits on Sep 11, 2012
  1. @fabpot
  2. @fabpot

    merged branch besnikb/2.0 (PR #5482)

    Commits
    -------
    
    3648abe =Minor chnage: replaced function by method
    
    Discussion
    ----------
    
    =Minor chnage: replaced function by method
    fabpot committed Sep 11, 2012
  3. @fabpot

    updated VERSION for 2.1.1

    fabpot committed Sep 11, 2012
  4. @fabpot

    updated CHANGELOG for 2.1.1

    fabpot committed Sep 11, 2012
  5. @fabpot

    added CHANGELOG for 2.1

    fabpot committed Sep 11, 2012
Commits on Sep 10, 2012
  1. @bes89
  2. @fabpot
  3. @fabpot
  4. @fabpot

    merged branch aderuwe/issue-5477 (PR #5478)

    Commits
    -------
    
    690e28e Convert parameter name to lowercase when removing an element from ParameterBag
    
    Discussion
    ----------
    
    [DependencyInjection] Convert parameter name to lowercase when removing an element from ParameterBag
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: #5477
    License of the code: MIT
    
    ---------------------------------------------------------------------------
    
    by sstok at 2012-09-10T08:42:30Z
    
    👍
    
    ---------------------------------------------------------------------------
    
    by fabpot at 2012-09-10T09:28:16Z
    
    Shouldn't it be done on the 2.0 branch?
    
    ---------------------------------------------------------------------------
    
    by stloyd at 2012-09-10T09:29:35Z
    
    @fabpot AFAIK `2.0` don't have `ParameterBag#remove()` method
    
    ---------------------------------------------------------------------------
    
    by aderuwe at 2012-09-10T09:29:52Z
    
    The remove method is not present in 2.0.
    
    On Mon, Sep 10, 2012 at 11:28 AM, Fabien Potencier <notifications@github.com
    > wrote:
    
    > Shouldn't it be done on the 2.0 branch?
    >
    > —
    > Reply to this email directly or view it on GitHub<#5478 (comment)>.
    >
    >
    fabpot committed Sep 10, 2012
  5. @aderuwe
Commits on Sep 8, 2012
  1. @fabpot

    merged branch stof/fix_phpdoc (PR #5467)

    Commits
    -------
    
    05f7f78 Fixed the phpdoc in the DependencyInjection component
    
    Discussion
    ----------
    
    Fixed the phpdoc in the DependencyInjection component
    
    I was sick of having a warning in my IDE each time I used DefinitionDecorator because of an invalid phpdoc in the constructor, so I took some time and fixed it in the whole DI component.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-09-07T23:09:04Z
    
    The travis failure is unrelated. It is all about some intl failures.
    
    ---------------------------------------------------------------------------
    
    by eventhorizonpl at 2012-09-07T23:37:04Z
    
    Reviewed-by: Michal Piotrowski <michal@eventhorizon.pl>
    
    ---------------------------------------------------------------------------
    
    by pborreli at 2012-09-08T01:42:26Z
    
    👍
    fabpot committed Sep 8, 2012
Commits on Sep 7, 2012
  1. @stof
Commits on Sep 6, 2012
  1. @fabpot
  2. @fabpot

    updated VERSION for 2.1.0

    fabpot committed Sep 6, 2012
  3. @fabpot

    Merge branch '2.0'

    * 2.0:
      bumped Symfony version to 2.0.18-DEV
    
    Conflicts:
    	src/Symfony/Component/HttpKernel/Kernel.php
    fabpot committed Sep 6, 2012