Permalink
Commits on Mar 26, 2013
  1. updated VERSION for 2.1.9

    fabpot committed Mar 26, 2013
  2. update CONTRIBUTORS for 2.1.9

    fabpot committed Mar 26, 2013
  3. updated CHANGELOG for 2.1.9

    fabpot committed Mar 26, 2013
Commits on Mar 24, 2013
  1. merged branch franmomu/reuse_variable_formpass (PR #7464)

    This PR was merged into the 2.1 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Reuse definition variable in FormPass
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    f52320d [FrameworkBundle] Reuse definition variable in FormPass
    fabpot committed Mar 24, 2013
Commits on Mar 23, 2013
  1. merged branch DHorchler/2.1 (PR #7193)

    This PR was merged into the 2.1 branch.
    
    Discussion
    ----------
    
    Routing issue with installation in a sub-directory
    
    ref: #7129
    
    Commits
    -------
    
    8d9cd42 Routing issue with installation in a sub-directory ref: #7129
    fabpot committed Mar 23, 2013
  2. merged branch lizjulien/7106 (PR #7248)

    This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #7248).
    
    Discussion
    ----------
    
    #7106 - check php version for getcwd()
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #7106
    | License       | MIT
    
    Commits
    -------
    
    11d3855  #7106 - fix for ZTS builds
    fabpot committed Mar 23, 2013
  3. #7106 - fix for ZTS builds

    lizjulien committed with fabpot Mar 2, 2013
  4. merged branch tPl0ch/feature/yaml-parameter-escape (PR #7357)

    This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #7357).
    
    Discussion
    ----------
    
    [DependencyInjection] Added @@ escaping strategy for YamlFileLoader and YamlDumper
    
    Added the possibility to to use ```@@``` as an escaping strategy for
    parameters that should be treated as strings but start with ```@```
    (i.e. safe mailer passwords).
    
    This PR is deprecating #7307, since as a new feature it has to be compared against the master branch.
    
    | Q | A |
    | ------ | ------ |
    |  Bug fix?  |  yes  |
    |  New feature?  |  yes  |
    |  BC breaks?  |  no  |
    |  Deprecations?  |  no  |
    |  Tests pass?  |  yes  |
    |  Fixed tickets  |  #4889  |
    
    Commits
    -------
    
    8cdf387 [DependencyInjection] Added '@@' escaping strategy for YamlFileLoader and YamlDumper
    fabpot committed Mar 23, 2013
  5. Added '@@' escaping strategy for YamlFileLoader and YamlDumper

    Added the possibility to to use '@@' as an escaping strategy for
    parameters that should be treated as strings but start with '@'
    (i.e. safe mailer passwords).
    Thomas Ploch committed with fabpot Mar 8, 2013
  6. merged branch ezzatron/yaml-folded-scalar (PR #7455)

    This PR was merged into the 2.1 branch.
    
    Discussion
    ----------
    
    [Yaml] fixed bugs with folded scalar parsing (2.1 branch)
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    This is a re-do of #7445, which was submitted against 2.0, which is no longer supported. Additionally, the previous PR broke some tests because literal tabs were accidentally changed to spaces, and GitHub's diff engine seemingly ignored the change, although the differences showed up when using git diff directly. This PR leaves the literals untouched, and hence the tests should now pass.
    
    **From the original PR:**
    
    I found some more bugs with the parsing of folded scalars. I'd also made some mistakes in the tests introduced by me in #6785. This PR fixes the incorrect tests, and introduces more related tests.
    
    I had to completely rewrite the `Parser::parseFoldedScalar()` method. I think it came out simpler in the end - less 'special cases'. I've done some basic profiling by running the parser tests on repeat and haven't noticed any difference in parsing performance.
    
    Commits
    -------
    
    bbcdfe2 [Yaml] fixed bugs with folded scalar parsing
    fabpot committed Mar 23, 2013
Commits on Mar 22, 2013
  1. merged branch bamarni/form-default-csrf-provider-session-status (PR #…

    …7449)
    
    This PR was merged into the 2.1 branch.
    
    Discussion
    ----------
    
    [Form] made DefaultCsrfProvider using session_status() when available
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | [on PHP 5.4]
    | Tests pass?   | [yes]
    | License       | MIT
    
    Commits
    -------
    
    5afea04 [Form] made DefaultCsrfProvider using session_status() when available
    fabpot committed Mar 22, 2013
Commits on Mar 21, 2013
Commits on Mar 20, 2013
  1. merged branch eddiejaoude/master (PR #7144)

    This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #7144).
    
    Commits
    -------
    
    448983c [YAML] Added unit tests to Dumper
    
    Discussion
    ----------
    
    [YAML] Added unit tests to Dumper
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | []
    | License       | MIT
    | Doc PR        | no
    
    ---------------------------------------------------------------------------
    
    by stof at 2013-02-21T11:28:55Z
    
    I don't like the fact that you are adding a getter for the only purpose of reaching 100% coverage (which could be achieved differently by checking that the dumper can indeed use 8 spaces when dumping)
    
    ---------------------------------------------------------------------------
    
    by eddiejaoude at 2013-02-21T11:33:03Z
    
    Ok, fair point, I will amend.
    
    ---------------------------------------------------------------------------
    
    by eddiejaoude at 2013-02-21T11:35:14Z
    
    I also thought of using reflection for the private property, as checking 8 space dump is less of a unit test as using multiple methods, thoughts?
    
    ---------------------------------------------------------------------------
    
    by eddiejaoude at 2013-02-21T13:42:30Z
    
    Another way to look at it, is if the property has a 'setter' why should it not have a 'getter' too? i.e. If the developer can 'set' it, why cant they 'get' it too. Just another thought, once the best way to move forward is confirmed, I will update my other tests accordingly & submit them.
    
    ---------------------------------------------------------------------------
    
    by Baachi at 2013-02-21T13:49:25Z
    
    Another solution would be, to extend the `Dumper` class and move the `getIndentation` to this class. This class should be located into the `tests/` folder.
    
    @stof What do you think?
    
    ---------------------------------------------------------------------------
    
    by stof at 2013-02-21T14:21:54Z
    
    @Baachi IMO, the unit test should ensure that we can actually change the indentation of the dumped code (which is what we want to do). We don't bother about being able to get the indentation (we don't even have a method for it currently), we want it to be applied. The Dumper is not a configuration object. It is an object doing some work.
    
    So testing that a new getter returns the value will not ensure that changing the indentation is working.
    
    ---------------------------------------------------------------------------
    
    by Baachi at 2013-02-21T15:07:23Z
    
    @stof Ah yes, I understand you. So my solution is wrong, @eddiejaoude should call `setIndentation` and check the dumped yaml` if the string has the right indentation.
    
    ---------------------------------------------------------------------------
    
    by eddiejaoude at 2013-02-22T07:35:08Z
    
    Ok, thanks for the clarification guys. I will get on the case shortly!
    fabpot committed Mar 20, 2013
  2. Added unit tests to Dumper

    eddiejaoude committed with fabpot Feb 21, 2013
  3. merged branch jfsimon/issue-7378 (PR #7438)

    This PR was merged into the 2.1 branch.
    
    Commits
    -------
    
    c928ddc [HttpFoudantion] fixed Request::getPreferredLanguage()
    839c78a Revert "merged branch jfsimon/issue-6928 (PR #7378)"
    
    Discussion
    ----------
    
    [HttpFoundation] fixed Request::getPreferredLanguage()
    
    Previous PR #7378 was wrong and adding BC break. Resolution for short languages codes is now done in `Request::getPreferredLanguage()` method.
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #7378
    fabpot committed Mar 20, 2013
  4. Update .travis.yml (closes #7355)

    Add extension apc.so to Travis-CI testing
    aitboudad committed with fabpot Mar 12, 2013
  5. Revert "merged branch jfsimon/issue-6928 (PR #7378)"

    This reverts commit 70ec4f6, reversing
    changes made to 3a03f3e.
    jfsimon committed Mar 20, 2013
  6. Merge branch '2.0' into 2.1

    * 2.0:
      updated VERSION for 2.0.23
      update CONTRIBUTORS for 2.0.23
      updated CHANGELOG for 2.0.23
    
    Conflicts:
    	src/Symfony/Component/HttpKernel/Kernel.php
    fabpot committed Mar 20, 2013
  7. merged branch nikrou/relative-path-with-slash (PR #7434)

    This PR was merged into the 2.1 branch.
    
    Commits
    -------
    
    e6b7515 [DomCrawler] added support for query string with slash
    
    Discussion
    ----------
    
    [DomCrawler] added support for query string with slash
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Link\getUri() failed to return correct uri when current query string contains slash
    Test pass on branch 2.1 but fails on master
    fabpot committed Mar 20, 2013
  8. updated VERSION for 2.0.23

    fabpot committed Mar 20, 2013
  9. update CONTRIBUTORS for 2.0.23

    fabpot committed Mar 20, 2013
  10. updated CHANGELOG for 2.0.23

    fabpot committed Mar 20, 2013
  11. [Form] fixed failing test

    fabpot committed Mar 20, 2013
  12. [DomCrawler] added support for query string with slash

    Link\getUri() failed to return correct uri when current query string contains slash
    nikrou committed Mar 20, 2013
Commits on Mar 18, 2013
  1. merged branch bamarni/issue-6830 (PR #7408)

    This PR was merged into the 2.1 branch.
    
    Commits
    -------
    
    54609b9 [HttpCache] added a test (cached content should be kept after purging)
    
    Discussion
    ----------
    
    [HttpCache] added a test (cached content should be kept after purging)
    
    closes #6830
    fabpot committed Mar 18, 2013
  2. merged branch elnur/interface-public-modifier (PR #7397)

    This PR was submitted for the 2.0 branch but it was merged into the 2.1 branch instead (closes #7397).
    
    Commits
    -------
    
    8ee05e5 Add a public modifier to an interface method
    
    Discussion
    ----------
    
    [2.0][Security] Add a public modifier to an interface method
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    fabpot committed Mar 18, 2013
  3. merged branch jfsimon/issue-6928 (PR #7378)

    This PR was squashed before being merged into the 2.1 branch (closes #7378).
    
    Commits
    -------
    
    17dc2ff [HttpRequest] fixes Request::getLanguages() bug
    
    Discussion
    ----------
    
    [HttpRequest] fixes Request::getLanguages() bug
    
    This PR adds to suported languages the first segment of all compouds languages codes.
    When receiving `Accept-Language: en-us` header, accepted languages will now be `en, en_US`.
    
    This should not be a BC break as most browsers already send the long **and** short versions of language codes... but some dont.
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #6928
    fabpot committed Mar 18, 2013
Commits on Mar 17, 2013
Commits on Mar 16, 2013
  1. merged branch jfsimon/issue-7325 (PR #7393)

    This PR was merged into the 2.1 branch.
    
    Commits
    -------
    
    bd38483 [Security] fixed HttpUtils class tests
    
    Discussion
    ----------
    
    [Security] fixed HttpUtils class tests
    
    This fixes tests broken in #7325.
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #7325
    fabpot committed Mar 16, 2013
  2. merged branch saro0h/issue-7297 (PR #7392)

    This PR was squashed before being merged into the 2.1 branch (closes #7392).
    
    Commits
    -------
    
    67fbbac [DoctrineBridge] Fixed non-utf-8 recognition
    
    Discussion
    ----------
    
    [DoctrineBridge] Fixed non-utf-8 recognition
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #7297
    
    ---------------------------------------------------------------------------
    
    by jfsimon at 2013-03-15T15:10:28Z
    
    👍
    
    ---------------------------------------------------------------------------
    
    by francisbesset at 2013-03-15T15:17:17Z
    
    👎
    
    ---------------------------------------------------------------------------
    
    by pborreli at 2013-03-15T15:21:10Z
    
    travis test is failing https://travis-ci.org/symfony/symfony/jobs/5529163#L225
    
    ---------------------------------------------------------------------------
    
    by pborreli at 2013-03-15T15:35:31Z
    
    if there is any regression it could help to write a new failing test first.
    
    ---------------------------------------------------------------------------
    
    by jfsimon at 2013-03-15T15:55:52Z
    
    @pborreli the test was already failing
    
    ---------------------------------------------------------------------------
    
    by pborreli at 2013-03-15T15:58:52Z
    
    @jfsimon ah ok, well it still fails 😃
    
    ---------------------------------------------------------------------------
    
    by francisbesset at 2013-03-15T16:00:39Z
    
    @jfsimon if this is true I gives: 👍
    
    ---------------------------------------------------------------------------
    
    by jfsimon at 2013-03-15T16:14:47Z
    
    @saro0h \o/
    
    ---------------------------------------------------------------------------
    
    by pborreli at 2013-03-15T16:16:54Z
    
    👍
    fabpot committed Mar 16, 2013