Skip to content
Permalink
Branch: master
Commits on Apr 24, 2019
  1. feature #30370 [Cache] Add optimized FileSystem & Redis TagAware Adap…

    fabpot committed Apr 24, 2019
    …ters (andrerom)
    
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [Cache] Add optimized FileSystem & Redis TagAware Adapters
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes _TODO: src/**/CHANGELOG.md_
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #28250
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... TODO
    
    Reduces cache lookups by 50% when using TagAware, by changing logic of how tag information is stored to avoid having to look it up on getItem(s) calls.
    
    For Filesystem symlinks are used, for Redis "Set" datatype is used.
    
    Commits
    -------
    
    3278cb1 [Cache] Add optimized FileSystem & Redis TagAware Adapters
Commits on Apr 22, 2019
  1. fixed constraint

    fabpot committed Apr 22, 2019
  2. bug #31023 [Routing] Fix route URL generation in CLI context (X-Coder…

    fabpot committed Apr 22, 2019
    …264)
    
    This PR was squashed before being merged into the 4.2 branch (closes #31023).
    
    Discussion
    ----------
    
    [Routing] Fix route URL generation in CLI context
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #30996
    | License       | MIT
    | Doc PR        | -
    
    This fixes #30996 and makes URL generation in the CLI context behave the same as it does in the web context where the `LocaleListener` sets the default locale (to the router context).
    
    The Travis CI failure is related to the fact that the constraint for `symfony/routing` should be bumped to `^4.2.6` in the composer.json of the FrameworkBundle (when it gets tagged).
    
    Commits
    -------
    
    4a1ad4a [Routing] Fix route URL generation in CLI context
  3. bug #31085 [DoctrineBridge] Unique mapping setting is optional (ksave…

    fabpot committed Apr 22, 2019
    …ras)
    
    This PR was squashed before being merged into the 4.3-dev branch (closes #31085).
    
    Discussion
    ----------
    
    [DoctrineBridge] Unique mapping setting is optional
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    ```sh
    Executed script cache:clear  [KO]
     [KO]
    Script cache:clear returned with error code 1
    !!
    !!   // Clearing the cache for the dev environment with debug
    !!   // true
    !!
    !!
    In DoctrineLoader.php line 71:
    
      [ErrorException]
      Notice: Undefined index: unique
    
    Exception trace:
     () at /home/ksaveras/Projects/mokytojas.local/vendor/symfony/doctrine-bridge/Validator/DoctrineLoader.php:71
     Symfony\Bridge\Doctrine\Validator\DoctrineLoader->loadClassMetadata() at /home/ksaveras/Projects/mokytojas.local/vendor/symfony/validator/Mapping/Loader/LoaderChain.php:54
     Symfony\Component\Validator\Mapping\Loader\LoaderChain->loadClassMetadata() at /home/ksaveras/Projects/mokytojas.local/vendor/symfony/validator/Mapping/Factory/LazyLoadingMetadataFactory.php:105
     Symfony\Component\Validator\Mapping\Factory\LazyLoadingMetadataFactory->getMetadataFor() at /home/ksaveras/Projects/mokytojas.local/vendor/symfony/framework-bundle/CacheWarmer/ValidatorCacheWarmer.php:63
     Symfony\Bundle\FrameworkBundle\CacheWarmer\ValidatorCacheWarmer->doWarmUp() at /home/ksaveras/Projects/mokytojas.local/vendor/symfony/framework-bundle/CacheWarmer/AbstractPhpFileCacheWarmer.php:51
     Symfony\Bundle\FrameworkBundle\CacheWarmer\AbstractPhpFileCacheWarmer->warmUp() at /home/ksaveras/Projects/mokytojas.local/vendor/symfony/http-kernel/CacheWarmer/CacheWarmerAggregate.php:96
     Symfony\Component\HttpKernel\CacheWarmer\CacheWarmerAggregate->warmUp() at /home/ksaveras/Projects/mokytojas.local/vendor/symfony/framework-bundle/Command/CacheClearCommand.php:194
     Symfony\Bundle\FrameworkBundle\Command\CacheClearCommand->warmup() at /home/ksaveras/Projects/mokytojas.local/vendor/symfony/framework-bundle/Command/CacheClearCommand.php:129
     Symfony\Bundle\FrameworkBundle\Command\CacheClearCommand->execute() at /home/ksaveras/Projects/mokytojas.local/vendor/symfony/console/Command/Command.php:255
     Symfony\Component\Console\Command\Command->run() at /home/ksaveras/Projects/mokytojas.local/vendor/symfony/console/Application.php:930
     Symfony\Component\Console\Application->doRunCommand() at /home/ksaveras/Projects/mokytojas.local/vendor/symfony/framework-bundle/Console/Application.php:87
     Symfony\Bundle\FrameworkBundle\Console\Application->doRunCommand() at /home/ksaveras/Projects/mokytojas.local/vendor/symfony/console/Application.php:273
     Symfony\Component\Console\Application->doRun() at /home/ksaveras/Projects/mokytojas.local/vendor/symfony/framework-bundle/Console/Application.php:73
     Symfony\Bundle\FrameworkBundle\Console\Application->doRun() at /home/ksaveras/Projects/mokytojas.local/vendor/symfony/console/Application.php:149
     Symfony\Component\Console\Application->run() at /home/ksaveras/Projects/mokytojas.local/bin/console:40
    
    cache:clear [--no-warmup] [--no-optional-warmers] [-h|--help] [-q|--quiet] [-v|vv|vvv|--verbose] [-V|--version] [--ansi] [--no-ansi] [-n|--no-interaction] [-e|--env ENV] [--no-debug] [--] <command>
    
    ./bin/console ca:cl
    ```
    
    Commits
    -------
    
    fde4dc9 [DoctrineBridge] Unique mapping setting is optional
Commits on Apr 21, 2019
  1. feature #28831 [Intl] Add Timezones (ro0NL)

    fabpot committed Apr 21, 2019
    This PR was squashed before being merged into the 4.3-dev branch (closes #28831).
    
    Discussion
    ----------
    
    [Intl] Add Timezones
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | replaces #26851, #17628, #17636
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#11447
    
    This PR compiles a new `TimezoneBundle` from ICU data, based on the following resources:
    
    - https://github.com/unicode-org/icu/tree/master/icu4c/source/data/zone
    - https://github.com/unicode-org/icu/blob/master/icu4c/source/data/misc/timezoneTypes.txt
    - https://github.com/unicode-org/icu/blob/master/icu4c/source/data/misc/metaZones.txt
    
    The goal is to provide a fixed set of timezones, with a localized human readable name.
    
    For inspiration and to double check some data i used the timezone widget from google, e.g. when using Google Calendar.
    
    I've only pushed some common compiled locales for review, the rest will follow once finished.
    
    cc @jakzal
    
    Commits
    -------
    
    4bea198 [Intl] Add Timezones
  2. bug #31117 [FrameworkBundle] fix math depth handler configuration (Ra…

    fabpot committed Apr 21, 2019
    …ulnet)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] fix math depth handler configuration
    
    | Q             | A
    | ------------- | ---
    | Branch?       |  4.2 f
    | Bug fix?      | no "fix deprecated"
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #30998
    | License       | MIT
    | Doc PR        |
    
    fix  serializer configuration max_deep_handler
    
    Commits
    -------
    
    fb9fc80 fix math depth handler
Commits on Apr 18, 2019
  1. feature #31130 [VarDumper] add caster for WeakReference instances of …

    fabpot committed Apr 18, 2019
    …PHP 7.4 (nicolas-grekas)
    
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [VarDumper] add caster for WeakReference instances of PHP 7.4
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    ![image](https://user-images.githubusercontent.com/243674/56214443-2d9d8100-605e-11e9-86bb-157a07b5caa0.png)
    
    Commits
    -------
    
    0cdb808 [VarDumper] add caster for WeakReference instances of PHP 7.4
Commits on Apr 17, 2019
  1. bumped Symfony version to 4.2.8

    fabpot committed Apr 17, 2019
  2. Merge pull request #31148 from fabpot/release-4.2.7

    fabpot committed Apr 17, 2019
    released v4.2.7
  3. updated VERSION for 4.2.7

    fabpot committed Apr 17, 2019
  4. updated CHANGELOG for 4.2.7

    fabpot committed Apr 17, 2019
  5. bumped Symfony version to 3.4.27

    fabpot committed Apr 17, 2019
  6. Merge pull request #31146 from fabpot/release-3.4.26

    fabpot committed Apr 17, 2019
    released v3.4.26
  7. updated VERSION for 3.4.26

    fabpot committed Apr 17, 2019
  8. updated CHANGELOG for 3.4.26

    fabpot committed Apr 17, 2019
Commits on Apr 16, 2019
  1. bumped Symfony version to 4.2.7

    fabpot committed Apr 16, 2019
  2. Merge pull request #31125 from fabpot/release-4.2.6

    fabpot committed Apr 16, 2019
    released v4.2.6
  3. updated VERSION for 4.2.6

    fabpot committed Apr 16, 2019
  4. updated CHANGELOG for 4.2.6

    fabpot committed Apr 16, 2019
  5. bumped Symfony version to 3.4.26

    fabpot committed Apr 16, 2019
  6. Merge pull request #31123 from fabpot/release-3.4.25

    fabpot committed Apr 16, 2019
    released v3.4.25
  7. updated VERSION for 3.4.25

    fabpot committed Apr 16, 2019
  8. update CONTRIBUTORS for 3.4.25

    fabpot committed Apr 16, 2019
  9. updated CHANGELOG for 3.4.25

    fabpot committed Apr 16, 2019
Commits on Apr 15, 2019
  1. feature #31082 [Form] Show all option normalizers on debug:form comma…

    fabpot committed Apr 15, 2019
    …nd (yceruto)
    
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [Form] Show all option normalizers on debug:form command
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    
    Follow-up #30371
    
    ![normalizers](https://user-images.githubusercontent.com/2028198/55996454-6667df80-5c85-11e9-94f6-9ee3988833f3.png)
    
    Commits
    -------
    
    f1d3bc0 Show all option normalizers on debug:form command
  2. feature #30957 [Messenger] Remove base64_encode & use addslashes (wea…

    fabpot committed Apr 15, 2019
    …verryan)
    
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [Messenger] Remove base64_encode & use addslashes
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | none
    | License       | MIT
    | Doc PR        | already covered by existing issue
    
    In #30814, we base64_encoded messages because some transports (specifically DoctrineTransport + Postgresql & SQS) do not allow binary data.
    
    The downside is that the messages become unreadable, which makes it much less convenient to debug your messages with 3rd party monitoring tools, for example.
    
    This PR replaces base64_encode with addslashes. Another alternative (that I first tried in this PR) was to use a blob type, which Drupal does in its code (https://www.drupal.org/project/drupal/issues/690746). But, it still meant that binary data could cause problems with other transports, like SQS.
    
    I also put all the serializer config under a nice, neat `serializer` key under messenger.
    
    Best seen with `?w=1`.
    
    Cheers!
    
    Commits
    -------
    
    70b448d Reorganizing messenger serializer config and replacing base64_encode with addslashes
  3. bug #31040 [BrowserKit] Fixed BC-break introduced by rename of Client…

    fabpot committed Apr 15, 2019
    … to Browser (Devristo)
    
    This PR was squashed before being merged into the 4.3-dev branch (closes #31040).
    
    Discussion
    ----------
    
    [BrowserKit] Fixed BC-break introduced by rename of Client to Browser
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #31039
    | License       | MIT
    | Doc PR        |
    
    Since #30541 the inheritance hierarchy of `\Symfony\Component\BrowserKit\Client` has changed. Notably the test.client no longer is an instance of `\Symfony\Component\BrowserKit\Client`.
    
    This PR uses `class_alias` to fix the class hierarchy similarly as has been done in Twig. In this case I copied the approach of `Twig_TokenParser_AutoEscape` and `\Twig\TokenParser\AutoEscapeTokenParser`
    
    Commits
    -------
    
    6a94dea [BrowserKit] Fixed BC-break introduced by rename of Client to Browser
  4. feature #28846 [Intl] Simplify API (ro0NL)

    fabpot committed Apr 15, 2019
    This PR was squashed before being merged into the 4.3-dev branch (closes #28846).
    
    Discussion
    ----------
    
    [Intl] Simplify API
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #18368
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#11221
    
    Simplifies the Intl API. It greatly reduces the no. of boilerplate classes in this component. Very over complicated, much wow :)
    
    Solving (IMHO):
    
    ```php
    class LanguageBundle extends LanguageDataProvider implements LanguageBundleInterface
    ```
    
    Which seems very over complicated just to provide static data.
    
    ```php
    // before
    Intl::getLanguageBundle()->getLanguageName() // string | null
    
    // after
    Languages::getName() // string
    Languages::exists() // bool
    ```
    
    I left out Canonicalization on puropose, that's a new topic to me.
    
    - [x] Languages
    - [x] Locales
    - [x] Currencies
    - [x] Regions
    - [x] Scripts
    - [ ] Timezones (#28831)
    - [x] Update constraints
    - [x] Update form types
    
    Thoughts?
    
    Commits
    -------
    
    d6b67d4 [Intl] Simplify API
Commits on Apr 13, 2019
  1. minor #31099 Missing Lithuanian translations added. (rmikalkenas)

    fabpot committed Apr 13, 2019
    This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #31099).
    
    Discussion
    ----------
    
    Missing Lithuanian translations added.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #
    | License       | MIT
    | Doc PR        | symfony/symfony-docs
    
    Missing Lithuanian translations for validator component.
    
    Commits
    -------
    
    1c9a9cd Missing Lithuanian translations added to validator component.
  2. bug #31100 Missing use statement added in UniqueValidator. (rmikalkenas)

    fabpot committed Apr 13, 2019
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    Missing use statement added in UniqueValidator.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | yes
    | Tests pass?   | yes
    | Fixed tickets | #
    | License       | MIT
    | Doc PR        | symfony/symfony-docs
    
    Commits
    -------
    
    9ae73b1 Missing use statement added in UniqueValidator.
Commits on Apr 12, 2019
  1. feature #29211 [PhpUnitBridge] Url encoded deprecations helper config…

    fabpot committed Apr 12, 2019
    … (greg0ire)
    
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [PhpUnitBridge] Url encoded deprecations helper config
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | yes
    | Tests pass?   | yes
    | Fixed tickets | #28048
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#10701
    
    First stab at implementing a new way of configuring the deprecation error handler. Includes a refactoring to keep things manageable.
    
    Rework of #24867, blocked by #29718
    
    TODO:
    
    - [x] make the code 5.5 compatible 😢
    - [x] add more tests
    - [x] deprecate modes (using echo :P)
    - [x] test this on real life projects and add some screenshots
    - [x] docs PR
    - [x] handle `strict`
    - [x] adapt existing CI config
    
    # Quiet configuration
    
    ![quiet](https://user-images.githubusercontent.com/657779/49341318-fa78c900-f64b-11e8-9504-a8a9eac4baf8.png)
    
    # Default configuration
    
    ![verbose](https://user-images.githubusercontent.com/657779/49341322-10868980-f64c-11e8-9d90-dc3f6a18c335.png)
    
    Commits
    -------
    
    1c73f9c [PhpUnitBridge] Url encoded deprecations helper config
  2. bug #30967 [HttpClient] Document the state object that is passed arou…

    fabpot committed Apr 12, 2019
    …nd by the HttpClient (derrabus)
    
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [HttpClient] Document the state object that is passed around by the HttpClient
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | N/A
    | License       | MIT
    | Doc PR        | N/A
    
    In an attempt to make the code of the new HttpClient component more understandable, I've introduced internal classes that document the `$multi` object that is being passed around between *Client and *Response classes.
    
    My goal is to make the code more accessible to potential contributors and static code analyzers.
    
    Commits
    -------
    
    20f4eb3 Document the state object that is passed around by the HttpClient.
  3. bug #30993 [FrameworkBundle] Fix for Controller DEPRECATED when using…

    fabpot committed Apr 12, 2019
    … composer --optimized (aweelex)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Fix for Controller DEPRECATED  when using composer --optimized
    
    | Q | A |
    | --- | --- |
    | Branch? | 4.2 |
    | Bug fix? | Yes |
    | New feature? | No |
    | BC breaks? | No |
    | Deprecations? | No |
    | Tests pass? | Yes |
    | Fixed tickets | --- |
    | License | MIT |
    
    Using `composer --optimize-autoload` causes `console cache:clear` (without warmup) to give DEPRECATED error, that stays in profiler.
    
    I moved `@trigger_error` from beggining of the file to Controller __consctruct method.
    
    Commits
    -------
    
    2ae2fd8 [FrameworkBundle] Fix Controller deprecated when using composer --optimized
Commits on Apr 11, 2019
  1. minor #31063 CS Fixes: Not double split with one array argument (rube…

    fabpot committed Apr 11, 2019
    …nrua)
    
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    CS Fixes: Not double split with one array argument
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | None
    | License       | MIT
    | Doc PR        | None
    
    Keep to use the same CS in all the Symfony code base.
    
    Use:
    ```php
    $resolver->setDefaults([
        'compound' => false
    ]);
    ```
    
    Instead of:
    ```php
    $resolver->setDefaults(
        [
            'compound' => false,
        ]
    );
    ```
    
    Keep the double split when the method has two or more arguments.
    
    I miss a PSR with this rule.
    
    Commits
    -------
    
    027bd12 CS Fixes: Not double split with one array argument
  2. bug #31024 [Mailer] fixed roundrobin test one dead which should recov…

    fabpot committed Apr 11, 2019
    …er (scuben, fabpot)
    
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [Mailer] fixed roundrobin test one dead which should recover
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | WIP    <!-- please add some, will be required by reviewers -->
    | License       | MIT
    | Doc PR        | n/a
    
    The Test `testSendOneDeadButRecover` is not checking the recovery part of its job. I fixed that by adding more `send` calls and added another test so that both recoveries (within retry period and not within retry period) are covered.
    
    The `RoundRobinTransport` had a bug where the transport is dead but not yet in the `retryPeriod`. In that case the transport would not have been added back to the stack and thus got lost. Fixed that but that required an additional check if all transports are dead to prevent an infinite loop.
    
    Commits
    -------
    
    5d4d4e7 fixed roundrobin dead transport which should recover
    ccbb171 fixed roundrobin dead transport which should recover
Older
You can’t perform that action at this time.