Permalink
Commits on Feb 17, 2017
  1. Fix ResolveDefinitionInheritancePass

    nicolas-grekas committed Feb 17, 2017
  2. bug #21639 [DI] Set getter edges as lazy (nicolas-grekas)

    This PR was merged into the 3.3-dev branch.
    
    Discussion
    ----------
    
    [DI] Set getter edges as lazy
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Fixes tests
    
    Commits
    -------
    
    279f6a2 [DI] Set getter edges as lazy
    nicolas-grekas committed Feb 17, 2017
Commits on Feb 16, 2017
  1. [DI] Set getter edges as lazy

    nicolas-grekas committed Feb 16, 2017
Commits on Feb 14, 2017
  1. Merge branch '3.2'

    * 3.2: (27 commits)
      Improve tracking of environment variables in the case of private services
      [DI] Align AutowirePass with 2.8
      property constraints can be added in child classes
      added test for staticClassLoader in LazyLoadingMetadatafactory
      fixed PHPUnit setUp and tearDown method visibility
      spelling fixes
      Readd Symfony version status in the toolbar
      [Security] LdapUserProvider should not throw an exception if the UID key does not exist in an LDAP entry
      make sure that null can be the invalid value
      [VarDumper] Improve dump of AMQP* Object
      Fix annotations cache folder path
      [FrameworkBundle] Wire ArrayCache for annotation reader at bootstrap
      Ignore missing 'debug.file_link_formatter' service in Debug bundle
      [VarDumper] Fixed dumping of terminated generator
      bumped Symfony version to 3.2.4
      updated VERSION for 3.2.3
      updated CHANGELOG for 3.2.3
      bumped Symfony version to 2.8.18
      updated VERSION for 2.8.17
      updated CHANGELOG for 2.8.17
      ...
    nicolas-grekas committed Feb 14, 2017
  2. Merge branch '2.8' into 3.2

    * 2.8:
      property constraints can be added in child classes
      added test for staticClassLoader in LazyLoadingMetadatafactory
      spelling fixes
      Readd Symfony version status in the toolbar
      make sure that null can be the invalid value
      [VarDumper] Improve dump of AMQP* Object
      [VarDumper] Fixed dumping of terminated generator
      bumped Symfony version to 2.8.18
      updated VERSION for 2.8.17
      updated CHANGELOG for 2.8.17
      bumped Symfony version to 2.7.25
      updated VERSION for 2.7.24
      update CONTRIBUTORS for 2.7.24
      updated CHANGELOG for 2.7.24
      [FrameworkBundle] Simplify createPackageDefinition
      fix directory resource considers same timestamp not fresh
      return false early from directory resource
    nicolas-grekas committed Feb 14, 2017
  3. Merge branch '2.7' into 2.8

    * 2.7:
      property constraints can be added in child classes
      added test for staticClassLoader in LazyLoadingMetadatafactory
      spelling fixes
      make sure that null can be the invalid value
      bumped Symfony version to 2.7.25
      updated VERSION for 2.7.24
      update CONTRIBUTORS for 2.7.24
      updated CHANGELOG for 2.7.24
      [FrameworkBundle] Simplify createPackageDefinition
      fix directory resource considers same timestamp not fresh
      return false early from directory resource
    nicolas-grekas committed Feb 14, 2017
  4. minor #21529 [FrameworkBundle] Simplify createPackageDefinition (dung…

    …las)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Simplify createPackageDefinition
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | n/a
    
    Minor simplification.
    
    Commits
    -------
    
    4b81393 [FrameworkBundle] Simplify createPackageDefinition
    nicolas-grekas committed Feb 14, 2017
  5. minor #21605 [DI] Align AutowirePass with 2.8 (nicolas-grekas)

    This PR was merged into the 3.2 branch.
    
    Discussion
    ----------
    
    [DI] Align AutowirePass with 2.8
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.2
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Follow up a less than ideal [merge conflict resolution](#18691 (comment)), found while reviewing AutowirePass in 2.8 and 3.2 and wondering about the delta. Should reduce future merge conflicts and help history tracking.
    
    Commits
    -------
    
    dd5236a [DI] Align AutowirePass with 2.8
    nicolas-grekas committed Feb 14, 2017
  6. bug #21607 Improve tracking of environment variables in the case of p…

    …rivate services (tgalopin)
    
    This PR was merged into the 3.2 branch.
    
    Discussion
    ----------
    
    Improve tracking of environment variables in the case of private services
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #21273
    | License       | MIT
    
    Recently, I stumbled upon an issue with environment variables that I had troubles to understand. Here it is:
    
    I have two environment variables, defined in my `parameters.yml` with a default value of empty:
    
    ``` yaml
    parameters:
        env(MAILJET_PUBLIC_KEY): ''
        env(MAILJET_PRIVATE_KEY): ''
    ```
    
    I use these variables only in a private service:
    
    ``` xml
    <service id="app.mailjet.transport" class="AppBundle\Mailjet\MailjetApiTransport" public="false">
        <argument type="service" id="csa_guzzle.client.mailjet_api"/>
        <argument>%env(MAILJET_PUBLIC_KEY)%</argument>
        <argument>%env(MAILJET_PRIVATE_KEY)%</argument>
    </service>
    ```
    
    This private service is not used by any other service for the moment.
    
    As the service is private and not used by any other service, the `RemoveUnusedDefinitionsPass` removes it from the container. However, when the container dumper dumps the container, it checks if the environment variable was dumped. As the service is now gone, an expection is thrown (`EnvParameterException, Incompatible use of dynamic environment variables "MAILJET_PUBLIC_KEY", "MAILJET_PRIVATE_KEY" found in parameters.`).
    
    Commits
    -------
    
    f380ba3 Improve tracking of environment variables in the case of private services
    nicolas-grekas committed Feb 14, 2017
  7. [DI] Align AutowirePass with 2.8

    nicolas-grekas committed Feb 14, 2017
Commits on Feb 13, 2017
  1. [DI] Deprecate string keys in arguments

    nicolas-grekas committed with dunglas Jan 30, 2017
Commits on Feb 12, 2017
  1. [DI] Add "psr4" service attribute for PSR4-based discovery and regist…

    …ration
    nicolas-grekas committed Jan 14, 2017
Commits on Feb 11, 2017
  1. bug #21584 [WebProfilerBundle] Readd Symfony version status in the to…

    …olbar (wouterj)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [WebProfilerBundle] Readd Symfony version status in the toolbar
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    The Symfony version status (*"This Symfony version will no longer receive security fixes."* and the like) was no longer shown in the toolbar. This was removed in 9d89841 , but the commit description isn't that describing. I guess it's not done on purpose.
    
    I think having this information is crucial for this feature to work: A yellow version doesn't mean anything specific, unless I see "This Symfony will only receive security fixes".
    
    /cc @javiereguiluz
    
    Commits
    -------
    
    d714c7e Readd Symfony version status in the toolbar
    nicolas-grekas committed Feb 11, 2017
  2. minor #21586 spelling fixes (klemens)

    This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #21586).
    
    Discussion
    ----------
    
    spelling fixes
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->
    
    <!--
    - Bug fixes must be submitted against the lowest branch where they apply
      (lowest branches are regularly merged to upper ones so they get the fixes too).
    - Features and deprecations must be submitted against the master branch.
    - Please fill in this template according to the PR you're about to submit.
    - Replace this comment by a description of what your PR is solving.
    -->
    patch contains some spelling fixes ( just in comments ) as found by a bot ( https://github.com/ka7/misspell_fixer ). Any upcoming License changes (e.g. GPL2 to GPL3+) are hereby granted.
    
    Commits
    -------
    
    6ccc479 spelling fixes
    nicolas-grekas committed Feb 11, 2017
  3. bug #21557 [VarDumper] Improve dump of AMQP* Object (lyrixx)

    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [VarDumper] Improve dump of AMQP* Object
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    ---
    
    The release of https://github.com/pdezwart/php-amqp/ 1.7.0alpha1
    changed internally the handling of AMQP* object. So now when dumping
    using var_dump(), many information are available. So many information
    are displayed twice. This commit fixes this issue and keeps displaying basic
    information for older versions of the lib.
    
    Reference:
    
    * https://pecl.php.net/package-info.php?package=amqp&version=1.7.0alpha1
    * pdezwart/php-amqp@314afbc (and next commits)
    
    ---
    
    ![screenshot4](https://cloud.githubusercontent.com/assets/408368/22700884/53ad5f68-ed5c-11e6-986b-bfdf91640060.png)
    
    ![screenshot5](https://cloud.githubusercontent.com/assets/408368/22700890/580353c4-ed5c-11e6-8fc8-c101115b7001.png)
    
    Commits
    -------
    
    c553352 [VarDumper] Improve dump of AMQP* Object
    nicolas-grekas committed Feb 11, 2017
Commits on Feb 10, 2017
  1. feature #21194 [Yaml] Add tags support (GuilhemN)

    This PR was squashed before being merged into the 3.3-dev branch (closes #21194).
    
    Discussion
    ----------
    
    [Yaml] Add tags support
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | yes
    | Tests pass?   | yes
    | Fixed tickets | #21185
    | License       | MIT
    | Doc PR        |
    
    This PR adds custom tags support to the Yaml component.
    Symfony tags (`!!binary`, `!str`, etc.) are still managed in the parser to have a lighter diff but we'll be able to convert them later if we want to.
    
    The primary addition of this PR is the `TagInterface`:
    ```php
    interface TagInterface
    {
        public function construct(mixed $value): mixed;
    }
    ```
    
    It can be used to register custom tags. An example that could be used to convert [the syntax `=iterator`](#20907 (comment)) to a tag:
    ```php
    final class IteratorTag implements TagInterface
    {
        public function construct(mixed $value): mixed
        {
            return new IteratorArgument($value);
        }
    }
    
    $parser = new Parser(['iterator' => new IteratorTag()]);
    ```
    
    If you think this is too complex, @nicolas-grekas [proposed an alternative](#21185 (comment)) to my proposal externalizing this support by introducing a new class `TaggedValue`.
    
    Commits
    -------
    
    4744107 [Yaml] Add tags support
    nicolas-grekas committed Feb 10, 2017
Commits on Feb 9, 2017
  1. [DI] ContainerBuilder::compile() can optionally resolve env vars in p…

    …arameter bag
    nicolas-grekas committed Jan 29, 2017
Commits on Feb 8, 2017
  1. [Finder] Add double-star matching to Glob::toRegex()

    nicolas-grekas committed Feb 8, 2017
  2. [DI] Refacto / cleanup / minor fixes

    nicolas-grekas committed Feb 7, 2017
Commits on Feb 7, 2017
  1. bug #21552 [FrameworkBundle] Fix annotations cache folder path (akeeman)

    This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes #21552).
    
    Discussion
    ----------
    
    [FrameworkBundle] Fix annotations cache folder path
    
    | Q             | A
    | ------------- | ---
    | Branch?       |  3.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | n/a
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    The argument at index 2 sets a cache path as it extends the file system adapter by default since e59f0e0, where it did set the version before that. This change now results in annotation cache folders showing up in the project root (because of the overwritten cache root folder).
    Because cache.annotations has a parent now, this line is not needed anymore and fixes the problem.
    
    Commits
    -------
    
    8e5cfa7 Fix annotations cache folder path
    nicolas-grekas committed Feb 7, 2017
  2. [FrameworkBundle] Wire ArrayCache for annotation reader at bootstrap

    nicolas-grekas committed Feb 7, 2017
  3. [Config][DI] Add ComposerResource to track runtime + vendors

    nicolas-grekas committed Feb 2, 2017
Commits on Feb 6, 2017
  1. bug #21542 [VarDumper] Fixed dumping of terminated generator (lyrixx)

    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [VarDumper] Fixed dumping of terminated generator
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    c5094a0 [VarDumper] Fixed dumping of terminated generator
    nicolas-grekas committed Feb 6, 2017
  2. bug #21292 Ignore missing 'debug.file_link_formatter' service in Debu…

    …g bundle (core23)
    
    This PR was merged into the 3.2 branch.
    
    Discussion
    ----------
    
    Ignore missing 'debug.file_link_formatter' service in Debug bundle
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | N/A
    | License       | MIT
    | Doc PR        | N/A
    
    The new `HtmlDumper` requires the `debug.file_link_formatter` service which isn't available in older versions of the `DebugBundle`
    
    Commits
    -------
    
    2201fbe Ignore missing 'debug.file_link_formatter' service in Debug bundle
    nicolas-grekas committed Feb 6, 2017
Commits on Feb 5, 2017
  1. bug #21528 [Cache] Fix class exists checks in PhpArrayAdapter (nicola…

    …s-grekas)
    
    This PR was merged into the 3.2 branch.
    
    Discussion
    ----------
    
    [Cache] Fix class exists checks in PhpArrayAdapter
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Fixes HHVM, as spotted in #21527
    
    Commits
    -------
    
    44e5989 [Cache] Fix class exists checks in PhpArrayAdapter
    nicolas-grekas committed Feb 5, 2017
  2. bug #21527 [Config] Fix conditional class existence checks (nicolas-g…

    …rekas)
    
    This PR was merged into the 3.3-dev branch.
    
    Discussion
    ----------
    
    [Config] Fix conditional class existence checks
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    686af61 [Config] Fix conditional class existence checks
    nicolas-grekas committed Feb 5, 2017
  3. bug #20844 [Config] Fix checking cache for non existing meta file (ha…

    …son)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [Config] Fix checking cache for non existing meta file
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | maybe
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    17f02e0 [Config] Fix checking cache for non existing meta file
    nicolas-grekas committed Feb 5, 2017
  4. minor #21532 Remove 3.1 from PR template (chalasr)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Remove 3.1 from PR template
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    
    Commits
    -------
    
    57f67e8 Remove 3.1 from PR template
    nicolas-grekas committed Feb 5, 2017
Commits on Feb 4, 2017
  1. [Config] Fix conditional class existence checks

    nicolas-grekas committed Feb 4, 2017
  2. [Cache] Fix class exists checks in PhpArrayAdapter

    nicolas-grekas committed Feb 4, 2017
Commits on Feb 3, 2017
  1. Merge branch '3.2'

    * 3.2:
      [FrameworkBundle][Console] JsonDescriptor: Respect original output
      [Process] Non ASCII characters disappearing during the escapeshellarg
    nicolas-grekas committed Feb 3, 2017
  2. Merge branch '2.8' into 3.2

    * 2.8:
      [FrameworkBundle][Console] JsonDescriptor: Respect original output
      [Process] Non ASCII characters disappearing during the escapeshellarg
    nicolas-grekas committed Feb 3, 2017
  3. Merge branch '2.7' into 2.8

    * 2.7:
      [Process] Non ASCII characters disappearing during the escapeshellarg
    nicolas-grekas committed Feb 3, 2017
  4. minor #21515 [FrameworkBundle][Console] JsonDescriptor: Respect origi…

    …nal output (ogizanagi)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle][Console] JsonDescriptor: Respect original output
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | no
    | Fixed tickets | N/A
    | License       | MIT
    | Doc PR        | N/A
    
    Follows up #21501.
    
    This one fixes the keys order (preserved from the order those keys are added from the `JsonDescriptor`), as for the previous mentioned PR, in order to slightly improve the situation when updating the descriptors fixtures.
    
    @nicolas-grekas : Thanks for taking care of the previous one. There are two other PRs required to me in order to fix everything on every branches, but I wonder if it wouldn't be easier (and reduce noise) to apply the following patches while merging this in upper branches instead:
    
    - 3.2: ogizanagi@51a0a1c
    - master: ogizanagi@b35a244
    
    WDYT?
    
    Commits
    -------
    
    bf71776 [FrameworkBundle][Console] JsonDescriptor: Respect original output
    nicolas-grekas committed Feb 3, 2017