Permalink
Commits on Nov 8, 2018
  1. minor #29150 Remove unused dependency in FrameworkExtensionTest (gonz…

    nicolas-grekas committed Nov 8, 2018
    …alovilaseca)
    
    This PR was submitted for the master branch but it was merged into the 4.1 branch instead (closes #29150).
    
    Discussion
    ----------
    
    Remove unused dependency in FrameworkExtensionTest
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? |no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    `Validation` is not used anywhere in the file, I can only see `new \ReflectionClass('Symfony\Component\Validator\Validation');`, maybe it's better to leave the `use` and replace with `new \ReflectionClass(Validation::class);`?
    
    Commits
    -------
    
    aea5ca2 Remove unused dependency
  2. Merge branch '4.1'

    nicolas-grekas committed Nov 8, 2018
    * 4.1:
      fix merge
  3. fix merge

    nicolas-grekas committed Nov 8, 2018
  4. bug #29113 [Routing] fix dumping conditions that use the request (nic…

    nicolas-grekas committed Nov 8, 2018
    …olas-grekas)
    
    This PR was merged into the 4.2-dev branch.
    
    Discussion
    ----------
    
    [Routing] fix dumping conditions that use the request
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #29106
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    09d5be8 [Routing] fix dumping conditions that use the request
  5. Merge branch '4.1'

    nicolas-grekas committed Nov 8, 2018
    * 4.1:
      Change button_widget class to btn-primary
      [Serializer] Allow null values when denormalizing with constructor missing data
      [Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS
      [HttpFoundation] Fixed PHP doc of ParameterBag::getBoolean
      [HttpFoundation] replace any preexisting Content-Type headers
  6. Merge branch '3.4' into 4.1

    nicolas-grekas committed Nov 8, 2018
    * 3.4:
      Change button_widget class to btn-primary
      [Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS
      [HttpFoundation] Fixed PHP doc of ParameterBag::getBoolean
      [HttpFoundation] replace any preexisting Content-Type headers
  7. bug #29115 Change button_widget class to btn-primary (neFAST)

    nicolas-grekas committed Nov 8, 2018
    This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #29115).
    
    Discussion
    ----------
    
    Change button_widget class to btn-primary
    
    FIX #29114
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master for features / 2.8 up to 4.1 for bug fixes <!-- see below -->
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #29114   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    Change button_widget class to btn-primary in Bootstrap 4 twig template
    
    Commits
    -------
    
    59003bf Change button_widget class to btn-primary
  8. bug #29131 [Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS (ni…

    nicolas-grekas committed Nov 8, 2018
    …colas-grekas)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Since using it is not thread safe, let's not rely on it (already done in other places.)
    
    Commits
    -------
    
    21a909a [Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS
  9. Merge branch '2.8' into 3.4

    nicolas-grekas committed Nov 8, 2018
    * 2.8:
      [HttpFoundation] Fixed PHP doc of ParameterBag::getBoolean
      [HttpFoundation] replace any preexisting Content-Type headers
  10. bug #29057 [HttpFoundation] replace any preexisting Content-Type head…

    nicolas-grekas committed Nov 8, 2018
    …ers (nicolas-grekas)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [HttpFoundation] replace any preexisting Content-Type headers
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #21204
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    de2ce58 [HttpFoundation] replace any preexisting Content-Type headers
  11. [Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS

    nicolas-grekas committed Nov 8, 2018
Commits on Nov 6, 2018
  1. [Routing] fix dumping conditions that use the request

    nicolas-grekas committed Nov 6, 2018
  2. minor #29111 [HttpFoundation] Fixed PHP doc of ParameterBag::getBoole…

    nicolas-grekas committed Nov 6, 2018
    …an (lyrixx)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [HttpFoundation] Fixed PHP doc of ParameterBag::getBoolean
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    ---
    
    Since the method should return a bool, then the default value should be
    a bool too
    
    Commits
    -------
    
    1fa5a9a [HttpFoundation] Fixed PHP doc of ParameterBag::getBoolean
  3. Merge branch '4.1'

    nicolas-grekas committed Nov 6, 2018
    * 4.1:
      [VarDumper] fix dump of closures created from callables
      [DI] fix dumping inlined services
      Add framework asset changes to upgrade 3.0 guide
      [Travis] Bump ext-mongodb to 1.5.2 on Travis
      [DI] dont track classes/interfaces used to compute autowiring error messages
      [DI] fix GraphvizDumper ignoring inline definitions
      bumped Symfony version to 4.1.8
      updated VERSION for 4.1.7
      updated CHANGELOG for 4.1.7
      bumped Symfony version to 3.4.19
      updated VERSION for 3.4.18
      updated CHANGELOG for 3.4.18
      bumped Symfony version to 2.8.48
      updated VERSION for 2.8.47
      update CONTRIBUTORS for 2.8.47
      updated CHANGELOG for 2.8.47
      Fix ini_get() for boolean values
  4. Merge branch '3.4' into 4.1

    nicolas-grekas committed Nov 6, 2018
    * 3.4:
      [VarDumper] fix dump of closures created from callables
      [DI] fix dumping inlined services
      Add framework asset changes to upgrade 3.0 guide
      [Travis] Bump ext-mongodb to 1.5.2 on Travis
      [DI] dont track classes/interfaces used to compute autowiring error messages
      [DI] fix GraphvizDumper ignoring inline definitions
      bumped Symfony version to 3.4.19
      updated VERSION for 3.4.18
      updated CHANGELOG for 3.4.18
      bumped Symfony version to 2.8.48
      updated VERSION for 2.8.47
      update CONTRIBUTORS for 2.8.47
      updated CHANGELOG for 2.8.47
      Fix ini_get() for boolean values
  5. bug #29104 [DI] fix dumping inlined services (nicolas-grekas)

    nicolas-grekas committed Nov 6, 2018
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [DI] fix dumping inlined services
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #28824 #29078
    | License       | MIT
    | Doc PR        | -
    
    Same as #29103 but for 3.4.
    
    This PR dump inline services using the call-stack to sort the code for instantiating them.
    This makes easier to follow and matches the behavior one would expect (and has when using `ContainerBuiler` directly to create services.)
    
    Commits
    -------
    
    a97606d [DI] fix dumping inlined services
  6. bug #29054 [VarDumper] fix dump of closures created from callables (n…

    nicolas-grekas committed Nov 6, 2018
    …icolas-grekas)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [VarDumper] fix dump of closures created from callables
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    We are missing displaying full information about closures created using `ReflectionMethod::getClosure()` or `Closure::fromCallable()`.
    
    This PR fixes it. For VarDumper but also other places where we have logic to display them.
    
    Commits
    -------
    
    1c1818b [VarDumper] fix dump of closures created from callables
  7. [VarDumper] fix dump of closures created from callables

    nicolas-grekas committed Nov 1, 2018
  8. [DI] fix dumping inlined services

    nicolas-grekas committed Oct 16, 2018
  9. Merge branch '2.8' into 3.4

    nicolas-grekas committed Nov 6, 2018
    * 2.8:
      Add framework asset changes to upgrade 3.0 guide
      [Travis] Bump ext-mongodb to 1.5.2 on Travis
      bumped Symfony version to 2.8.48
      updated VERSION for 2.8.47
      update CONTRIBUTORS for 2.8.47
      updated CHANGELOG for 2.8.47
  10. bug #29102 [DI] fix GraphvizDumper ignoring inline definitions (nicol…

    nicolas-grekas committed Nov 6, 2018
    …as-grekas)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [DI] fix GraphvizDumper ignoring inline definitions
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Since SF3, inline definitions are first class citizen. I noticed that the GraphvizDumper does not inspect them. Here is the fix.
    
    Commits
    -------
    
    ebe6265 [DI] fix GraphvizDumper ignoring inline definitions
  11. minor #29041 Fix ini_get() for boolean values (deguif)

    nicolas-grekas committed Nov 6, 2018
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Fix ini_get() for boolean values
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    This follows #29020 for branch 3.4
    
    Commits
    -------
    
    65b34cb Fix ini_get() for boolean values
  12. minor #29077 Add framework asset changes to upgrade 3.0 guide (Kathar…

    nicolas-grekas committed Nov 6, 2018
    …inaSt)
    
    This PR was squashed before being merged into the 2.8 branch (closes #29077).
    
    Discussion
    ----------
    
    Add framework asset changes to upgrade 3.0 guide
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8 up to 4.1 <!-- see below -->
    | Bug fix?      | no (upgrade guide improvement)
    | New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #29050   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | - <!-- required for new features -->
    
    further reading:
    https://symfony.com/blog/new-in-symfony-2-7-the-new-asset-component
    <!--
    Write a short README entry for your feature/bugfix here (replace this comment block.)
    This will help people understand your PR and can be used as a start of the Doc PR.
    Additionally:
     - Bug fixes must be submitted against the lowest branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    
    Commits
    -------
    
    7de1088 Add framework asset changes to upgrade 3.0 guide
  13. bug #29090 LoggingTranslator should implement Symfony\Contracts\Trans…

    nicolas-grekas committed Nov 6, 2018
    …lation\TranslatorInterface (desmax)
    
    This PR was merged into the 4.2-dev branch.
    
    Discussion
    ----------
    
    LoggingTranslator should implement Symfony\Contracts\Translation\TranslatorInterface
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #29089
    | License       | MIT
    
    While autowiring Translator using `Symfony\Contracts\Translation\TranslatorInterface` symfony complains that wrong service was injected, because LoggingTranslator does not implement new interface.
    
    Commits
    -------
    
    65f321f LoggingTranslator should implement Symfony\Contracts\Translation\TranslatorInterface
  14. bug #29095 [TwigBridge] require the needed symfony/contracts package …

    nicolas-grekas committed Nov 6, 2018
    …(xabbuh)
    
    This PR was merged into the 4.2-dev branch.
    
    Discussion
    ----------
    
    [TwigBridge] require the needed symfony/contracts package
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #29086
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    4400776 require the needed symfony/contracts package
  15. bug #29107 [DI] dont track classes/interfaces used to compute autowir…

    nicolas-grekas committed Nov 6, 2018
    …ing error messages (nicolas-grekas)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [DI] dont track classes/interfaces used to compute autowiring error messages
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #29019
    | License       | MIT
    | Doc PR        | -
    
    This will also improve DX since tracking these files is not needed at all.
    
    Commits
    -------
    
    09a0c23 [DI] dont track classes/interfaces used to compute autowiring error messages
  16. minor #29068 Remove unused variable (jschaedl)

    nicolas-grekas committed Nov 6, 2018
    This PR was merged into the 4.2-dev branch.
    
    Discussion
    ----------
    
    Remove unused variable
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    246b3bf Remove unused variable
  17. bug #29094 Add samesite attribute to session cookie after session mig…

    nicolas-grekas committed Nov 6, 2018
    …ration (rpkamp)
    
    This PR was merged into the 4.2-dev branch.
    
    Discussion
    ----------
    
    Add samesite attribute to session cookie after session migration
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #29092
    | License       | MIT
    | Doc PR        | N/A
    
    Commits
    -------
    
    df90300 Add samesite attribute to session cookie after session migration
  18. minor #29099 [Travis] Bump ext-mongodb to 1.5.2 on Travis (ogizanagi)

    nicolas-grekas committed Nov 6, 2018
    This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #29099).
    
    Discussion
    ----------
    
    [Travis] Bump ext-mongodb to 1.5.2 on Travis
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7 <!-- see below -->
    | Bug fix?      | no
    | New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | https://travis-ci.org/symfony/symfony/jobs/451058906#L2679   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | N/A
    
    Should fix Travis builds after mongodb/mongo-php-library@ba0b611 being merged (but not released yet).
    
    And/or use `composer require --dev --no-update mongodb/mongodb:@stable`?
    
    Commits
    -------
    
    6e4af32 [Travis] Bump ext-mongodb to 1.5.2 on Travis
  19. minor #29100 [Messenger] Cleaning after new changes (yceruto)

    nicolas-grekas committed Nov 6, 2018
    This PR was squashed before being merged into the 4.2-dev branch (closes #29100).
    
    Discussion
    ----------
    
    [Messenger] Cleaning after new changes
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    See topic per commit
    
    Commits
    -------
    
    3d31772 [Messenger] Cleaning after new changes
  20. [DI] dont track classes/interfaces used to compute autowiring error m…

    nicolas-grekas committed Nov 6, 2018
    …essages
  21. [DI] fix GraphvizDumper ignoring inline definitions

    nicolas-grekas committed Nov 6, 2018
Commits on Nov 2, 2018
  1. bug #29064 [DI] Fix EOL replacement (ro0NL)

    nicolas-grekas committed Nov 2, 2018
    This PR was merged into the 4.2-dev branch.
    
    Discussion
    ----------
    
    [DI] Fix EOL replacement
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #29063
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    <!--
    Write a short README entry for your feature/bugfix here (replace this comment block.)
    This will help people understand your PR and can be used as a start of the Doc PR.
    Additionally:
     - Bug fixes must be submitted against the lowest branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    
    Commits
    -------
    
    52f15f7 [DI] Fix EOL replacement
  2. bug #29062 Fix GlobResource serialization (alexismarquis)

    nicolas-grekas committed Nov 2, 2018
    This PR was squashed before being merged into the 4.2-dev branch (closes #29062).
    
    Discussion
    ----------
    
    Fix GlobResource serialization
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master <!-- see below -->
    | Bug fix?      | yes
    | New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | no    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #28200   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | <!-- required for new features -->
    
    Since @gonzalovilaseca improvement in PR #28200, I noticed that the container is being compiled systematically. This is caused by the two added properties (`forExclusion`, `excludedPrefixes`) not being serialized, and lead to wrong hash computing. I updated the `serialize` and `unserialize` methods in this PR.
    
    ping @nicolas-grekas
    
    Commits
    -------
    
    6ce7f07 Fix GlobResource serialization