Permalink
Commits on Dec 6, 2018
  1. Merge branch '4.2'

    nicolas-grekas committed Dec 6, 2018
    * 4.2:
      fix CI
  2. Merge branch '4.1' into 4.2

    nicolas-grekas committed Dec 6, 2018
    * 4.1:
      fix CI
  3. Merge branch '3.4' into 4.1

    nicolas-grekas committed Dec 6, 2018
    * 3.4:
      fix CI
  4. Merge branch '2.8' into 3.4

    nicolas-grekas committed Dec 6, 2018
    * 2.8:
      fix CI
  5. Merge branch '2.7' into 2.8

    nicolas-grekas committed Dec 6, 2018
    * 2.7:
      fix CI
  6. fix CI

    nicolas-grekas committed Dec 6, 2018
  7. Merge branch '4.2'

    nicolas-grekas committed Dec 6, 2018
    * 4.2:
      [Security\Http] detect bad redirect targets using backslashes
      [Form] Filter file uploads out of regular form types
      Fix CI
      minor #28258 [travis] fix composer.lock invalidation for deps=low (nicolas-grekas)
      [travis] fix composer.lock invalidation for PRs patching several components
      [travis] fix composer.lock invalidation for deps=low
      minor #28199 [travis][appveyor] use symfony/flex to accelerate builds (nicolas-grekas)
      [travis] ignore ordering when validating composer.lock files for deps=low
      minor #28146 [travis] cache composer.lock files for deps=low (nicolas-grekas)
      fix ci
      [travis] fix requiring mongodb/mongodb before composer up
      minor #28114 [travis] merge "same Symfony version" jobs in one (nicolas-grekas)
      [2.7] Make CI green
      updated VERSION for 2.7.49
      updated CHANGELOG for 2.7.49
      [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
      [HttpFoundation] Remove support for legacy and risky HTTP headers
      updated VERSION for 2.7.48
      update CONTRIBUTORS for 2.7.48
      updated CHANGELOG for 2.7.48
  8. Merge branch '4.1' into 4.2

    nicolas-grekas committed Dec 6, 2018
    * 4.1:
      [Security\Http] detect bad redirect targets using backslashes
      [Form] Filter file uploads out of regular form types
      Fix CI
      minor #28258 [travis] fix composer.lock invalidation for deps=low (nicolas-grekas)
      [travis] fix composer.lock invalidation for PRs patching several components
      [travis] fix composer.lock invalidation for deps=low
      minor #28199 [travis][appveyor] use symfony/flex to accelerate builds (nicolas-grekas)
      [travis] ignore ordering when validating composer.lock files for deps=low
      minor #28146 [travis] cache composer.lock files for deps=low (nicolas-grekas)
      fix ci
      [travis] fix requiring mongodb/mongodb before composer up
      minor #28114 [travis] merge "same Symfony version" jobs in one (nicolas-grekas)
      [2.7] Make CI green
      updated VERSION for 2.7.49
      updated CHANGELOG for 2.7.49
      [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
      [HttpFoundation] Remove support for legacy and risky HTTP headers
      updated VERSION for 2.7.48
      update CONTRIBUTORS for 2.7.48
      updated CHANGELOG for 2.7.48
  9. Merge branch '3.4' into 4.1

    nicolas-grekas committed Dec 6, 2018
    * 3.4:
      [Security\Http] detect bad redirect targets using backslashes
      [Form] Filter file uploads out of regular form types
      Fix CI
      minor #28258 [travis] fix composer.lock invalidation for deps=low (nicolas-grekas)
      [travis] fix composer.lock invalidation for PRs patching several components
      [travis] fix composer.lock invalidation for deps=low
      minor #28199 [travis][appveyor] use symfony/flex to accelerate builds (nicolas-grekas)
      [travis] ignore ordering when validating composer.lock files for deps=low
      minor #28146 [travis] cache composer.lock files for deps=low (nicolas-grekas)
      fix ci
      [travis] fix requiring mongodb/mongodb before composer up
      minor #28114 [travis] merge "same Symfony version" jobs in one (nicolas-grekas)
      [2.7] Make CI green
      updated VERSION for 2.7.49
      updated CHANGELOG for 2.7.49
      [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
      [HttpFoundation] Remove support for legacy and risky HTTP headers
      updated VERSION for 2.7.48
      update CONTRIBUTORS for 2.7.48
      updated CHANGELOG for 2.7.48
  10. Merge branch '2.8' into 3.4

    nicolas-grekas committed Dec 6, 2018
    * 2.8:
      [Security\Http] detect bad redirect targets using backslashes
      [Form] Filter file uploads out of regular form types
      Fix CI
      minor #28258 [travis] fix composer.lock invalidation for deps=low (nicolas-grekas)
      [travis] fix composer.lock invalidation for PRs patching several components
      [travis] fix composer.lock invalidation for deps=low
      minor #28199 [travis][appveyor] use symfony/flex to accelerate builds (nicolas-grekas)
      [travis] ignore ordering when validating composer.lock files for deps=low
      minor #28146 [travis] cache composer.lock files for deps=low (nicolas-grekas)
      fix ci
      [travis] fix requiring mongodb/mongodb before composer up
      minor #28114 [travis] merge "same Symfony version" jobs in one (nicolas-grekas)
      [2.7] Make CI green
      updated VERSION for 2.7.49
      updated CHANGELOG for 2.7.49
      [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
      [HttpFoundation] Remove support for legacy and risky HTTP headers
      updated VERSION for 2.7.48
      update CONTRIBUTORS for 2.7.48
      updated CHANGELOG for 2.7.48
  11. Merge branch '2.7' into 2.8

    nicolas-grekas committed Dec 6, 2018
    * 2.7:
      [Security\Http] detect bad redirect targets using backslashes
      [Form] Filter file uploads out of regular form types
      Fix CI
      minor #28258 [travis] fix composer.lock invalidation for deps=low (nicolas-grekas)
      [travis] fix composer.lock invalidation for PRs patching several components
      [travis] fix composer.lock invalidation for deps=low
      minor #28199 [travis][appveyor] use symfony/flex to accelerate builds (nicolas-grekas)
      [travis] ignore ordering when validating composer.lock files for deps=low
      minor #28146 [travis] cache composer.lock files for deps=low (nicolas-grekas)
      fix ci
      [travis] fix requiring mongodb/mongodb before composer up
      minor #28114 [travis] merge "same Symfony version" jobs in one (nicolas-grekas)
      [2.7] Make CI green
      updated VERSION for 2.7.49
      updated CHANGELOG for 2.7.49
      [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
      [HttpFoundation] Remove support for legacy and risky HTTP headers
      updated VERSION for 2.7.48
      update CONTRIBUTORS for 2.7.48
      updated CHANGELOG for 2.7.48
  12. security #cve-2018-19790 [Security\Http] detect bad redirect targets …

    nicolas-grekas committed Dec 6, 2018
    …using backslashes (xabbuh)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Security\Http] detect bad redirect targets using backslashes
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #76
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    99a0cec [Security\Http] detect bad redirect targets using backslashes
  13. security #cve-2018-19789 [Form] Filter file uploads out of regular fo…

    nicolas-grekas committed Dec 6, 2018
    …rm types (nicolas-grekas)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Form] Filter file uploads out of regular form types
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    This PR filters uploaded files out of the data processed by any form type except `FileType`.
    
    Commits
    -------
    
    205a44e [Form] Filter file uploads out of regular form types
  14. Merge branch '4.2'

    nicolas-grekas committed Dec 6, 2018
    * 4.2:
      [TwigBridge] Deprecating legacy Twig paths in DebugCommand and simplifications
      [Cache] Fixed Memcached adapter doClear()to call flush()
      Fixes sprintf(): Too few arguments in Translator
      fix TransChoiceTokenParser deprecation message
      [DoctrineBridge] Conflict with Messenger <4.2
      [Contracts] extract LocaleAwareInterface out of TranslatorInterface
  15. Merge branch '4.1' into 4.2

    nicolas-grekas committed Dec 6, 2018
    * 4.1:
      [Cache] Fixed Memcached adapter doClear()to call flush()
  16. Merge branch '3.4' into 4.1

    nicolas-grekas committed Dec 6, 2018
    * 3.4:
      [Cache] Fixed Memcached adapter doClear()to call flush()
  17. bug #29481 [TwigBridge] Deprecating legacy Twig paths in DebugCommand…

    nicolas-grekas committed Dec 6, 2018
    … and simplifications (yceruto)
    
    This PR was squashed before being merged into the 4.2 branch (closes #29481).
    
    Discussion
    ----------
    
    [TwigBridge] Deprecating legacy Twig paths in DebugCommand and simplifications
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | yes
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    I've also added some missing tests.
    
    Commits
    -------
    
    96169b8 [TwigBridge] Deprecating legacy Twig paths in DebugCommand and simplifications
  18. bug #29436 [Cache] Fixed Memcached adapter doClear()to call flush() (…

    nicolas-grekas committed Dec 6, 2018
    …raitocz)
    
    This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #29436).
    
    Discussion
    ----------
    
    [Cache] Fixed Memcached adapter doClear()to call flush()
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #29435
    | License       | MIT
    | Doc PR        | symfony/symfony-docs
    
    MemcachedTrait now calls Memcached::flush via its client instead of just returning false.
    
    Commits
    -------
    
    447baac [Cache] Fixed Memcached adapter doClear()to call flush()
  19. minor #29464 [DoctrineBridge] Conflict with Messenger <4.2 (ogizanagi)

    nicolas-grekas committed Dec 6, 2018
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [DoctrineBridge] Conflict with Messenger <4.2
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2 <!-- see below -->
    | Bug fix?      | no
    | New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #29463   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | N/A
    
    Commits
    -------
    
    8624cde [DoctrineBridge] Conflict with Messenger <4.2
  20. minor #29479 Fix TransChoiceTokenParser deprecation message (fbouriga…

    nicolas-grekas committed Dec 6, 2018
    …ult)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    Fix TransChoiceTokenParser deprecation message
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | N/A
    | License       | MIT
    | Doc PR        | N/A
    
    While debugging a `cache:clear`, I found the following errors on stderr:
    ```
    PHP Warning: sprintf(): Too few arguments in .../vendor/symfony/twig-bridge/TokenParser/TransChoiceTokenParser.php on line 43
    ```
    
    This was caused by using unescaped `%` in the `sprintf` format string.
    
    This fix the `sprintf` format string so the deprecation message will now works.
    
    Commits
    -------
    
    3d3b3ce fix TransChoiceTokenParser deprecation message
  21. bug #29482 Fixes sprintf(): Too few arguments in MessageFormatter::ch…

    nicolas-grekas committed Dec 6, 2018
    …oiceFormat (stephanedelprat)
    
    This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes #29482).
    
    Discussion
    ----------
    
    Fixes sprintf(): Too few arguments in MessageFormatter::choiceFormat
    
    Similar to : #29344
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | related to a previous deprecation <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | I hope so
    | Fixed tickets | none
    | License       | MIT
    | Doc PR        | none
    
    Fixes the log produced when the method is called :
    
    Before : "sprintf(): Too few arguments"
    
    After : "The "Symfony\Component\Translation\Formatter\MessageFormatter::choiceFormat()" method is deprecated since Symfony 4.2, use the format() one instead with a %count% parameter."
    
    Reference : http://php.net/manual/function.sprintf.php
    
    Commits
    -------
    
    109fee5 Fixes sprintf(): Too few arguments in Translator
  22. bug #29461 [Contracts] extract LocaleAwareInterface out of Translator…

    nicolas-grekas committed Dec 6, 2018
    …Interface (nicolas-grekas)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [Contracts] extract LocaleAwareInterface out of TranslatorInterface
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | yes
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    While reviewing #28929, I realized we have a design issue in the Translation contract: we missed segregating `setLocale()`/`getLocale()` out of `TranslatorInterface`. E.g. when people type-hint for `TranslatorInterface`, they *should not* be auto-suggested with the `setLocale()` mutator.
    
    Technically, that's a BC break. I think we should do it. The release is close enough in time and that will save us from maintenance issues this will create in the future otherwise.
    
    Commits
    -------
    
    73e4a1a [Contracts] extract LocaleAwareInterface out of TranslatorInterface
Commits on Dec 5, 2018
Commits on Dec 3, 2018
  1. Merge branch '4.2'

    nicolas-grekas committed Dec 3, 2018
    * 4.2:
      [VarExporter] fix dumping private properties from abstract classes
      Fix empty output for debug:autowiring when reflection-docblock is not available
      [Workflow] Fixed BC break for Workflow metadata
      [Routing] ignore trailing slash for non-GET requests
  2. bug #29446 [VarExporter] fix dumping private properties from abstract…

    nicolas-grekas committed Dec 3, 2018
    … classes (nicolas-grekas)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [VarExporter] fix dumping private properties from abstract classes
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #29406
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    b10e263 [VarExporter] fix dumping private properties from abstract classes
  3. Merge branch '4.1' into 4.2

    nicolas-grekas committed Dec 3, 2018
    * 4.1:
      [Workflow] Fixed BC break for Workflow metadata
      [Routing] ignore trailing slash for non-GET requests
  4. Merge branch '3.4' into 4.1

    nicolas-grekas committed Dec 3, 2018
    * 3.4:
      [Routing] ignore trailing slash for non-GET requests
  5. bug #29441 [Routing] ignore trailing slash for non-GET requests (nico…

    nicolas-grekas committed Dec 3, 2018
    …las-grekas)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Routing] ignore trailing slash for non-GET requests
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #29410
    | License       | MIT
    | Doc PR        | -
    
    Another test case provided by @peterrehm in the linked issue - the dumped matcher already passes this test - but the non-dumped one doesn't (neither does the dumped one in 4.1 - I'll fix while merging up)
    
    Commits
    -------
    
    7521af7 [Routing] ignore trailing slash for non-GET requests
  6. bug #29445 [FrameworkBundle] Fix empty output for debug:autowiring wh…

    nicolas-grekas committed Dec 3, 2018
    …en reflection-docblock is not installed (chalasr)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Fix empty output for debug:autowiring when reflection-docblock is not installed
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #29442
    | License       | MIT
    | Doc PR        | n/a
    
    ![screenshot 2018-12-03 at 19 25 07](https://user-images.githubusercontent.com/7502063/49393383-549f8a00-f731-11e8-822c-43959514c69d.png)
    
    instead of no output at all when phpdocumentor/reflection-docblock is not installed
    
    Commits
    -------
    
    bd0dbe4 Fix empty output for debug:autowiring when reflection-docblock is not available
  7. bug #29444 [Workflow] Fixed BC break for Workflow metadata (lyrixx)

    nicolas-grekas committed Dec 3, 2018
    This PR was merged into the 4.1 branch.
    
    Discussion
    ----------
    
    [Workflow] Fixed BC break for Workflow metadata
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.1
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #29427
    | License       | MIT
    | Doc PR        |
    
    I used SplObjectStorage to store the transition metadata.
    So we need to use the exact same PHP Object.
    
    Commits
    -------
    
    5691818 [Workflow] Fixed BC break for Workflow metadata
  8. [Routing] ignore trailing slash for non-GET requests

    nicolas-grekas committed Dec 3, 2018
Commits on Dec 2, 2018
  1. Merge branch '4.2'

    nicolas-grekas committed Dec 2, 2018
    * 4.2:
      [DI] dont inline when lazy edges are found
  2. Merge branch '4.1' into 4.2

    nicolas-grekas committed Dec 2, 2018
    * 4.1:
      [DI] dont inline when lazy edges are found
  3. Merge branch '3.4' into 4.1

    nicolas-grekas committed Dec 2, 2018
    * 3.4:
      [DI] dont inline when lazy edges are found