Permalink
Branch: master
Commits on Feb 8, 2019
  1. Merge branch '4.2'

    nicolas-grekas committed Feb 8, 2019
    * 4.2:
      replace mocks with real objects in tests
  2. minor #30113 [Form] replace mocks with real objects in tests (xabbuh)

    nicolas-grekas committed Feb 8, 2019
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [Form] replace mocks with real objects in tests
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    reapplies parts of #30108 on the `4.2` branch
    
    Commits
    -------
    
    cee3ccd replace mocks with real objects in tests
  3. Merge branch '4.2'

    nicolas-grekas committed Feb 8, 2019
    * 4.2:
      New extensions were released supporting PHP 7.3
      Remove "internal" annotation from datacollector serialization methods
      replace mocks with real objects in tests
      [DependencyInjection] fix #29930 add $lazyLoad flag to the generated factory code for lazy non-shared services
      escape function does not always take a string
      Fix phpunit 8 compatibility
      render integer types with grouping as text input
      ignore _method forms in NativeRequestHandler
      don't lose int precision with not needed type casts
  4. Merge branch '3.4' into 4.2

    nicolas-grekas committed Feb 8, 2019
    * 3.4:
      Remove "internal" annotation from datacollector serialization methods
      replace mocks with real objects in tests
      Fix phpunit 8 compatibility
      render integer types with grouping as text input
      ignore _method forms in NativeRequestHandler
      don't lose int precision with not needed type casts
  5. minor #30112 Remove "internal" annotation from datacollector serializ…

    nicolas-grekas committed Feb 8, 2019
    …ation methods (nicolas-grekas)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Remove "internal" annotation from datacollector serialization methods
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    I've been a bit too aggressively adding `@Internal` in #30035.
    
    Commits
    -------
    
    3c8fd20 Remove "internal" annotation from datacollector serialization methods
  6. minor #30057 New extensions were released supporting PHP 7.3 (tvlooy)

    nicolas-grekas committed Feb 8, 2019
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    New extensions were released supporting PHP 7.3
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | see travis
    | License       | MIT
    
    Requested in #30030
    
    Commits
    -------
    
    31de71d New extensions were released supporting PHP 7.3
  7. feature #30027 [FrameworkBundle] Add sid_length and sid_bits_per_char…

    nicolas-grekas committed Feb 8, 2019
    …acter session ini options in session configuration (XuruDragon)
    
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Add sid_length and sid_bits_per_character session ini options in session configuration
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #29830
    | License       | MIT
    | Doc PR        | n/a
    
    this a fix for the issue #29830
    
    After deliberation, we estimate that only `sid_length` and` sid_bits_per_character` session options should be exposed. These options à optional.
    
    For others, we recommend changing your php.ini file
    
    We can now configure the session like this :
    
    ```yaml
    framwork:
      session:
        sid_length: 64 //optional, recommended value is 32
        sid_bits_per_character: 6 //optional, recommended value is 5
    ```
    
    Commits
    -------
    
    0403e4a [FrameworkBundle] Add sid_length and sid_bits_per_character session ini options in configuration
  8. bug #30061 [Form] render integer types with grouping as text input (x…

    nicolas-grekas committed Feb 8, 2019
    …abbuh)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Form] render integer types with grouping as text input
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #29422
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    d6a5fde render integer types with grouping as text input
  9. bug #30063 [Form] don't lose int precision with not needed type casts…

    nicolas-grekas committed Feb 8, 2019
    … (xabbuh)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Form] don't lose int precision with not needed type casts
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #26795
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    72136f1 don't lose int precision with not needed type casts
  10. bug #30076 [Form] ignore _method forms in NativeRequestHandler (xabbuh)

    nicolas-grekas committed Feb 8, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Form] ignore _method forms in NativeRequestHandler
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #19017
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    bc4b091 ignore _method forms in NativeRequestHandler
  11. bug #30084 Fix KernelTestCase compatibility for PhpUnit 8 (alexander-…

    nicolas-grekas committed Feb 8, 2019
    …schranz)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Fix KernelTestCase compatibility for PhpUnit 8
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  |no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #30071
    | License       | MIT
    | Doc PR        |
    
    As the PhpUnit 8 Testcase has different return types as PhpUnit 7 there need to be 2 different classes to support both PhpUnit 8 and PhpUnit 7. With a class alias we can then change which version is used based on the PhpUnit Version constant. The fix is a little bit hacky but to support different major versions I see no other way.
    
    Not sure as we can't upgrade symfony/symfony to PhpUnit 8 how we can create a TestCase for this change.
    
    Commits
    -------
    
    83a56a0 Fix phpunit 8 compatibility
  12. minor #30108 [Form] replace mocks with real objects in tests (xabbuh)

    nicolas-grekas committed Feb 8, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Form] replace mocks with real objects in tests
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    6ac2550 replace mocks with real objects in tests
  13. bug #30093 [DependencyInjection] add $lazyLoad context to the generat…

    nicolas-grekas committed Feb 8, 2019
    …ed code for lazy non-shared service by PhpDumper (XuruDragon)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [DependencyInjection] add $lazyLoad context to the generated code for lazy non-shared service by PhpDumper
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.1
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #29930
    | License       | MIT
    | Doc PR        | n/a
    
    Fix #29930  by adding $lazyLoad context to the generated code for lazy non-shared service by PhpDumper
    
    Commits
    -------
    
    98d4dfd [DependencyInjection] fix #29930 add $lazyLoad flag to the generated factory code for lazy non-shared services
  14. feature #30075 [DependencyInjection] Added information about deprecat…

    nicolas-grekas committed Feb 8, 2019
    …ed aliases in debug:autowiring (XuruDragon)
    
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [DependencyInjection] Added information about deprecated aliases in debug:autowiring
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | none
    | License       | MIT
    | Doc PR        | n/a
    
    Fix and improves a bit PR #29968 and #29995
    
    ![Screenshot](https://i.imgur.com/GDj2NIY.png)
    
    Commits
    -------
    
    3d2378d [DependencyInjection] Added information about deprecated aliases in debug:autowiring
Commits on Feb 7, 2019
  1. Merge branch '4.2'

    nicolas-grekas committed Feb 7, 2019
    * 4.2:
      fix merge
      [FrameworkBundle] fix xsd
      [FrameworkBundle] update xsd to match the 4.2 configuration
      [FrameworkBundle] Update the xsd to match the actual session configuration
      [Form] CsrfValidationListener marks the token as invalid if it is not a string
      [Routing] fix perf issue when dumping large number of routes
      Fix wrong value in file id attribute for Xliff 2.0
      [VarDumper] Fixed phpDoc
      [PhpUnitBridge] fix PHP  5.3 compat
      [Messenger] Fix DataCollector template
      [Filesystem] Fixed some docblocks and typos
      bumped Symfony version to 4.2.4
      updated VERSION for 4.2.3
      updated CHANGELOG for 4.2.3
      bumped Symfony version to 3.4.23
      updated VERSION for 3.4.22
      update CONTRIBUTORS for 3.4.22
      updated CHANGELOG for 3.4.22
      fix some minor typos
      do not overwrite the constraint being evaluated
  2. fix merge

    nicolas-grekas committed Feb 7, 2019
  3. minor #30106 [FrameworkBundle] fix xsd (XuruDragon)

    nicolas-grekas committed Feb 7, 2019
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] fix xsd
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    fix a mistake introduce in #30101
    
    Commits
    -------
    
    436c3b9 [FrameworkBundle] fix xsd
  4. minor #30101 [FrameworkBundle] update xsd to match the 4.2 configurat…

    nicolas-grekas committed Feb 7, 2019
    …ion (XuruDragon)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] update xsd to match the 4.2 configuration
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/A
    
    Update the FrameworkBundle xsd to match the 4.2 configuration
    
    Commits
    -------
    
    7782e60 [FrameworkBundle] update xsd to match the 4.2 configuration
  5. Merge branch '3.4' into 4.2

    nicolas-grekas committed Feb 7, 2019
    * 3.4:
      [FrameworkBundle] Update the xsd to match the actual session configuration
      [Form] CsrfValidationListener marks the token as invalid if it is not a string
      [VarDumper] Fixed phpDoc
      [PhpUnitBridge] fix PHP  5.3 compat
      [Filesystem] Fixed some docblocks and typos
      bumped Symfony version to 3.4.23
      updated VERSION for 3.4.22
      update CONTRIBUTORS for 3.4.22
      updated CHANGELOG for 3.4.22
      fix some minor typos
      do not overwrite the constraint being evaluated
  6. minor #30100 [FrameworkBundle] Update the xsd to match the actual ses…

    nicolas-grekas committed Feb 7, 2019
    …sion configuration (XuruDragon)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Update the xsd to match the actual session configuration
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Update the FrameworkBundle xsd to match the actual session configuration
    
    Commits
    -------
    
    40bd76c [FrameworkBundle] Update the xsd to match the actual session configuration
  7. bug #29884 [Form] CsrfValidationListener marks the token as invalid i…

    nicolas-grekas committed Feb 7, 2019
    …f it is not a string (umpirsky)
    
    This PR was squashed before being merged into the 3.4 branch (closes #29884).
    
    Discussion
    ----------
    
    [Form] CsrfValidationListener marks the token as invalid if it is not a string
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #29882
    | License       | MIT
    
    Commits
    -------
    
    deb8e95 [Form] CsrfValidationListener marks the token as invalid if it is not a string
  8. feature #30024 [Debug] Display more details in the simple error page …

    nicolas-grekas committed Feb 7, 2019
    …of Debug (javiereguiluz)
    
    This PR was squashed before being merged into the 4.3-dev branch (closes #30024).
    
    Discussion
    ----------
    
    [Debug] Display more details in the simple error page of Debug
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #29891
    | License       | MIT
    | Doc PR        | -
    
    Note: this only changes the simple error page of Debug component, which is different from the full-featured error page of WebProfilerBundle.
    
    -----
    
    #29891 shows a confusing error page. In #29928 we improved the first error message displayed to the user. In this PR we implement @nicolas-grekas' idea to replace the generic error page title by a better error message. So, this PR + #29928 would fix #29891 to me.
    
    ### Before
    
    ![error-before](https://user-images.githubusercontent.com/73419/51920135-1519b500-23e5-11e9-99d6-e9b631b97499.png)
    
    ### After
    
    ![error-after](https://user-images.githubusercontent.com/73419/51920141-1945d280-23e5-11e9-97c3-49b2170dbd15.png)
    
    Commits
    -------
    
    75ff151 [Debug] Display more details in the simple error page of Debug
  9. bug #30058 [Routing] fix perf issue when dumping large number of rout…

    nicolas-grekas committed Feb 7, 2019
    …es (nicolas-grekas)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [Routing] fix perf issue when dumping large number of routes
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #29918
    | License       | MIT
    | Doc PR        | -
    
    In my reproducer, dumping 12k routes goes from 40s to 3s without xdebug, and from 50s to 12s with xdebug.
    
    There is a lower level issue which is that `strpos` is called 16M times, but that's still a lot faster than calling `preg_match` 16M times. Reducing the number of checks is certainly possible, but that would be more involving. This could happen on master if someone is up to dig into it.
    
    Commits
    -------
    
    872efe5 [Routing] fix perf issue when dumping large number of routes
  10. feature #30052 [Security] Replace serialization API (renanbr)

    nicolas-grekas committed Feb 7, 2019
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [Security] Replace serialization API
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | yes
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    New `getState()` and `setState()` methods in `AbstractToken` and `AuthenticationException` allow users to append data to the serialization payload.
    
    It allow us to have zero impact in user land when changing the serialization engine.
    
    Commits
    -------
    
    006c6dd makes serialize methods final
  11. bug #30062 [Form] do not overwrite the constraint being evaluated (xa…

    nicolas-grekas committed Feb 7, 2019
    …bbuh)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Form] do not overwrite the constraint being evaluated
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #27362
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    345a632 do not overwrite the constraint being evaluated
  12. bug #30074 Fix wrong value in file id attribute for Xliff 2.0 (deguif)

    nicolas-grekas committed Feb 7, 2019
    This PR was squashed before being merged into the 4.2 branch (closes #30074).
    
    Discussion
    ----------
    
    Fix wrong value in file id attribute for Xliff 2.0
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | ?
    | Deprecations? | no
    | Tests pass?   | ?
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Currently using the `XliffFileDumper` for exporting messages from catalogue with domain of the form `xxxx+intl-icu` produces an invalid Xliff version 2.0 file as the file id attribute is of type `xs:NMTOKEN` (cf. https://github.com/symfony/translation/blob/master/Resources/schemas/xliff-core-2.0.xsd#L139) which doesn't accept `+` character (cf. http://www.datypic.com/sc/xsd/t-xsd_NMTOKEN.html).
    Exception is thrown when loading the content after.
    
    Commits
    -------
    
    8bf12f8 Fix wrong value in file id attribute for Xliff 2.0
  13. minor #30065 [Filesystem] Fixed some docblocks and typos (samnela)

    nicolas-grekas committed Feb 7, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Filesystem] Fixed some docblocks and typos
    
    | Q             | A
    | ------------- | ---
    | Branch?       |  3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Commits
    -------
    
    972b971 [Filesystem] Fixed some docblocks and typos
  14. minor #30069 [VarDumper] Fixed phpDoc (enomotodev)

    nicolas-grekas committed Feb 7, 2019
    This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #30069).
    
    Discussion
    ----------
    
    [VarDumper] Fixed phpDoc
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    - I added it because nullable was not mentioned in phpdoc
    
    Commits
    -------
    
    506231f [VarDumper] Fixed phpDoc
  15. bug #30078 [Messenger] Fix DataCollector template (ottaviano)

    nicolas-grekas committed Feb 7, 2019
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [Messenger] Fix DataCollector template
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | ~
    | License       | MIT
    | Doc PR        | ~
    
    It's for adding a closing DIV tag on L96 (+ re-indent the HTML code)
    
    Commits
    -------
    
    146ae74 [Messenger] Fix DataCollector template
  16. bug #30087 [PhpUnitBridge] fix PHP 5.3 compat (nicolas-grekas)

    nicolas-grekas committed Feb 7, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [PhpUnitBridge] fix PHP  5.3 compat
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    ONLY FOR 3.4
    The bridge must remain compatible with PHP 5.3
    Introduced in 33a001e.
    
    Commits
    -------
    
    b45cbf6 [PhpUnitBridge] fix PHP  5.3 compat
Commits on Feb 6, 2019
  1. [PhpUnitBridge] fix PHP 5.3 compat

    nicolas-grekas committed Feb 6, 2019
Commits on Feb 1, 2019
  1. Merge branch '4.2'

    nicolas-grekas committed Feb 1, 2019
    * 4.2:
      Use system wide memcached.so
  2. Merge branch '3.4' into 4.2

    nicolas-grekas committed Feb 1, 2019
    * 3.4:
      Use system wide memcached.so