Skip to content
Permalink
Branch: master
Commits on Apr 15, 2019
  1. minor #31118 [HttpClient] fix too high timeout in test (nicolas-grekas)

    nicolas-grekas committed Apr 15, 2019
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [HttpClient] fix too high timeout in test
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    This makes tests pass without waiting for no reasons.
    
    Commits
    -------
    
    8f69954 [HttpClient] fix too high timeout in test
  2. [HttpClient] fix too high timeout in test

    nicolas-grekas committed Apr 15, 2019
  3. minor #31115 [Form] Workaround for \DateInterval::createFromDateStrin…

    nicolas-grekas committed Apr 15, 2019
    …g() (renanbr)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Form] Workaround for \DateInterval::createFromDateString()
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    This patch makes test `Symfony\Component\Form\Tests\Extension\Core\Type\DateIntervalTypeTest::testSubmitNullUsesDateEmptyData()` pass in PHP 7.2.17 and 7.3.4
    
    PHP bug reference : https://bugs.php.net/bug.php?id=77896
    
    See also : https://3v4l.org/sQjh2
    
    Commits
    -------
    
    54247ec Workaround for \DateInterval::createFromDateString()
  4. feature #30717 [Serializer] Use name converter when normalizing const…

    nicolas-grekas committed Apr 15, 2019
    …raint violation list (norkunas)
    
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [Serializer] Use name converter when normalizing constraint violation list
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master <!-- see below -->
    | Bug fix?      | no
    | New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    When using name converter with serializer and the default ConstraintViolationListNormalizer, returned propertyPaths was not converted to the same format.
    
    <!--
    Write a short README entry for your feature/bugfix here (replace this comment block.)
    This will help people understand your PR and can be used as a start of the Doc PR.
    Additionally:
     - Bug fixes must be submitted against the lowest branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    
    Commits
    -------
    
    dd93b70 Use name converter when normalizing constraint violation list
  5. minor #31047 [DoctrineBridge] [DX] Update exception text in ManagerRe…

    nicolas-grekas committed Apr 15, 2019
    …gistry to avoid confusion. (Simperfit)
    
    This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes #31047).
    
    Discussion
    ----------
    
    [DoctrineBridge] [DX] Update exception text in ManagerRegistry to avoid confusion.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yesish <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #29659   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        |
    
    <!--
    Write a short README entry for your feature/bugfix here (replace this comment block.)
    This will help people understand your PR and can be used as a start of the Doc PR.
    Additionally:
     - Bug fixes must be submitted against the lowest branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    
    Since the last PR was closed and the ticket is still open, taking it since it was already done by Nicolas in the comments.
    
    Commits
    -------
    
    9ade232 [DoctrineBridge] [DX] Update exception text in ManagerRegistry::resetService to avoid confusion.
Commits on Apr 14, 2019
  1. [FrameworkBundle] decorate the ValidatorBuilder's translator with Leg…

    nicolas-grekas committed Apr 14, 2019
    …acyTranslatorProxy
Commits on Apr 12, 2019
  1. Merge branch '4.2'

    nicolas-grekas committed Apr 12, 2019
    * 4.2:
      Skip testing the phpunit-bridge on not-master branches when $deps is empty
      more tests
      [DI] Fixes: #28326 - Overriding services autowired by name under _defaults bind not working
      [DI] fix removing non-shared definition while inlining them
  2. Merge branch '3.4' into 4.2

    nicolas-grekas committed Apr 12, 2019
    * 3.4:
      Skip testing the phpunit-bridge on not-master branches when $deps is empty
      more tests
      [DI] Fixes: #28326 - Overriding services autowired by name under _defaults bind not working
  3. minor #31095 Skip testing the phpunit-bridge on not-master branches w…

    nicolas-grekas committed Apr 12, 2019
    …hen $deps is empty (nicolas-grekas)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Skip testing the phpunit-bridge on not-master branches when $deps is empty
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Tests are not in sync with the autoloaded code on these jobs.
    The bridge is still tested on deps=low/high jobs + master
    
    Commits
    -------
    
    b0ee192 Skip testing the phpunit-bridge on not-master branches when $deps is empty
  4. [PhpUnitBridge] fix PHP 5.5 support

    nicolas-grekas committed Apr 12, 2019
  5. Skip testing the phpunit-bridge on not-master branches when $deps is …

    nicolas-grekas committed Apr 12, 2019
    …empty
  6. [PhpUnitBridge] CS fix

    nicolas-grekas committed Apr 12, 2019
  7. bug #31088 [DI] fix removing non-shared definition while inlining the…

    nicolas-grekas committed Apr 12, 2019
    …m (nicolas-grekas)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [DI] fix removing non-shared definition while inlining them
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #29628
    | License       | MIT
    | Doc PR        | -
    
    I didn't manage to create a specific test case but this still has 100% coverage for the added lines and fixed the reproducer (and makes sense also :) )
    
    Commits
    -------
    
    317e820 [DI] fix removing non-shared definition while inlining them
  8. feature #31093 [PhpUnitBridge] ClockMock does not mock gmdate() (Simp…

    nicolas-grekas committed Apr 12, 2019
    …erfit)
    
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [PhpUnitBridge] ClockMock does not mock gmdate()
    
    | Q             | A
    | ------------- | ---
    | Branch?       | feature
    | Bug fix?      | no
    | New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #30393   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#11418 <!-- required for new features -->
    
    <!--
    Write a short README entry for your feature/bugfix here (replace this comment block.)
    This will help people understand your PR and can be used as a start of the Doc PR.
    Additionally:
     - Bug fixes must be submitted against the lowest branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    Adding the feature to mock gmdate directly in ClockMock.
    
    Commits
    -------
    
    b34738b [PhpUnitBridge] ClockMock does not mock gmdate()
  9. bug #29944 [DI] Overriding services autowired by name under _defaults…

    nicolas-grekas committed Apr 12, 2019
    … bind not working (przemyslaw-bogusz, renanbr)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [DI] Overriding services autowired by name under _defaults bind not working
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #28326
    | License       | MIT
    
    This is an implementation of ideas and suggestions of @nicolas-grekas and @GuilhemN.
    
    Commits
    -------
    
    7e805ea more tests
    35a40ac [DI] Fixes: #28326 - Overriding services autowired by name under _defaults bind not working
  10. fix

    nicolas-grekas committed Apr 12, 2019
  11. Merge branch '4.2'

    nicolas-grekas committed Apr 12, 2019
    * 4.2:
      [TwigBridge] fix tests
      [FrameworkBundle] Fix Controller deprecated when using composer --optimized
  12. Merge branch '3.4' into 4.2

    nicolas-grekas committed Apr 12, 2019
    * 3.4:
      [TwigBridge] fix tests
  13. minor #31091 [TwigBridge] fix tests (nicolas-grekas)

    nicolas-grekas committed Apr 12, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [TwigBridge] fix tests
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Follows twigphp/Twig#2935
    
    Commits
    -------
    
    33c6681 [TwigBridge] fix tests
  14. bug #31094 [PhpUnitBridge] fixes (nicolas-grekas)

    nicolas-grekas committed Apr 12, 2019
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [PhpUnitBridge] fixes
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Fixes @stof's review in #29211 + fixes PHP5.5 support (array consts are PHP5.6+)
    /cc @greg0ire
    
    Commits
    -------
    
    b11585e [PhpUnitBridge] fixes
  15. [PhpUnitBridge] fixes

    nicolas-grekas committed Apr 12, 2019
  16. [TwigBridge] fix tests

    nicolas-grekas committed Apr 12, 2019
  17. [DI] fix removing non-shared definition while inlining them

    nicolas-grekas committed Apr 12, 2019
Commits on Apr 11, 2019
  1. Merge branch '4.2'

    nicolas-grekas committed Apr 11, 2019
    * 4.2:
      Catch empty deprecation.log silently (fixes #31050)
      minor: the meaning of the data breach was not correct
      Optimize SVGs
      property normalizer should also pass format and context to isAllowedAttribute
  2. Merge branch '3.4' into 4.2

    nicolas-grekas committed Apr 11, 2019
    * 3.4:
      Catch empty deprecation.log silently (fixes #31050)
  3. bug #31076 [HttpKernel] Fixed LoggerDataCollector crashing on empty f…

    nicolas-grekas committed Apr 11, 2019
    …ile (althaus)
    
    This PR was submitted for the 4.2 branch but it was merged into the 3.4 branch instead (closes #31076).
    
    Discussion
    ----------
    
    [HttpKernel] Fixed LoggerDataCollector crashing on empty file
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #31050
    | License       | MIT
    
    This PR adds a check to the LoggerDataCollector if there's acutal some content in the log file.
    
    Commits
    -------
    
    291c73a Catch empty deprecation.log silently (fixes #31050)
  4. Merge branch '3.4' into 4.2

    nicolas-grekas committed Apr 11, 2019
    * 3.4:
      minor: the meaning of the data breach was not correct
      Optimize SVGs
      property normalizer should also pass format and context to isAllowedAttribute
  5. minor #31067 Optimize SVGs (MartijnCuppens)

    nicolas-grekas committed Apr 11, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Optimize SVGs
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4 <!-- see below -->
    | Bug fix?      | yes
    | New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | /   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | / <!-- required for new features -->
    
    Used [svgo](https://github.com/svg/svgo) to optimize the svgs. I kept the `viewBox` attribute to keep the aspects when SVGs are rescaled.
    
    I also added `insert_final_newline = false` to the `.editorconfig` file because the newlines are removed from the SVGs and there's only one line left.
    
    Commits
    -------
    
    4614cea Optimize SVGs
  6. Merge branch '4.2'

    nicolas-grekas committed Apr 11, 2019
    * 4.2:
      CS Fixes: Not double split with one array argument
  7. bug #31073 #30998 Fix deprecated setCircularReferenceHandler call (dh…

    nicolas-grekas committed Apr 11, 2019
    …aarbrink)
    
    This PR was squashed before being merged into the 4.3-dev branch (closes #31073).
    
    Discussion
    ----------
    
    #30998 Fix deprecated setCircularReferenceHandler call
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #30998
    | License       | MIT
    
    Instead of calling the `setCircularReferenceHandler()` method, it puts the handler in the default context.
    
    Commits
    -------
    
    3a68040 #30998 Fix deprecated setCircularReferenceHandler call
  8. bug #31071 property normalizer should also pass format and context to…

    nicolas-grekas committed Apr 11, 2019
    … isAllowedAttribute (dbu)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    property normalizer should also pass format and context to isAllowedAttribute
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | found while working on #30888
    | License       | MIT
    | Doc PR        | -
    
    the context and format are optional parameters to `isAllowedAttribute`, but should be forwarded. due to this omission, the PropertyNormalizer was ignoring the 'attributes' context option (and does in version 4 also ignore the 'ignore_attributes' context option - that one is a property on the normalizer class in version 3 and therefore not ignored here)
    
    Commits
    -------
    
    13e2fb7 property normalizer should also pass format and context to isAllowedAttribute
  9. minor #31072 CS Fixes: Not double split with one array argument (Yuru…

    nicolas-grekas committed Apr 11, 2019
    …jai)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    CS Fixes: Not double split with one array argument
    
    | Q             | A
    | ------------- | ---
    | Branch?       |  4.2
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | none
    | License       | MIT
    | Doc PR        | none
    
    Fix for #31064 (comment)
    
    Commits
    -------
    
    93dabbc CS Fixes: Not double split with one array argument
  10. minor #31074 minor: the meaning of the data breach was not correct (S…

    nicolas-grekas committed Apr 11, 2019
    …imperfit)
    
    This PR was squashed before being merged into the 3.4 branch (closes #31074).
    
    Discussion
    ----------
    
     minor: the meaning of the data breach was not correct
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | none  <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | none <!-- required for new features -->
    
    <!--
    Write a short README entry for your feature/bugfix here (replace this comment block.)
    This will help people understand your PR and can be used as a start of the Doc PR.
    Additionally:
     - Bug fixes must be submitted against the lowest branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against the master branch.
    -->
    
    It seems that the french translation was wrong as the phrasing suggested that the data breach came from the current application/website.
    
    Changing as discussed here: #31053 (comment)
    
    Commits
    -------
    
    97ac9ba  minor: the meaning of the data breach was not correct
  11. minor #31070 [Dotenv] Improve Dotenv messages (xuanquynh)

    nicolas-grekas committed Apr 11, 2019
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [Dotenv] Improve Dotenv messages
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | no
    | Fixed tickets | no
    | License       | MIT
    | Doc PR        | no
    
    This PR improves a little bit of some messages from #31062
    
    The first, passive sentences may be more suitable here because the value couldn't change by itself. It is changed by us - human.
    
    The second, if we use **The default value of $usePutenv" argument of "%s\'s constructor**, we have to pass `__CLASS__` as the second parameter of `sprintf` function instead of `__METHOD__`. So, I suggest using **The default value of $usePutenv" argument of "%s"**.
    
    Finally, the deprecation warning of `Dotenv::__construct()` is very long. Let's separate it into 2 pieces for readable reason.
    
    Commits
    -------
    
    e871a6a Improve Dotenv messages
Older
You can’t perform that action at this time.