Skip to content
Permalink
Branch: master
Commits on May 12, 2019
  1. bug #31477 [PropertyAccess] Add missing property to PropertyAccessor …

    nicolas-grekas committed May 12, 2019
    …(vudaltsov)
    
    This PR was squashed before being merged into the 4.2 branch (closes #31477).
    
    Discussion
    ----------
    
    [PropertyAccess] Add missing property to PropertyAccessor
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    b1d3736 [PropertyAccess] Add missing property to PropertyAccessor
  2. bug #31479 [Cache] fix saving unrelated keys in recursive callback ca…

    nicolas-grekas committed May 12, 2019
    …lls (nicolas-grekas)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [Cache] fix saving unrelated keys in recursive callback calls
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #31399
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    4443c20 [Cache] fix saving unrelated keys in recursive callback calls
Commits on May 11, 2019
  1. bug #30930 [FrameworkBundle] Fixed issue when a parameter contains a …

    nicolas-grekas committed May 11, 2019
    …'%' (lyrixx)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Fixed issue when a parameter contains a '%'
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #31431
    | License       | MIT
    | Doc PR        |
    
    ---
    
    On my computer:
    ```
    dump(get_cfg_var('xdebug.file_link_format'));
    "subl://%f:%l"
    ```
    
    When I ran `bin/console debug:config framework` I got this exception:
    
    ```
    
    In ParameterBag.php line 100:
    
      [Symfony\Component\DependencyInjection\Exception\ParameterNotFoundException]
      The parameter "templating.helper.code.file_link_format" has a
    dependency on a non-existent parameter "f:".
    
    Exception trace:
     () at
    /home/gregoire/dev/github.com/lyrixx/symfony/src/Symfony/Component/DependencyInjection/ParameterBag/ParameterBag.php:100
    ...
    ```
    
    This issue was introduced [here](https://github.com/symfony/symfony/pull/27684/files#diff-b3847149480405e1de881530b4c75ab5L212) / cc @ro0NL
    
    This PR does not really fix the issue: I'm able to debug the config, The
    the `debug:container --env-vars` does not work anymore. How could we fix
    both issue? cc @nicolas-grekas
    
    Commits
    -------
    
    7bcd714 [FrameworkBundle] Fixed issue when a parameter container a '%'
  2. minor #31395 [Cache] Log a more readable message when trying to cache…

    nicolas-grekas committed May 11, 2019
    … an unsupported type (Deuchnord)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Cache] Log a more readable message when trying to cache an unsupported type
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #29710   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        |
    
    Improved the warning risen when trying to save something that has a non-supported type in the Simple cache.
    
    For instance, let's say the following code:
    ```php
    class TestCommand extends Command
    {
        private $cache;
    
        public function __construct(CacheInterface $cache)
        {
            parent::__construct();
            $this->cache = $cache;
        }
    
        // ...
    
        protected function execute(InputInterface $input, OutputInterface $output)
        {
            $n = $this->cache->get('n', function () {
                return function () {
                    return rand(0,10);
                };
            });
    
            dump($n());
        }
    }
    ```
    
    Running this code will give the following:
    ```
    14:32:03 WARNING   [cache] Could not save key "n" in cache: the Closure type is not supported.
    0
    ```
    
    Commits
    -------
    
    21ba3c0 [Cache] Log a more readable error message when saving into cache fails
  3. bug #31438 [Serializer] Fix denormalization of object with variadic c…

    nicolas-grekas committed May 11, 2019
    …onstructor typed argument (ajgarlag)
    
    This PR was squashed before being merged into the 3.4 branch (closes #31438).
    
    Discussion
    ----------
    
    [Serializer] Fix denormalization of object with variadic constructor typed argument
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4 up to 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #31436
    | License       | MIT
    
    This PR adds a test to demonstrate the bug, and a fix to squash it.
    
    Commits
    -------
    
    c8c3c56 [Serializer] Fix denormalization of object with variadic constructor typed argument
  4. bug #31445 [Messenger] Making cache rebuild correctly when message su…

    nicolas-grekas committed May 11, 2019
    …bscribers change (weaverryan)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [Messenger] Making cache rebuild correctly when message subscribers change
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #31409
    | License       | MIT
    | Doc PR        | not needed
    
    An edge-case that's identical to `EventSubscriberInterface`: when the return value of `getHandledMessages()` changes, the container needs to be rebuilt.
    
    If you're wondering why these checks aren't in their own resource class, see #25984 - it's something we probably should do, but haven't done yet.
    
    Commits
    -------
    
    d88446b Making cache rebuild correctly with MessageSubscriberInterface return values
  5. bug #31442 [Validator] Fix finding translator parent definition in co…

    nicolas-grekas committed May 11, 2019
    …mpiler pass (deguif)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [Validator] Fix finding translator parent definition in compiler pass
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Method `ChildDefintion::getParent()` returns a string, but here it is expected to return an object of class `Definition` in order to call `getClass` on it in the loop.
    
    Commits
    -------
    
    d261bb5 Fix finding parent definition
  6. bug #31475 [HttpFoundation] Allow set 'None' on samesite cookie flag …

    nicolas-grekas committed May 11, 2019
    …(markitosgv)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [HttpFoundation] Allow set 'None' on samesite cookie flag
    
    Allow set samesite cookie flag to 'None' value
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #31467
    | License       | MIT
    
    Google introduces new Chrome policy, marking all none setted samesite flag to 'Strict' by default. If you want to allow third party cookies you must set samesite flag to None.
    
    This PR fixes #31467, allow to put samesite Cookie flag to None.
    
    Commits
    -------
    
    8bac3d6 Allow set 'None' on samesite cookie flag
  7. minor #31469 [Workflow] Update WorkflowEvents typo (noniagriconomie)

    nicolas-grekas committed May 11, 2019
    This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes #31469).
    
    Discussion
    ----------
    
    [Workflow] Update WorkflowEvents typo
    
    | Q             | A
    | ------------- | ---
    | Branch?       |  <!-- see below -->
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    Some little typo
    Maybe to do for other branches?
    
    Commits
    -------
    
    6583e5a Update WorkflowEvents.php
Commits on May 9, 2019
  1. Merge branch '4.3'

    nicolas-grekas committed May 9, 2019
    * 4.3:
      [Doctrine\Bridge] fix tests
      [Intl] Revise timezone name generation
      Simplifying SyncTransport and fixing bug with handlers transport
      [DomCrawler] fix HTML5 parser integration
  2. minor #31257 [DomCrawler] fix HTML5 parser integration (nicolas-grekas)

    nicolas-grekas committed May 9, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [DomCrawler] fix HTML5 parser integration
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Spotted while reviewing #30892
    The current logic is context-dependent: by changing the order of calls, you can get different behaviors.
    
    Commits
    -------
    
    ba83bda [DomCrawler] fix HTML5 parser integration
  3. minor #31434 [Intl] Revise timezone name generation (ro0NL)

    nicolas-grekas committed May 9, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
     [Intl] Revise timezone name generation
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no
    | Tests pass?   | yes (inlcluding intl-data group)
    | Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    This is the final polishing needed for #31294 :)
    
    I've realized it's much easier to de-duplicate by processing fallback locales separate, and then only keep the diff compared to a specific locale. More or less the same approach `LocaleDataGenerator` already follows. I was trying to be clever and filter based on inheritance in a single process; bad idea.
    
    Includes ro0NL@31591d0 (ref #31432)
    
    Commits
    -------
    
    bfdb4ed [Intl] Revise timezone name generation
  4. minor #31443 [Doctrine\Bridge] fix tests (nicolas-grekas)

    nicolas-grekas committed May 9, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Doctrine\Bridge] fix tests
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Once merged, one issue will remain, which will be fixed by doctrine/dbal#3543
    
    Commits
    -------
    
    10da231 [Doctrine\Bridge] fix tests
  5. [Doctrine\Bridge] fix tests

    nicolas-grekas committed May 9, 2019
  6. Merge branch '4.3'

    nicolas-grekas committed May 9, 2019
    * 4.3:
      [Routing] Fixed unexpected 404 NoConfigurationException
      [DI] Removes number of elements information in debug mode
      [Contracts] Simplify implementation declarations
      Update PR template for 4.3
      [Intl] Add FallbackTrait for data generation
      [Console] Commands with an alias should not be recognized as ambiguous
      clarify the possible class/interface of the cache
  7. Merge branch '4.2' into 4.3

    nicolas-grekas committed May 9, 2019
    * 4.2:
      [Routing] Fixed unexpected 404 NoConfigurationException
      [DI] Removes number of elements information in debug mode
      [Contracts] Simplify implementation declarations
      Update PR template for 4.3
      [Intl] Add FallbackTrait for data generation
      [Console] Commands with an alias should not be recognized as ambiguous
      clarify the possible class/interface of the cache
  8. Merge branch '3.4' into 4.2

    nicolas-grekas committed May 9, 2019
    * 3.4:
      [DI] Removes number of elements information in debug mode
      Update PR template for 4.3
      [Intl] Add FallbackTrait for data generation
      [Console] Commands with an alias should not be recognized as ambiguous
      clarify the possible class/interface of the cache
  9. bug #31207 [Routing] Fixed unexpected 404 NoConfigurationException (y…

    nicolas-grekas committed May 9, 2019
    …ceruto)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [Routing] Fixed unexpected 404 NoConfigurationException
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #31199
    | License       | MIT
    
    This is the patch for 4.2+
    We need a different patch for 3.4 that is more complex, I think.
    
    Commits
    -------
    
    aa71a42 [Routing] Fixed unexpected 404 NoConfigurationException
  10. minor #31440 [Contracts] Simplify implementation declarations (nicola…

    nicolas-grekas committed May 9, 2019
    …s-grekas)
    
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [Contracts] Simplify implementation declarations
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Nobody but us references these for now so we let's make them simpler asap.
    
    Commits
    -------
    
    7d51da3 [Contracts] Simplify implementation declarations
  11. bug #31261 [Console] Commands with an alias should not be recognized …

    nicolas-grekas committed May 9, 2019
    …as ambiguous when using register (Simperfit)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Console] Commands with an alias should not be recognized as ambiguous when using register
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #25355
    | License       | MIT
    | Doc PR        |
    
    I think when passing an alias, it should not be treated as a ambiguous command since it's configured to response to it.
    
    I've [pushed a commit](Simperfit/symfony-reproducer@2f5209a) that reproduce the bug and with this patch it does work.
    
    Commits
    -------
    
    ae7ee46 [Console] Commands with an alias should not be recognized as ambiguous
  12. bug #31371 [DI] Removes number of elements information in debug mode …

    nicolas-grekas committed May 9, 2019
    …(jschaedl)
    
    This PR was squashed before being merged into the 3.4 branch (closes #31371).
    
    Discussion
    ----------
    
    [DI] Removes number of elements information in debug mode
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #31340
    | License       | MIT
    | Doc PR        | -
    
    With this services config:
    
    ```yaml
    my_service:
        class: stdClass
        arguments: [!tagged my_tag]
    
    my_tagged_service_1:
        class: stdClass
        tags: [my_tag]
    
    my_tagged_service_2:
        class: stdClass
        tags: [my_tag]
    ```
    Executing `./bin/console debug:container my_service --show-arguments --env=dev` resulted in
    
    ```bash
    Information for Service "my_service"
    ====================================
    
     ---------------- -------------------------
      Option           Value
     ---------------- -------------------------
      Service ID       my_service
      Class            stdClass
      Tags             -
      Public           no
      Synthetic        no
      Lazy             no
      Shared           yes
      Abstract         no
      Autowired        yes
      Autoconfigured   yes
      Arguments        Iterator (0 element(s))
     ---------------- -------------------------
    ```
     With this fix the output changed to:
    
    ```bash
    Information for Service "my_service"
    ====================================
    
     ---------------- ------------
      Option           Value
     ---------------- ------------
      Service ID       my_service
      Class            stdClass
      Tags             -
      Public           no
      Synthetic        no
      Lazy             no
      Shared           yes
      Abstract         no
      Autowired        yes
      Autoconfigured   yes
      Arguments        Tagged Iterator for "my_tag"
     ---------------- ------------
    ```
    
    and with `./bin/console debug:container my_service --show-arguments --env=prod`
    
    ```bash
    Information for Service "my_service_tagged_iterator"
    ====================================================
    
     ---------------- ---------------------------------------------
      Option           Value
     ---------------- ---------------------------------------------
      Service ID       my_service
      Class            stdClass
      Tags             -
      Public           no
      Synthetic        no
      Lazy             no
      Shared           yes
      Abstract         no
      Autowired        yes
      Autoconfigured   yes
      Arguments        Tagged Iterator for "my_tag" (2 element(s))
     ---------------- ---------------------------------------------
    ```
    
    Commits
    -------
    
    0da4b83 [DI] Removes number of elements information in debug mode
  13. bug #31418 [FrameworkBundle] clarify the possible class/interface of …

    nicolas-grekas committed May 9, 2019
    …the cache (xabbuh)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] clarify the possible class/interface of the cache
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    When the fallback cache pool is returned (on PHP 5.6, HHVM, or when
    Opcache is disabled), the configured service can be any implementation
    of the CacheItemPoolInterface.
    
    Commits
    -------
    
    4027374 clarify the possible class/interface of the cache
  14. minor #31432 [Intl] Add FallbackTrait for data generation (ro0NL)

    nicolas-grekas committed May 9, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Intl] Add FallbackTrait for data generation
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    This is the last architectural change for the Intl data compilation. Promised.
    
    It fixes de-duplicating a locale from its fallback locale. The problem is it uses a while-loop, comparing the locale to each fallback locale.
    
    Given
    
    - `root` (val=A)
      - `ur` (val=B)
        - `ur_IN` (val=A)
    
    We have an edge case where a locale (ur_IN) override its fallback locale (ur), setting/restoring the value back to the root locale. This happens for the GMT format in the timezone bundle i know of ... in this case the `ur_IN` locale needs to write its own value.
    
    The current approach is a while-loop comparing each fallback locale (ur, root) to the current locale (ur_IN). Eventually comparing `ur_IN <> root`, which causes a wrong diff, as such `ur_IN` falls back to `ur` providing the wrong value (val=B, where val=A is expected).
    
    The new approach uses recursion so we only compare `ur <> ur_IN`, where `ur_IN` on itself is compared to `root`.
    
    4.2) ro0NL@e24d8e6
    4.3) ro0NL@31591d0
    
    Commits
    -------
    
    36ddfd5 [Intl] Add FallbackTrait for data generation
  15. [Contracts] Simplify implementation declarations

    nicolas-grekas committed May 9, 2019
  16. Update PR template for 4.3

    nicolas-grekas committed May 9, 2019
Commits on May 5, 2019
  1. minor #31372 Merges second DI section into first one (jschaedl)

    nicolas-grekas committed May 5, 2019
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    Merges second DI section into first one
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | not related    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | -  <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    826237a Merges second DI section into first one
  2. bug #31380 [WebProfilerBundle] Don't filter submitted IP values (javi…

    nicolas-grekas committed May 5, 2019
    …ereguiluz)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [WebProfilerBundle] Don't filter submitted IP values
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #31378   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | -
    
    I don't think we need to filter the value submitted by users in this case.
    
    Commits
    -------
    
    29bd2ad [WebProfilerBundle] Don't filter submitted IP values
  3. bug #31382 [PhpunitBridge] Fix not unserialized logs after Deprecatio…

    nicolas-grekas committed May 5, 2019
    …nErrorHandler refacto (l-vo)
    
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [PhpunitBridge] Fix not unserialized logs after DeprecationErrorHandler refacto
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    During the refactoring for #29211 , it seems a little bug was introduced. When using runInSeparateProcess, deprecation message isn't unserialized anymore.
    
    Commits
    -------
    
    f522729 [PhpunitBridge] Fix not unserialized logs after DeprecationErrorHandler refactoring
  4. minor #31386 Translated form, security, validators resources into Bel…

    nicolas-grekas committed May 5, 2019
    …arusian (be) (vtsykun)
    
    This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #31386).
    
    Discussion
    ----------
    
    Translated form, security, validators resources into Belarusian (be)
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    3ae9de1 Translated form, security, validators resources into Belarusian (be)
  5. bug #31384 [Mailer][Messenger] Changing messenger bus id from 'messag…

    nicolas-grekas committed May 5, 2019
    …e_bus' to 'messenger.default_bus' (Koc)
    
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [Mailer][Messenger] Changing messenger bus id from 'message_bus' to 'messenger.default_bus'
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #30690
    | License       | MIT
    | Doc PR        | -
    
    Follow up of #30690
    
    Commits
    -------
    
    d3079e0 Changing messenger bus id from 'message_bus' to 'messenger.default_bus'
Commits on May 1, 2019
  1. Revert "bug #30620 [FrameworkBundle][HttpFoundation] make session ser…

    nicolas-grekas committed May 1, 2019
    …vice resettable (dmaicher)"
    
    This reverts commit 029fb2e, reversing
    changes made to 9dad29d.
You can’t perform that action at this time.