Skip to content
Permalink
Branch: 4.4
Commits on Jun 12, 2019
  1. [HttpClient] fix closing debug stream prematurely

    nicolas-grekas committed Jun 12, 2019
Commits on Jun 11, 2019
  1. feature #31976 [HttpClient] add HttplugClient for compat with libs th…

    nicolas-grekas committed Jun 11, 2019
    …at need httplug v1 or v2 (nicolas-grekas)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [HttpClient] add HttplugClient for compat with libs that need httplug v1 or v2
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Many libs still depend on httplug:
    https://packagist.org/packages/php-http/client-implementation/dependents
    
    Until they're all updated to PSR-18 or SFContracts, this PR provides an adapter for injecting a Symfony HttpClient into httplug-compatible classes, v1 or v2.
    
    Commits
    -------
    
    28674b1 [HttpClient] add HttplugClient for compat with libs that need httplug v1 or v2
  2. [HttpClient] add HttplugClient for compat with libs that need httplug…

    nicolas-grekas committed Jun 10, 2019
    … v1 or v2
  3. Merge branch '4.3' into 4.4

    nicolas-grekas committed Jun 11, 2019
    * 4.3:
      add back possibility to use form themes without translations
      [HttpClient] fix Psr18Client handling of non-200 response codes
      [WebProfilerBundle] fix FC with HttpFoundation v5
      [OptionsResolver] fix adding $triggerDeprecation to Options::offsetGet()
      [Form] test case is not legacy
      Fix reporting unsilenced deprecations from insulated tests
      fix handling nested embeddables
      Added FormInterface to @return Form::getClickedButton docblock
  4. Merge branch '4.2' into 4.3

    nicolas-grekas committed Jun 11, 2019
    * 4.2:
      [WebProfilerBundle] fix FC with HttpFoundation v5
      [OptionsResolver] fix adding $triggerDeprecation to Options::offsetGet()
      [Form] test case is not legacy
      Fix reporting unsilenced deprecations from insulated tests
      Added FormInterface to @return Form::getClickedButton docblock
  5. Merge branch '3.4' into 4.2

    nicolas-grekas committed Jun 11, 2019
    * 3.4:
      [WebProfilerBundle] fix FC with HttpFoundation v5
      [Form] test case is not legacy
      Fix reporting unsilenced deprecations from insulated tests
      Added FormInterface to @return Form::getClickedButton docblock
Commits on Jun 10, 2019
Commits on Jun 9, 2019
  1. [WebProfilerBundle] fix FC with HttpFoundation v5

    nicolas-grekas committed Jun 9, 2019
  2. bug #31962 Fix reporting unsilenced deprecations from insulated tests…

    nicolas-grekas committed Jun 9, 2019
    … (nicolas-grekas)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Fix reporting unsilenced deprecations from insulated tests
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Introduced while fixing CS in batch.
    
    Commits
    -------
    
    48093f4 Fix reporting unsilenced deprecations from insulated tests
  3. minor #31950 [OptionsResolver] fix adding $triggerDeprecation to Opti…

    nicolas-grekas committed Jun 9, 2019
    …ons::offsetGet() (nicolas-grekas)
    
    This PR was submitted for the 4.3 branch but it was merged into the 4.2 branch instead (closes #31950).
    
    Discussion
    ----------
    
    [OptionsResolver] fix adding $triggerDeprecation to Options::offsetGet()
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    This has been added by @yceruto in #28878 but it doesn't make sense to me: the interface has no concept if deprecation (`OptionsResolver` has!)
    
    Commits
    -------
    
    adc7e6a [OptionsResolver] fix adding $triggerDeprecation to Options::offsetGet()
  4. feature #31321 [DI] deprecates tag !tagged in favor of !tagged_iterat…

    nicolas-grekas committed Jun 9, 2019
    …or (jschaedl)
    
    This PR was squashed before being merged into the 4.4 branch (closes #31321).
    
    Discussion
    ----------
    
    [DI] deprecates tag !tagged in favor of !tagged_iterator
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | yes
    | Tests pass?   | yes
    | Fixed tickets | #31289
    | License       | MIT
    | Doc PR        | tbd.
    
    ### Todo
    
    - [x] fix tests
    
    Commits
    -------
    
    ab8fb18 [DI] deprecates tag !tagged in favor of !tagged_iterator
  5. [Form] test case is not legacy

    nicolas-grekas committed Jun 9, 2019
  6. Fix reporting unsilenced deprecations from insulated tests

    nicolas-grekas committed Jun 9, 2019
Commits on Jun 8, 2019
  1. [FrameworkBundle] remove dead code

    nicolas-grekas committed Jun 8, 2019
  2. [TwigBundle] fix FC with DI v5

    nicolas-grekas committed Jun 8, 2019
  3. [FrameworkBundle] fix FC with DI v5

    nicolas-grekas committed Jun 8, 2019
  4. [Config] decouple tests from DI

    nicolas-grekas committed Jun 8, 2019
  5. Merge branch '4.3' into 4.4

    nicolas-grekas committed Jun 8, 2019
    * 4.3:
      [Serializer] add missing "internal" annotation
      [DI] Fix suspicious test
      [SecurityBundle] add missing contraint for symfony/config dep
  6. [Serializer] add missing "internal" annotation

    nicolas-grekas committed Jun 8, 2019
  7. Merge branch '4.2' into 4.3

    nicolas-grekas committed Jun 8, 2019
    * 4.2:
      [DI] Fix suspicious test
      [SecurityBundle] add missing contraint for symfony/config dep
  8. minor #31944 [DI] Fix suspicious test (ro0NL)

    nicolas-grekas committed Jun 8, 2019
    This PR was merged into the 4.2 branch.
    
    Discussion
    ----------
    
    [DI] Fix suspicious test
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #31942
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    cc @nicolas-grekas
    
    Commits
    -------
    
    25b961a [DI] Fix suspicious test
Commits on Jun 7, 2019
  1. Merge branch '3.4' into 4.2

    nicolas-grekas committed Jun 7, 2019
    * 3.4:
      [SecurityBundle] add missing contraint for symfony/config dep
  2. minor #31938 [FrameworkBundle] fix FC with HttpKernel v5 (nicolas-gre…

    nicolas-grekas committed Jun 7, 2019
    …kas)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] fix FC with HttpKernel v5
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    This class is deprecated and is thus not enough a reason to conflict with http-kernel v5
    
    Should unlock #31918
    
    Commits
    -------
    
    6c109c7 [FrameworkBundle] fix FC with HttpKernel v5
  3. Merge branch '4.3' into 4.4

    nicolas-grekas committed Jun 7, 2019
    * 4.3:
      Fixing bug where PropertyInfoLoader tried to add validation to non-existent properties
      [TwigBundle] fix tests
      [travis] increase concurrency
  4. minor #31941 [TwigBundle] fix tests (nicolas-grekas)

    nicolas-grekas committed Jun 7, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [TwigBundle] fix tests
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Should make master back to green.
    
    Commits
    -------
    
    5b29918 [TwigBundle] fix tests
  5. bug #31936 PropertyInfoLoader should not try to add validation to non…

    nicolas-grekas committed Jun 7, 2019
    …-existent property (weaverryan)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    PropertyInfoLoader should not try to add validation to non-existent property
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #31796 (see #31796 (comment))
    | License       | MIT
    | Doc PR        | not needed
    
    With auto-validation, if a class has a setter (e.g. `setFoo()`) but there is no `foo` property, it still tries to add validation to that property, resulting in a:
    
    > Property "foo" does not exist in class "App\Entity\Bar
    
    This fixes that. I believe it's "just this simple", but I don't have any experience with the code in this area yet.
    
    Cheers!
    
    Commits
    -------
    
    b702598 Fixing bug where PropertyInfoLoader tried to add validation to non-existent properties
  6. Merge branch '4.2' into 4.3

    nicolas-grekas committed Jun 7, 2019
    * 4.2:
      [travis] increase concurrency
  7. Merge branch '3.4' into 4.2

    nicolas-grekas committed Jun 7, 2019
    * 3.4:
      [travis] increase concurrency
  8. minor #31939 [travis] increase concurrency (nicolas-grekas)

    nicolas-grekas committed Jun 7, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [travis] increase concurrency
    
    just a try to see if this makes the CI faster
    
    Commits
    -------
    
    5e1ffb8 [travis] increase concurrency
  9. [TwigBundle] fix tests

    nicolas-grekas committed Jun 7, 2019
  10. [travis] increase concurrency

    nicolas-grekas committed Jun 7, 2019
  11. [FrameworkBundle] fix FC with HttpKernel v5

    nicolas-grekas committed Jun 7, 2019
Older
You can’t perform that action at this time.