Skip to content
Permalink
Branch: 4.4
Commits on Aug 13, 2019
  1. [DI] fix docblocks in Container*

    nicolas-grekas committed Aug 13, 2019
  2. feature #33137 [DI] deprecate support for non-object services (nicola…

    nicolas-grekas committed Aug 13, 2019
    …s-grekas)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [DI] deprecate support for non-object services
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #32411
    | License       | MIT
    | Doc PR        | -
    
    Follows #32432 /cc @derrabus
    Prepares for adding the `?object` return-type on master.
    
    Commits
    -------
    
    7c01c4c [DI] deprecate support for non-object services
  3. feature #32845 [HttpKernel][FrameworkBundle] Add alternative conventi…

    nicolas-grekas committed Aug 13, 2019
    …on for bundle directories (yceruto)
    
    This PR was squashed before being merged into the 4.4 branch (closes #32845).
    
    Discussion
    ----------
    
    [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #32453
    | License       | MIT
    | Doc PR        | TODO
    
    We already know that bundles must be compatible with many Symfony's versions, so it is very likely that current bundles won't be able to use this feature soon, unless they create symbolic links to support both structures.
    
    The point is that this is already happening, so in the future when our bundles stop to support <=4.3 then you'll be sure to change the current directory structure.
    
    We have recently added the `getPublicDir()` method in #31975, here I'm removing it in favor of hardcoding a new convention.
    
    I've added some functional tests in which I've changed everything to this structure:
    ```
    -- ModernBundle
       |-- config/
       |-- public/
       |-- src/
           |-- ModernBundle.php
       |-- templates/
       |-- translations/
    ```
    WDYT?
    
    Commits
    -------
    
    6996e1c [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories
  4. [DI] deprecate support for non-object services

    nicolas-grekas committed Aug 13, 2019
  5. feature #32548 [Translation] XliffLintCommand: allow .xliff file exte…

    nicolas-grekas committed Aug 13, 2019
    …nsion (codegain)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Translation] XliffLintCommand: allow .xliff file extension
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | License       | MIT
    
    I ran into a problem with XLIFF files having an *.xliff extension and a "target-language" attribute.
    The command always outputted: There is a mismatch between the language included in the file name and the value used used in the "target-language" attribute of the file.
    
    The "target-language" attribute was set to "en" and the filename was also "menu.en.xliff".
    After reading the source code, I realized that this regex does not respect other valied file extensions such as "xliff" for these files and therefore throws this (rather confusing) error.
    
    Commits
    -------
    
    dba6a21 [Translation] XliffLintCommand: allow .xliff file extension
  6. minor #33132 [Form] Add type declarations to private DefaultChoiceLis…

    nicolas-grekas committed Aug 13, 2019
    …tFactory methods (vudaltsov)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Form] Add type declarations to private DefaultChoiceListFactory methods
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    These are the type declarations that can be safely added to private methods of the `DefaultChoiceListFactory` without breaking BC.
    
    Commits
    -------
    
    9fc6ba6 Add type declarations to private DefaultChoiceListFactory methods
  7. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 13, 2019
    * 4.3:
      cs fix
      Fix return statements
      [TwigBridge] add missing dep
      Add false type to ChoiceListFactoryInterface::createView $label argument
      Update UPGRADE guide of 4.3 for EventDispatcher
      [SecurityBundle] display the correct class name on the deprecated notice
  8. cs fix

    nicolas-grekas committed Aug 13, 2019
  9. minor #33115 [4.3] Update UPGRADE guide of 4.3 for EventDispatcher (a…

    nicolas-grekas committed Aug 13, 2019
    …lexislefebvre)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [4.3] Update UPGRADE guide of 4.3 for EventDispatcher
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | no
    | License       | MIT
    | Doc PR        | no
    
    I updated `UPGRADE-4.3.md` to ease upgrading `EventDispatcher` to 4.3, related changes were introduced in #28920
    
    This code is used in Symfony: https://github.com/symfony/symfony/blob/f8302262714674e3efbd775c9b107294d89fb77e/src/Symfony/Component/Security/Guard/GuardAuthenticatorHandler.php#L49
    
    Thanks to @nicolas-grekas for the hint: 75369da#r34480203
    
    Commits
    -------
    
    8b9b39d Update UPGRADE guide of 4.3 for EventDispatcher
  10. bug #33126 [SecurityBundle] display the correct class name on the dep…

    nicolas-grekas committed Aug 13, 2019
    …recated notice (maxhelias)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [SecurityBundle] display the correct class name on the deprecated notice
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3 <!-- see below -->
    | Bug fix?      | yes
    | New feature?  |no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | -  <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | - <!-- required for new features -->
    
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/roadmap):
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against branch 4.4.
     - Legacy code removals go to the master branch.
    -->
    
    Commits
    -------
    
    8e64b9a [SecurityBundle] display the correct class name on the deprecated notice
  11. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 13, 2019
    * 3.4:
      Fix return statements
      [TwigBridge] add missing dep
      Add false type to ChoiceListFactoryInterface::createView $label argument
  12. minor #33130 Fix return statements (nicolas-grekas)

    nicolas-grekas committed Aug 13, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Fix return statements
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Discovered while working on #30323
    This will sync the code from 3.4 up to master, where adding return types will require these.
    
    Commits
    -------
    
    2bc05c8 Fix return statements
  13. Fix return statements

    nicolas-grekas committed Aug 12, 2019
  14. minor #33131 [Form] Add bool type to ChoiceListFactoryInterface::crea…

    nicolas-grekas committed Aug 13, 2019
    …teView $label argument (vudaltsov)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Form] Add bool type to ChoiceListFactoryInterface::createView $label argument
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Replaces #33074
    Ping @nicolas-grekas , @Tobion , @yceruto .
    
    Commits
    -------
    
    8f5d1ca Add false type to ChoiceListFactoryInterface::createView $label argument
Commits on Aug 12, 2019
  1. feature #33122 [WebLink] implement PSR-13 directly (nicolas-grekas)

    nicolas-grekas committed Aug 12, 2019
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [WebLink] implement PSR-13 directly
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Implementing PSR-13 is simple enough and the repo we're using is [freezed](https://github.com/php-fig/link-util/pulls).
    
    This also allows us to add some type declarations. We're going to need them before merging #30323.
    
    Commits
    -------
    
    b570ee1 [WebLink] implement PSR-13 directly
  2. [WebLink] implement PSR-13 directly

    nicolas-grekas committed Aug 12, 2019
  3. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 12, 2019
    * 4.3:
      [Form] fix return type on FormDataCollector
      [Cache][DI] cleanup
  4. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 12, 2019
    * 3.4:
      [Form] fix return type on FormDataCollector
  5. minor #33120 [Form] fix return type on FormDataCollector (maxhelias)

    nicolas-grekas committed Aug 12, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Form] fix return type on FormDataCollector
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master <!-- see below -->
    | Bug fix?      | yes
    | New feature?  |no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | -   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | - <!-- required for new features -->
    
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/roadmap):
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against branch 4.4.
     - Legacy code removals go to the master branch.
    -->
    
    Commits
    -------
    
    de6b9ef [Form] fix return type on FormDataCollector
  6. [Cache][DI] cleanup

    nicolas-grekas committed Aug 12, 2019
Commits on Aug 11, 2019
  1. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 11, 2019
    * 4.3:
      [HttpFoundation] fix typo
  2. [HttpFoundation] fix typo

    nicolas-grekas committed Aug 11, 2019
  3. minor #33112 [HttpFoundation] some cleanups (azjezz)

    nicolas-grekas committed Aug 11, 2019
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [HttpFoundation] some cleanups
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    As found by @azjezz in #33088
    
    Commits
    -------
    
    f62a3c0 [HttpFoundation] some cleanups
Commits on Aug 10, 2019
  1. Revert "bug #33092 [DependencyInjection] Improve an exception message…

    nicolas-grekas committed Aug 10, 2019
    … (fabpot)"
    
    This reverts commit 2f2d1aa, reversing
    changes made to 07cf927.
  2. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 10, 2019
    * 4.3:
      Bump minimal requirements
  3. minor #33094 Bump minimal requirements (jderusse)

    nicolas-grekas committed Aug 10, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    Bump minimal requirements
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? |
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Follow up #33079 Fix failures with lowest requirements in branch 4.3
    
    Commits
    -------
    
    c874d3b Bump minimal requirements
  4. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 10, 2019
    * 4.3:
      cleanups
      Disable PHPUnit result cache on the CI
      [Security] Cleanup "Digest nonce has expired." translation
      [Translation] Highlight invalid translation status
      Added translations in validator for Serbian Cyrillic
      Added translations in validator for Serbian Latin
      [EventDispatcher] wrong Request class
      [DependencyInjection] improved exception message
  5. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 10, 2019
    * 3.4:
      cleanups
      Disable PHPUnit result cache on the CI
      [Translation] Highlight invalid translation status
  6. cleanups

    nicolas-grekas committed Aug 10, 2019
  7. minor #33110 Disable PHPUnit result cache on the CI (nicolas-grekas)

    nicolas-grekas committed Aug 10, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Disable PHPUnit result cache on the CI
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    We don't need it and disabling it works around the segfault on 4.3
    
    Commits
    -------
    
    912d7db Disable PHPUnit result cache on the CI
  8. Disable PHPUnit result cache on the CI

    nicolas-grekas committed Aug 10, 2019
Commits on Aug 9, 2019
  1. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 9, 2019
    * 4.3:
      Bump minimal requirements
      Use PHPUnit 8.3 on Travis when possible
  2. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 9, 2019
    * 3.4:
      Bump minimal requirements
      Use PHPUnit 8.3 on Travis when possible
  3. minor #33079 Use PHPUnit 8.3 on Travis when possible (nicolas-grekas,…

    nicolas-grekas committed Aug 9, 2019
    … jderusse)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Use PHPUnit 8.3 on Travis when possible
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Followup #33072 to fix dependency resolution
    
    Commits
    -------
    
    41d94c3 Bump minimal requirements
    de5256b Use PHPUnit 8.3 on Travis when possible
Older
You can’t perform that action at this time.