Skip to content
Permalink
Branch: 4.4
Commits on Aug 14, 2019
  1. feature #30323 [ErrorHandler] trigger deprecation in DebugClassLoader…

    nicolas-grekas committed Aug 14, 2019
    … when child class misses a return type (fancyweb, nicolas-grekas)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [ErrorHandler] trigger deprecation in DebugClassLoader when child class misses a return type
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #30123
    | License       | MIT
    | Doc PR        | TODO
    
    I wanted to push something to show the advancement and get feedback.
    
    I pushed two versions : one with dedicated functions for code clarity (DebugClassLoader.php) and one withtout (DebugClassLoader___.php). It would be nice if some people with Blackfire could compare the performances.
    
    So let's be clear, we are never gonna be able to cover all cases! We can however cover the vast majority.
    
    Current non covered cases and problems :
    - We assume that if there is more than 2 returned types, we cannot do anything. Even if it could technically be possible.
    - We assume that any returned type that doesn't fit our "returnable" types list is a class. We don't check at all if this class actualy exists.
    - We don't handle spaces in types. The types stop at the first space.
    - That means we don't handle (yet) the callable type with spaces (cf #29969)
    - Vendor code extending other vendor core triggers the deprecations 😕
    
    Commits
    -------
    
    aa338c8 Import return annotations from vendors
    10fc13e [ErrorHandler] Handle return types in DebugClassLoader
  2. Import return annotations from vendors

    nicolas-grekas committed Aug 12, 2019
  3. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 14, 2019
    * 4.3:
      cs fix
  4. cs fix

    nicolas-grekas committed Aug 14, 2019
  5. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 14, 2019
    * 4.3:
      Remove superfluous phpdoc tags
  6. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 14, 2019
    * 3.4:
      Remove superfluous phpdoc tags
  7. minor #33151 Remove superfluous phpdoc tags (Philippe Segatori)

    nicolas-grekas committed Aug 14, 2019
    This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #33151).
    
    Discussion
    ----------
    
    Remove superfluous phpdoc tags
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | ...
    | License       | MIT
    
    As Symfony is moving towards type hinted code, this PR is attempting to remove the now superfluous annotations
    
    See #33150 to make this cleaning as an automatic process
    
    Commits
    -------
    
    608e23c Remove superfluous phpdoc tags
  8. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 14, 2019
    * 4.3:
      cs fix
      Partially Revert "Remove trailing space in all markdown files"
      [Intl] Explicit check
      Fix getMaxFilesize() returning zero
      [DI] fix docblocks in Container*
      Fixed markdown file
      [TwigBridge] Replaced plain doc block copies with inheritdoc.
      [DomCrawler] Fixed CHANGELOG markup
      [Intl] Cleanup unused language aliases entry
  9. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 14, 2019
    * 3.4:
      cs fix
      Partially Revert "Remove trailing space in all markdown files"
      [Intl] Explicit check
      Fix getMaxFilesize() returning zero
      [DI] fix docblocks in Container*
      Fixed markdown file
      [TwigBridge] Replaced plain doc block copies with inheritdoc.
      [Intl] Cleanup unused language aliases entry
  10. minor #33158 [Intl] Explicit check (ro0NL)

    nicolas-grekas committed Aug 14, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Intl] Explicit check
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    This avoids a little conflict with #33140
    
    data is not impacted (today), but i like to make our data selection as explicit as possible and avoid ever pulling in `deprecated` or e.g. `legacy` languages.
    
    Commits
    -------
    
    fbd4ce4 [Intl] Explicit check
  11. cs fix

    nicolas-grekas committed Aug 14, 2019
  12. minor #33160 Partially Revert "Remove trailing space in all markdown …

    nicolas-grekas committed Aug 14, 2019
    …files" (lyrixx)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Partially Revert "Remove trailing space in all markdown files"
    
    This reverts commit 5a3c198.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #33142
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    2aec7df Partially Revert "Remove trailing space in all markdown files"
  13. minor #33149 [DI] fix docblocks in Container* (nicolas-grekas)

    nicolas-grekas committed Aug 14, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [DI] fix docblocks in Container*
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Backport from master.
    Internally, services can be of any kind, but only `object|null` is allowed for public services.
    
    Commits
    -------
    
    8e4d08f [DI] fix docblocks in Container*
Commits on Aug 13, 2019
  1. [DI] fix docblocks in Container*

    nicolas-grekas committed Aug 13, 2019
  2. feature #33137 [DI] deprecate support for non-object services (nicola…

    nicolas-grekas committed Aug 13, 2019
    …s-grekas)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [DI] deprecate support for non-object services
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #32411
    | License       | MIT
    | Doc PR        | -
    
    Follows #32432 /cc @derrabus
    Prepares for adding the `?object` return-type on master.
    
    Commits
    -------
    
    7c01c4c [DI] deprecate support for non-object services
  3. feature #32845 [HttpKernel][FrameworkBundle] Add alternative conventi…

    nicolas-grekas committed Aug 13, 2019
    …on for bundle directories (yceruto)
    
    This PR was squashed before being merged into the 4.4 branch (closes #32845).
    
    Discussion
    ----------
    
    [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #32453
    | License       | MIT
    | Doc PR        | TODO
    
    We already know that bundles must be compatible with many Symfony's versions, so it is very likely that current bundles won't be able to use this feature soon, unless they create symbolic links to support both structures.
    
    The point is that this is already happening, so in the future when our bundles stop to support <=4.3 then you'll be sure to change the current directory structure.
    
    We have recently added the `getPublicDir()` method in #31975, here I'm removing it in favor of hardcoding a new convention.
    
    I've added some functional tests in which I've changed everything to this structure:
    ```
    -- ModernBundle
       |-- config/
       |-- public/
       |-- src/
           |-- ModernBundle.php
       |-- templates/
       |-- translations/
    ```
    WDYT?
    
    Commits
    -------
    
    6996e1c [HttpKernel][FrameworkBundle] Add alternative convention for bundle directories
  4. [DI] deprecate support for non-object services

    nicolas-grekas committed Aug 13, 2019
  5. feature #32548 [Translation] XliffLintCommand: allow .xliff file exte…

    nicolas-grekas committed Aug 13, 2019
    …nsion (codegain)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Translation] XliffLintCommand: allow .xliff file extension
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | License       | MIT
    
    I ran into a problem with XLIFF files having an *.xliff extension and a "target-language" attribute.
    The command always outputted: There is a mismatch between the language included in the file name and the value used used in the "target-language" attribute of the file.
    
    The "target-language" attribute was set to "en" and the filename was also "menu.en.xliff".
    After reading the source code, I realized that this regex does not respect other valied file extensions such as "xliff" for these files and therefore throws this (rather confusing) error.
    
    Commits
    -------
    
    dba6a21 [Translation] XliffLintCommand: allow .xliff file extension
  6. minor #33132 [Form] Add type declarations to private DefaultChoiceLis…

    nicolas-grekas committed Aug 13, 2019
    …tFactory methods (vudaltsov)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Form] Add type declarations to private DefaultChoiceListFactory methods
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    These are the type declarations that can be safely added to private methods of the `DefaultChoiceListFactory` without breaking BC.
    
    Commits
    -------
    
    9fc6ba6 Add type declarations to private DefaultChoiceListFactory methods
  7. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 13, 2019
    * 4.3:
      cs fix
      Fix return statements
      [TwigBridge] add missing dep
      Add false type to ChoiceListFactoryInterface::createView $label argument
      Update UPGRADE guide of 4.3 for EventDispatcher
      [SecurityBundle] display the correct class name on the deprecated notice
  8. cs fix

    nicolas-grekas committed Aug 13, 2019
  9. minor #33115 [4.3] Update UPGRADE guide of 4.3 for EventDispatcher (a…

    nicolas-grekas committed Aug 13, 2019
    …lexislefebvre)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [4.3] Update UPGRADE guide of 4.3 for EventDispatcher
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | no
    | License       | MIT
    | Doc PR        | no
    
    I updated `UPGRADE-4.3.md` to ease upgrading `EventDispatcher` to 4.3, related changes were introduced in #28920
    
    This code is used in Symfony: https://github.com/symfony/symfony/blob/f8302262714674e3efbd775c9b107294d89fb77e/src/Symfony/Component/Security/Guard/GuardAuthenticatorHandler.php#L49
    
    Thanks to @nicolas-grekas for the hint: 75369da#r34480203
    
    Commits
    -------
    
    8b9b39d Update UPGRADE guide of 4.3 for EventDispatcher
  10. bug #33126 [SecurityBundle] display the correct class name on the dep…

    nicolas-grekas committed Aug 13, 2019
    …recated notice (maxhelias)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [SecurityBundle] display the correct class name on the deprecated notice
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3 <!-- see below -->
    | Bug fix?      | yes
    | New feature?  |no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | -  <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | - <!-- required for new features -->
    
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/roadmap):
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against branch 4.4.
     - Legacy code removals go to the master branch.
    -->
    
    Commits
    -------
    
    8e64b9a [SecurityBundle] display the correct class name on the deprecated notice
  11. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 13, 2019
    * 3.4:
      Fix return statements
      [TwigBridge] add missing dep
      Add false type to ChoiceListFactoryInterface::createView $label argument
  12. minor #33130 Fix return statements (nicolas-grekas)

    nicolas-grekas committed Aug 13, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Fix return statements
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Discovered while working on #30323
    This will sync the code from 3.4 up to master, where adding return types will require these.
    
    Commits
    -------
    
    2bc05c8 Fix return statements
  13. Fix return statements

    nicolas-grekas committed Aug 12, 2019
  14. minor #33131 [Form] Add bool type to ChoiceListFactoryInterface::crea…

    nicolas-grekas committed Aug 13, 2019
    …teView $label argument (vudaltsov)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Form] Add bool type to ChoiceListFactoryInterface::createView $label argument
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Replaces #33074
    Ping @nicolas-grekas , @Tobion , @yceruto .
    
    Commits
    -------
    
    8f5d1ca Add false type to ChoiceListFactoryInterface::createView $label argument
Commits on Aug 12, 2019
  1. feature #33122 [WebLink] implement PSR-13 directly (nicolas-grekas)

    nicolas-grekas committed Aug 12, 2019
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [WebLink] implement PSR-13 directly
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Implementing PSR-13 is simple enough and the repo we're using is [freezed](https://github.com/php-fig/link-util/pulls).
    
    This also allows us to add some type declarations. We're going to need them before merging #30323.
    
    Commits
    -------
    
    b570ee1 [WebLink] implement PSR-13 directly
  2. [WebLink] implement PSR-13 directly

    nicolas-grekas committed Aug 12, 2019
  3. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 12, 2019
    * 4.3:
      [Form] fix return type on FormDataCollector
      [Cache][DI] cleanup
  4. Merge branch '3.4' into 4.3

    nicolas-grekas committed Aug 12, 2019
    * 3.4:
      [Form] fix return type on FormDataCollector
  5. minor #33120 [Form] fix return type on FormDataCollector (maxhelias)

    nicolas-grekas committed Aug 12, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Form] fix return type on FormDataCollector
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master <!-- see below -->
    | Bug fix?      | yes
    | New feature?  |no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | -   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | - <!-- required for new features -->
    
    <!--
    Replace this notice by a short README for your feature/bugfix. This will help people
    understand your PR and can be used as a start for the documentation.
    
    Additionally (see https://symfony.com/roadmap):
     - Bug fixes must be submitted against the lowest maintained branch where they apply
       (lowest branches are regularly merged to upper ones so they get the fixes too).
     - Features and deprecations must be submitted against branch 4.4.
     - Legacy code removals go to the master branch.
    -->
    
    Commits
    -------
    
    de6b9ef [Form] fix return type on FormDataCollector
  6. [Cache][DI] cleanup

    nicolas-grekas committed Aug 12, 2019
Commits on Aug 11, 2019
  1. Merge branch '4.3' into 4.4

    nicolas-grekas committed Aug 11, 2019
    * 4.3:
      [HttpFoundation] fix typo
Older
You can’t perform that action at this time.