Skip to content
Permalink
Branch: 4.4
Commits on Sep 11, 2019
  1. Merge branch '4.3' into 4.4

    nicolas-grekas committed Sep 11, 2019
    * 4.3:
      Re-enable push support for HttpClient
      [DependencyInjection] Accept existing interfaces as valid named args
      Fixed incompatibility between ServiceSubscriberTrait and classes with protected $container property
  2. bug #33546 [DependencyInjection] Accept existing interfaces as valid …

    nicolas-grekas committed Sep 11, 2019
    …named args (fancyweb)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [DependencyInjection] Accept existing interfaces as valid named args
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | #33531
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    6612e9a [DependencyInjection] Accept existing interfaces as valid named args
  3. bug #33547 [HttpClient] Re-enable Server Push support (dunglas)

    nicolas-grekas committed Sep 11, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [HttpClient] Re-enable Server Push support
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tickets       | n/a <!-- prefix each issue number with "Fix #", if any -->
    | License       | MIT
    | Doc PR        | n/a
    
     #33444 disabled Server Push support for the CURL implementation, but `HttpClient::create()` has been forgotten and override this parameter, consequently for most users Server Push wasn't disabled at all. The root issue affecting the tests are actually a misconfiguration of Akamai servers (we need our own test infrastructure).
    
    According to my testing, Server Push support works very smoothly. Also, it can cause problems only if the server actually pushes responses (which is still rare).
    
    So I propose to re-enable Push Support everywhere.
    
    Commits
    -------
    
    8483842 Re-enable push support for HttpClient
Commits on Sep 10, 2019
  1. minor #33541 [DI] cascade preloading only to public parameters/proper…

    nicolas-grekas committed Sep 10, 2019
    …ties (nicolas-grekas)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [DI] cascade preloading only to public parameters/properties
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    This removes `ContaierBuilder`, `RouteCollectionBuilder`, etc. coming from `App\Kernel`
    
    Commits
    -------
    
    0e3ea8f [DI] cascade preloading only to public parameters/properties
  2. [DI] cascade preloading only to public parameters/properties

    nicolas-grekas committed Sep 10, 2019
  3. Merge branch '4.3' into 4.4

    nicolas-grekas committed Sep 10, 2019
    * 4.3:
      Update GitHub PR template
      don't dump a scalar tag value on its own line
  4. Merge branch '3.4' into 4.3

    nicolas-grekas committed Sep 10, 2019
    * 3.4:
      Update GitHub PR template
      don't dump a scalar tag value on its own line
  5. bug #33532 [HttpKernel] fix compat with legacy DebugClassLoader (nico…

    nicolas-grekas committed Sep 10, 2019
    …las-grekas)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [HttpKernel] fix compat with legacy DebugClassLoader
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    73198c6 [HttpKernel] fix compat with legacy DebugClassLoader
  6. minor #33537 Update GitHub PR template (nicolas-grekas)

    nicolas-grekas committed Sep 10, 2019
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Update GitHub PR template
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    0d03481 Update GitHub PR template
  7. Update GitHub PR template

    nicolas-grekas committed May 29, 2019
  8. bug #33539 [DI] fix related to preloading (nicolas-grekas)

    nicolas-grekas committed Sep 10, 2019
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [DI] fix related to preloading
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    e25c595 [DI] fix related to preloading
  9. [DI] fix related to preloading

    nicolas-grekas committed Sep 10, 2019
  10. [HttpKernel] fix compat with legacy DebugClassLoader

    nicolas-grekas committed Sep 10, 2019
  11. minor #33529 [DI] use dirname() when possible (nicolas-grekas)

    nicolas-grekas committed Sep 10, 2019
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [DI] use dirname() when possible
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    On second look, I think this works :)
    
    Commits
    -------
    
    2eae300 [DI] use dirname() when possible
  12. [DI] use dirname() when possible

    nicolas-grekas committed Sep 10, 2019
  13. [DI] fix Preloader

    nicolas-grekas committed Sep 10, 2019
  14. [HttpClient] fix calling the buffer-enabling callback

    nicolas-grekas committed Sep 10, 2019
  15. [HttpClient] fix php notice on push

    nicolas-grekas committed Sep 10, 2019
Commits on Sep 9, 2019
  1. minor #33512 [HttpClient] do not perform string operations on null (x…

    nicolas-grekas committed Sep 9, 2019
    …abbuh)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [HttpClient] do not perform string operations on null
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    600bde9 do not perform string operations on null
  2. feature #32565 [HttpClient] Allow enabling buffering conditionally wi…

    nicolas-grekas committed Sep 9, 2019
    …th a Closure (rjwebdev)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [HttpClient] Allow enabling buffering conditionally with a Closure
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #31883
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#12043
    
    With this PR, responses can be buffered automatically from a closure passed to the `buffer` option.
    
    ```php
    $resp = $client->request('GET', $url, [
        'buffer' => function (array $headers): bool { return true/false; },
    ]);
    ```
    
    When no option is provided, buffering is now enabled only for json, xml and text/* content types.
    
    Commits
    -------
    
    f705ac9 [HttpClient] Allow enabling buffering conditionally with a Closure
  3. minor #33508 [Cache] Add types to constructors and private/final/inte…

    nicolas-grekas committed Sep 9, 2019
    …rnal methods (derrabus)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Cache] Add types to constructors and private/final/internal methods
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #32179, #33228
    | License       | MIT
    | Doc PR        | N/A
    
    I'm currently preparing a large PR collecting changes like these. However, the changeset for the Cache component was large enough to justify a dedicated PR, imho.
    
    Commits
    -------
    
    919afd2 [Cache] Add types to constructors and private/final/internal methods.
  4. Require exact match when reading from stdin with a dash

    nicolas-grekas committed Sep 9, 2019
Commits on Sep 8, 2019
  1. Merge branch '4.3' into 4.4

    nicolas-grekas committed Sep 8, 2019
    * 4.3:
      SCA: minor code tweaks
      [HttpClient] fallbackto CURLMOPT_MAXCONNECTS when CURLMOPT_MAX_HOST_CONNECTIONS is not available
      fixed typo
      [HttpKernel] Fix Apache mod_expires Session Cache-Control issue
      Fix getFileLinkFormat() to avoid returning the wrong URL in Profiler
  2. Merge branch '3.4' into 4.3

    nicolas-grekas committed Sep 8, 2019
    * 3.4:
      SCA: minor code tweaks
      [HttpKernel] Fix Apache mod_expires Session Cache-Control issue
      Fix getFileLinkFormat() to avoid returning the wrong URL in Profiler
  3. minor #33410 [HttpFoundation] Add types to private/final/internal met…

    nicolas-grekas committed Sep 8, 2019
    …hods and constructors (derrabus)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [HttpFoundation] Add types to private/final/internal methods and constructors
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #32179, #33228
    | License       | MIT
    | Doc PR        | N/A
    
    Commits
    -------
    
    1978d88 [HttpFoundation] Add types to private/final/internal methods and constructors.
  4. minor #33506 [appveyor] exclude tty group (nicolas-grekas)

    nicolas-grekas committed Sep 8, 2019
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [appveyor] exclude tty group
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Tests on appveyor block and are killed after 1h... This might be the fix.
    
    Commits
    -------
    
    beb7ed3 [appveyor] exclude tty group
  5. minor #33266 [DependencyInjection] Add types to private/final/interna…

    nicolas-grekas committed Sep 8, 2019
    …l methods and constructors (derrabus)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [DependencyInjection] Add types to private/final/internal methods and constructors
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #32179, #33228
    | License       | MIT
    | Doc PR        | NA/
    
    Commits
    -------
    
    def0ac7 Add types to private/final/internal methods and constructors.
  6. [appveyor] exclude tty group

    nicolas-grekas committed Sep 8, 2019
  7. [HttpClient] fallbackto CURLMOPT_MAXCONNECTS when CURLMOPT_MAX_HOST_C…

    nicolas-grekas committed Sep 8, 2019
    …ONNECTIONS is not available
  8. [DI] generate preload.php file for PHP 7.4 in cache folder

    nicolas-grekas committed Jun 13, 2019
Commits on Sep 7, 2019
  1. [VarDumper] display ellipsed FQCN for nested classes

    nicolas-grekas committed Sep 7, 2019
Commits on Sep 6, 2019
  1. minor #33495 [SecurityBundle] Removed workaround introduced in 4.3 (y…

    nicolas-grekas committed Sep 6, 2019
    …ceruto)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [SecurityBundle] Removed workaround introduced in 4.3
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Cleanup of #33479
    
    Commits
    -------
    
    d14aaf6 Removed workaround introduced in 4.3
  2. minor #33482 fix tests mocking final events (Tobion)

    nicolas-grekas committed Sep 6, 2019
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    fix tests mocking final events
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        |
    
    Fix tests in 4.4 extracted from #33297
    
    Commits
    -------
    
    637461f fix tests mocking final events
  3. minor #33492 [MonologBridge] Bump min version for monolog ^1.25 and d…

    nicolas-grekas committed Sep 6, 2019
    …rop dead code (lyrixx)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [MonologBridge] Bump min version for monolog ^1.25 and drop dead code
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    1e19c65 [MonologBridge] Bump min version for monolog ^1.25 and drop dead code
  4. minor #33490 [Bridge/Twig] use tty group on testLintDefaultPaths (nic…

    nicolas-grekas committed Sep 6, 2019
    …olas-grekas)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Bridge/Twig] use tty group on testLintDefaultPaths
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #33446 (comment)
    | License       | MIT
    | Doc PR        | -
    
    Note that I still think we should deprecate reading from STDIN when not explicitly asked for, as explained in #33446 (comment)
    
    Commits
    -------
    
    3c59bb5 [Bridge/Twig] use tty group on testLintDefaultPaths
Older
You can’t perform that action at this time.