Skip to content
Permalink
Branch: 4.4
Commits on Oct 9, 2019
  1. [Cache] ignore unserialization failures in AbstractTagAwareAdapter::d…

    nicolas-grekas committed Oct 9, 2019
    …oDelete()
  2. cs fix

    nicolas-grekas committed Oct 9, 2019
  3. Merge branch '4.3' into 4.4

    nicolas-grekas committed Oct 9, 2019
    * 4.3:
      [Validator] sync NO and NB translations
  4. Merge branch '3.4' into 4.3

    nicolas-grekas committed Oct 9, 2019
    * 3.4:
      [Validator] sync NO and NB translations
  5. [Validator] sync NO and NB translations

    nicolas-grekas committed Oct 9, 2019
  6. bug #33921 [Cache] improve perf of pruning for fs-based adapters (nic…

    nicolas-grekas committed Oct 9, 2019
    …olas-grekas)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Cache] improve perf of pruning for fs-based adapters
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix #32701
    | License       | MIT
    | Doc PR        | -
    
    Thank you [Blackfire.io](https://blackfire.io)
    
    https://blackfire.io/profiles/compare/8044c3cf-1541-4a24-9804-5670c63fcb4c/graph
    
    ![image](https://user-images.githubusercontent.com/243674/66465435-22f9fc80-ea81-11e9-83fc-2444434a33e6.png)
    
    ![image](https://user-images.githubusercontent.com/243674/66465462-2d1bfb00-ea81-11e9-827a-4c0502cb5f4a.png)
    
    Commits
    -------
    
    0302b1d [Cache] improve perf of pruning for fs-based adapters
  7. [Cache] improve perf of pruning for fs-based adapters

    nicolas-grekas committed Oct 9, 2019
  8. Merge branch '4.3' into 4.4

    nicolas-grekas committed Oct 9, 2019
    * 4.3:
      [Cache] cs fix
  9. [Cache] cs fix

    nicolas-grekas committed Oct 9, 2019
  10. Merge branch '4.3' into 4.4

    nicolas-grekas committed Oct 9, 2019
    * 4.3:
      [Cache] clean tags folder on invalidation
      [Cache] remove implicit dependency on symfony/filesystem
      Allow to set cookie_samesite to 'none'
      [VarDumper] fix array key error for class SymfonyCaster
      Adds missing translations for no nb
      [HttpKernel] fix $dotenvVars in data collector
      Add the missing translations for the Swedish ("sv") locale
      bumped Symfony version to 4.3.6
      updated VERSION for 4.3.5
      updated CHANGELOG for 4.3.5
      bumped Symfony version to 3.4.33
      updated VERSION for 3.4.32
      update CONTRIBUTORS for 3.4.32
      updated CHANGELOG for 3.4.32
      [Messenger] DoctrineTransport: ensure auto setup is only done once
      [Form][DateTimeImmutableToDateTimeTransformer] Preserve microseconds and use \DateTime::createFromImmutable() when available
      [Crawler] document $default as string|null
  11. Merge branch '3.4' into 4.3

    nicolas-grekas committed Oct 9, 2019
    * 3.4:
      Adds missing translations for no nb
      Add the missing translations for the Swedish ("sv") locale
      bumped Symfony version to 3.4.33
      updated VERSION for 3.4.32
      update CONTRIBUTORS for 3.4.32
      updated CHANGELOG for 3.4.32
  12. bug #33922 [Cache] remove implicit dependency on symfony/filesystem (…

    nicolas-grekas committed Oct 9, 2019
    …nicolas-grekas)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Cache] remove implicit dependency on symfony/filesystem
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    /cc @andrerom for review
    
    Commits
    -------
    
    85f27f2 [Cache] remove implicit dependency on symfony/filesystem
  13. bug #33927 Allow to set SameSite config to 'none' (ihmels)

    nicolas-grekas committed Oct 9, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    Allow to set SameSite config to 'none'
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix #33926
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    eec7e8c Allow to set cookie_samesite to 'none'
  14. bug #33930 [Cache] clean tags folder on invalidation (nicolas-grekas)

    nicolas-grekas committed Oct 9, 2019
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Cache] clean tags folder on invalidation
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    /cc @andrerom for review :)
    
    Commits
    -------
    
    b377e41 [Cache] clean tags folder on invalidation
  15. [Cache] clean tags folder on invalidation

    nicolas-grekas committed Oct 9, 2019
  16. [Cache] remove implicit dependency on symfony/filesystem

    nicolas-grekas committed Oct 9, 2019
  17. bug #32980 [Dotenv] support setting default env var values (xabbuh)

    nicolas-grekas committed Oct 9, 2019
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Dotenv] support setting default env var values
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #31530
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    2dd41e7 [Dotenv] support setting default env var values
  18. feature #33851 [EventDispatcher] Allow to omit the event name when re…

    nicolas-grekas committed Oct 9, 2019
    …gistering listeners (derrabus)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [EventDispatcher] Allow to omit the event name when registering listeners
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | Deprecations? | no
    | Tickets       | #33453 (kind of)
    | License       | MIT
    | Doc PR        | TODO
    
    After #30801 and #33485, this is another attempt at taking advantage of FQCN events for simplifying the registration of event listeners by inferring the event name from the parameter type declaration of the listener. This is my last attempt, I promise. 🙈
    
    This time, I'd like to make the `event` attribute of the `kernel.event_listener` tag optional. This would allow us to build listeners like the following one without adding any attributes to the `kernel.event_listener` tag.
    
    ```php
    namespace App\EventListener;
    
    final class MyRequestListener
    {
        public function __invoke(RequestEvent $event): void
        {
            // do something
        }
    }
    ```
    
    This in turn allows us to register a whole namespace of such listeners without having to configure each listener individually:
    
    ```YAML
    services:
        App\EventListener\:
            resource: ../src/EventListener/*
            tags: [kernel.event_listener]
    ```
    
    Commits
    -------
    
    6f32584 [EventDispatcher] Allow to omit the event name when registering listeners.
  19. bug #33919 [VarDumper] fix array key error for class SymfonyCaster (z…

    nicolas-grekas committed Oct 9, 2019
    …codes)
    
    This PR was squashed before being merged into the 4.3 branch (closes #33919).
    
    Discussion
    ----------
    
    [VarDumper] fix array key error for class SymfonyCaster
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix #33751
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    1f20f35 [VarDumper] fix array key error for class SymfonyCaster
Commits on Oct 8, 2019
  1. bug #33885 [Form][DateTimeImmutableToDateTimeTransformer] Preserve mi…

    nicolas-grekas committed Oct 8, 2019
    …croseconds and use \DateTime::createFromImmutable() when available (fancyweb)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Form][DateTimeImmutableToDateTimeTransformer] Preserve microseconds and use \DateTime::createFromImmutable() when available
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    For PHP >= 7.3, we should use [\DateTime::createFromImmutable()](https://www.php.net/manual/en/datetime.createfromimmutable.php) directly.
    
    This patch also preserves the `\DateTime` microseconds when the conversion is done with `\DateTime::createFromFormat()`.
    
    Commits
    -------
    
    dfa2303 [Form][DateTimeImmutableToDateTimeTransformer] Preserve microseconds and use \DateTime::createFromImmutable() when available
  2. bug #33900 [HttpKernel] Fix to populate $dotenvVars in data collector…

    nicolas-grekas committed Oct 8, 2019
    … when not using putenv() (mynameisbogdan)
    
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [HttpKernel] Fix to populate $dotenvVars in data collector when not using putenv()
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3 for bug fixes
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       |
    | License       | MIT
    
    Fix to populate $dotenvVars in data collector when not using putenv()
    
    Before:
    <img width="618" alt="Screen Shot 2019-10-08 at 03 53 49" src="https://user-images.githubusercontent.com/707714/66360303-49397280-e983-11e9-98b9-5272b9762dda.png">
    After:
    <img width="614" alt="Screen Shot 2019-10-08 at 03 55 43" src="https://user-images.githubusercontent.com/707714/66360304-4b9bcc80-e983-11e9-82de-46d484daa585.png">
    
    Commits
    -------
    
    ca3fb25 [HttpKernel] fix $dotenvVars in data collector
  3. feature #33461 [Cache] Improve RedisTagAwareAdapter invalidation logi…

    nicolas-grekas committed Oct 8, 2019
    …c & requirements (andrerom)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Cache] Improve RedisTagAwareAdapter invalidation logic & requirements
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes, _and improvment_
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | License       | MIT
    | Doc PR        |
    
    Changes logic of invalidation in RedisTagAwareAdapter in order to:
    - Delete the  tag key on invalidation => _avoiding possible left behind empty tag keys that Redis is not allowed to evict, gradually consuming more and more memory_
    
    Positive side effects of no longer using sPOP:
    - Lowered requirements to Redis 2.8, and no specific version constraint for phpredis
    - Lift limitation of 2 billion keys per tag _(Now only limited by Redis Set datatype: 4 billion)_
    
    Commits
    -------
    
    3d38c58 [Cache] Improve RedisTagAwareAdapter invalidation logic & requirements
Commits on Oct 7, 2019
  1. Merge branch '4.3' into 4.4

    nicolas-grekas committed Oct 7, 2019
    * 4.3:
      [travis] Fix build-packages script
      [HttpClient] bugfix exploding values of headers
      Remove useless testCanCheckIfTerminalIsInteractive test case
      [Validator] Add the missing translations for the Thai (\"th\") locale
      [Routing] gracefully handle docref_root ini setting
      [Validator] Fix ValidValidator group cascading usage
  2. Merge branch '3.4' into 4.3

    nicolas-grekas committed Oct 7, 2019
    * 3.4:
      [travis] Fix build-packages script
      Remove useless testCanCheckIfTerminalIsInteractive test case
      [Validator] Add the missing translations for the Thai (\"th\") locale
      [Validator] Fix ValidValidator group cascading usage
  3. [travis] Fix build-packages script

    nicolas-grekas committed Oct 7, 2019
  4. minor #33770 Add types to constructors and private/final/internal met…

    nicolas-grekas committed Oct 7, 2019
    …hods (Batch III) (derrabus)
    
    This PR was squashed before being merged into the 4.4 branch (closes #33770).
    
    Discussion
    ----------
    
    Add types to constructors and private/final/internal methods (Batch III)
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | #32179, #33228
    | License       | MIT
    | Doc PR        | N/A
    
    Followup to #33709, this time with:
    * Validator
    * VarDumper
    * Workflow
    * Yaml
    * all bridges
    * all bundles
    
    That should be the final batch. 😃
    
    Commits
    -------
    
    6493902 Add types to constructors and private/final/internal methods (Batch III)
  5. feature #33743 [HttpClient] Async HTTPlug client (Nyholm)

    nicolas-grekas committed Oct 7, 2019
    This PR was squashed before being merged into the 4.4 branch (closes #33743).
    
    Discussion
    ----------
    
    [HttpClient] Async HTTPlug client
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | Deprecations? | no
    | Tickets       | Fix #33710, Fix #32142
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#12389
    
    This PR removes `HttplugClient`'s dependency on `Psr18Client`. It will also add an `HttplugPromise` to make sure we sure we respect the Httplug's `HttpAsyncClient` interface.
    
    It implements `HttpAsyncClient::sendAsyncRequest()` and provides two extensions:
    - `HttplugPromise::cancel()` allows cancelling a promise (and the underlying response)
    - `HttplugClient::wait()` allows to tick the promise pool, with configurable timeouts.
    
    Commits
    -------
    
    4fd593f [HttpClient] Async HTTPlug client
  6. feature #33856 [Messenger] Allow to configure the db index on Redis t…

    nicolas-grekas committed Oct 7, 2019
    …ransport (chalasr)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Messenger] Allow to configure the db index on Redis transport
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | Deprecations? | no
    | Tickets       | Fix #33724
    | License       | MIT
    | Doc PR        | todo
    
    Quite useful for testing.
    
    Commits
    -------
    
    115a9bb [Messenger] Allow to configure the db index on Redis transport
  7. minor #33882 [VarDumper] Made all casters final (lyrixx)

    nicolas-grekas committed Oct 7, 2019
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [VarDumper] Made all casters final
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    3044a91 [VarDumper] Made all casters final
  8. bug #33871 [HttpClient] bugfix exploding values of headers (michaljus…

    nicolas-grekas committed Oct 7, 2019
    …iega)
    
    This PR was squashed before being merged into the 4.3 branch (closes #33871).
    
    Discussion
    ----------
    
    [HttpClient] bugfix exploding values of headers
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3 for bug fixes
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    I tried to use CachingHttpClient yesterday and I received an error.
    
    ```
    explode() expects parameter 2 to be string, array given
     C:\PROJEKTY\PHPStorm\symfony\src\Symfony\Component\HttpClient\HttpClientTrait.php:200
     C:\PROJEKTY\PHPStorm\symfony\src\Symfony\Component\HttpClient\HttpClientTrait.php:131
     C:\PROJEKTY\PHPStorm\symfony\src\Symfony\Component\HttpClient\HttpClientTrait.php:45
     C:\PROJEKTY\PHPStorm\symfony\src\Symfony\Component\HttpClient\CurlHttpClient.php:105
     C:\PROJEKTY\PHPStorm\symfony\src\Symfony\Component\HttpKernel\HttpClientKernel.php:54
     C:\PROJEKTY\PHPStorm\symfony\src\Symfony\Component\HttpKernel\HttpCache\SubRequestHandler.php:85
     C:\PROJEKTY\PHPStorm\symfony\src\Symfony\Component\HttpKernel\HttpCache\HttpCache.php:477
     C:\PROJEKTY\PHPStorm\symfony\src\Symfony\Component\HttpKernel\HttpCache\HttpCache.php:450
     C:\PROJEKTY\PHPStorm\symfony\src\Symfony\Component\HttpKernel\HttpCache\HttpCache.php:347
     C:\PROJEKTY\PHPStorm\symfony\src\Symfony\Component\HttpKernel\HttpCache\HttpCache.php:222
     C:\PROJEKTY\PHPStorm\symfony\src\Symfony\Component\HttpClient\CachingHttpClient.php:96
     C:\PROJEKTY\PHPStorm\symfony\src\Symfony\Component\HttpClient\Tests\CachingHttpClientTest.php:34
    
    ```
    This PR fix this.
    
    Commits
    -------
    
    5cd8895 [HttpClient] bugfix exploding values of headers
  9. feature #33881 [VarDumper] Added a support for casting Ramsey/Uuid (l…

    nicolas-grekas committed Oct 7, 2019
    …yrixx)
    
    This PR was squashed before being merged into the 4.4 branch (closes #33881).
    
    Discussion
    ----------
    
    [VarDumper] Added a support for casting Ramsey/Uuid
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | yes
    | Deprecations? | no
    | Tickets       |
    | License       | MIT
    | Doc PR        |
    
    I worked on a project using ramsey/uuid and I noticed a dumped uuid does
    not contain the uuid. So here we go :)
    
    (Note: don't get me wrong, I still do not recommend this lib)
    
    ---
    
    Before / After:
    ![Before / After](https://user-images.githubusercontent.com/408368/66298080-49892d80-e8f1-11e9-969f-95ae5169adb1.png)
    
    Commits
    -------
    
    99247bb [VarDumper] Added a support for casting Ramsey/Uuid
  10. minor #33866 [Intl] Update the ICU data to 65.1 (4.4 branch) (jakzal)

    nicolas-grekas committed Oct 7, 2019
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Intl] Update the ICU data to 65.1 (4.4 branch)
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Followup for #33862
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    5b2da72 [Intl] Update the ICU data to 65.1 (4.4 branch)
  11. minor #33877 Remove useless testCanCheckIfTerminalIsInteractive test …

    nicolas-grekas committed Oct 7, 2019
    …case (ostrolucky)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Remove useless testCanCheckIfTerminalIsInteractive test case
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       |
    | License       | MIT
    | Doc PR        |
    
    This test case does not work for following reasons:
    1. `$inputStream` is `NULL`. `posix_isatty` happily swallows null and returns `true`. Test would have to use [CommandTester::setInputs](https://github.com/symfony/symfony/blob/ac4e9b0b265add48604c58a17d3c7593c0587614/src/Symfony/Component/Console/Tester/CommandTester.php#L66) or call `$tester->getInput()->setStream()` to fix this
    1. Even if 1. is fixed, there are no internal `posix_isatty` calls going on. [ApplicationTester calls setInteractive only when such option is passed](https://github.com/symfony/symfony/blob/b0a32085887d0025aa84b39d2b12a57dc71e59ae/src/Symfony/Component/Console/Tester/ApplicationTester.php#L66), otherwise it will never be marked as interactive
    
    Commits
    -------
    
    a84e4e0 Remove useless testCanCheckIfTerminalIsInteractive test case
Older
You can’t perform that action at this time.