Skip to content
Permalink
Branch: master
Commits on Jan 11, 2020
  1. [FrameworkBundle] Deprecate *not* setting the "framework.router.utf8"…

    nicolas-grekas committed Jan 11, 2020
    … option
Commits on Jan 9, 2020
  1. bug #35099 [FrameworkBundle] Do not throw exception on value generate…

    nicolas-grekas committed Jan 9, 2020
    … key (jderusse)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Do not throw exception on value generate key
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | N/A
    | License       | MIT
    | Doc PR        | N/A
    
    When using env variable instead of key files and creating a new Secret, the check in `generateKeys` (called by the command `SecretsSetCommand`) prevents generating a secret.
    
    reproducer:
    
    ```
    $ rm config/secrets/prod/prod.decrypt.private.php
    $ export SYMFONY_DECRYPTION_SECRET=XXX
    $ ./bin/console secret:set FOO
    
    In SodiumVault.php line 50:
    
      Cannot generate keys when a decryption key has been provided while instantiating the vault.
    
    ```
    
    This PR converts the exception in a warning message.
    
    Commits
    -------
    
    2f608b4 Do not throw exception on valut generate key
  2. bug #35278 [EventDispatcher] expand listener in place (xabbuh)

    nicolas-grekas committed Jan 9, 2020
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [EventDispatcher] expand listener in place
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.3
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix #35259
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    f5d4073 expand listener in place
  3. Merge branch '5.0'

    nicolas-grekas committed Jan 9, 2020
    * 5.0:
      [PhpUnitBridge] fix compat with older versions of composer
  4. Merge branch '4.4' into 5.0

    nicolas-grekas committed Jan 9, 2020
    * 4.4:
      [PhpUnitBridge] fix compat with older versions of composer
  5. Merge branch '4.3' into 4.4

    nicolas-grekas committed Jan 9, 2020
    * 4.3:
      [PhpUnitBridge] fix compat with older versions of composer
  6. Merge branch '3.4' into 4.3

    nicolas-grekas committed Jan 9, 2020
    * 3.4:
      [PhpUnitBridge] fix compat with older versions of composer
  7. [PhpUnitBridge] fix compat with older versions of composer

    nicolas-grekas committed Jan 9, 2020
  8. fix tests

    nicolas-grekas committed Jan 9, 2020
  9. Merge branch '5.0'

    nicolas-grekas committed Jan 9, 2020
    * 5.0:
      fix tests
  10. Merge branch '4.4' into 5.0

    nicolas-grekas committed Jan 9, 2020
    * 4.4:
      fix tests
  11. Merge branch '4.3' into 4.4

    nicolas-grekas committed Jan 9, 2020
    * 4.3:
      fix tests
  12. Merge branch '3.4' into 4.3

    nicolas-grekas committed Jan 9, 2020
    * 3.4:
      fix tests
  13. fix tests

    nicolas-grekas committed Jan 9, 2020
  14. Merge branch '5.0'

    nicolas-grekas committed Jan 9, 2020
    * 5.0:
      fix deps
      Relax transient test
  15. Merge branch '4.4' into 5.0

    nicolas-grekas committed Jan 9, 2020
    * 4.4:
      fix deps
      Relax transient test
  16. Merge branch '4.3' into 4.4

    nicolas-grekas committed Jan 9, 2020
    * 4.3:
      fix deps
      Relax transient test
  17. fix deps

    nicolas-grekas committed Jan 9, 2020
  18. Merge branch '3.4' into 4.3

    nicolas-grekas committed Jan 9, 2020
    * 3.4:
      Relax transient test
  19. Relax transient test

    nicolas-grekas committed Jan 9, 2020
  20. Merge branch '5.0'

    nicolas-grekas committed Jan 9, 2020
    * 5.0:
      Added more tests for WebProfilerBundle
  21. Merge branch '4.4' into 5.0

    nicolas-grekas committed Jan 9, 2020
    * 4.4:
      Added more tests for WebProfilerBundle
  22. Merge branch '4.3' into 4.4

    nicolas-grekas committed Jan 9, 2020
    * 4.3:
      Added more tests for WebProfilerBundle
  23. Merge branch '3.4' into 4.3

    nicolas-grekas committed Jan 9, 2020
    * 3.4:
      Added more tests for WebProfilerBundle
  24. minor #31522 Added more tests for WebProfilerBundle (javiereguiluz)

    nicolas-grekas committed Jan 9, 2020
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    Added more tests for WebProfilerBundle
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | -   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | -
    
    Thanks to @jpauli Code Coverage info about Symfony (http://cov.jpauli.tech/) I found that WebProfiler's controllers are pretty badly covered:
    
    ![image](https://user-images.githubusercontent.com/73419/57919817-ec390500-7899-11e9-81b7-763a0b35d0ec.png)
    
    This PR focuses on testing the main controller class:
    
    ![image](https://user-images.githubusercontent.com/73419/57919877-04108900-789a-11e9-8a93-3466b672d873.png)
    
    Commits
    -------
    
    2f7a820 Added more tests for WebProfilerBundle
  25. Merge branch '5.0'

    nicolas-grekas committed Jan 9, 2020
    * 5.0:
      [String] add test case for wordwrap method
      [Process] - update @throws phpdoc
      [PHPUnitBridge] file_get_contents() expects parameter 3 to be resource
      [PHPUnit-Bridge] Fail-fast in simple-phpunit if one of the passthru() commands fails
      [HttpKernel][FileLocator] Fix deprecation message
  26. minor #35236 [String] add test case for wordwrap method (mgamal92)

    nicolas-grekas committed Jan 9, 2020
    This PR was submitted for the master branch but it was squashed and merged into the 5.0 branch instead.
    
    Discussion
    ----------
    
    [String] add test case for wordwrap method
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | License       | MIT
    
    Just test case for ```wordwrap``` method
    
    Commits
    -------
    
    c314598 [String] add test case for wordwrap method
  27. Merge branch '4.4' into 5.0

    nicolas-grekas committed Jan 9, 2020
    * 4.4:
      [Process] - update @throws phpdoc
      [PHPUnitBridge] file_get_contents() expects parameter 3 to be resource
      [PHPUnit-Bridge] Fail-fast in simple-phpunit if one of the passthru() commands fails
      [HttpKernel][FileLocator] Fix deprecation message
  28. bug #35269 [HttpKernel][FileLocator] Fix deprecation message (fancyweb)

    nicolas-grekas committed Jan 9, 2020
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [HttpKernel][FileLocator] Fix deprecation message
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    Ref #34886
    
    `$deprecatedPath` is the foreach value so it only works if the last element triggers the deprecation, otherwise the value is wrong.
    
    Commits
    -------
    
    18ce839 [HttpKernel][FileLocator] Fix deprecation message
  29. Merge branch '4.3' into 4.4

    nicolas-grekas committed Jan 9, 2020
    * 4.3:
      [Process] - update @throws phpdoc
      [PHPUnitBridge] file_get_contents() expects parameter 3 to be resource
      [PHPUnit-Bridge] Fail-fast in simple-phpunit if one of the passthru() commands fails
  30. Merge branch '3.4' into 4.3

    nicolas-grekas committed Jan 9, 2020
    * 3.4:
      [PHPUnitBridge] file_get_contents() expects parameter 3 to be resource
      [PHPUnit-Bridge] Fail-fast in simple-phpunit if one of the passthru() commands fails
  31. minor #35265 [Process] - update @throws phpdoc (Benhssaein Youssef)

    nicolas-grekas committed Jan 9, 2020
    This PR was merged into the 4.3 branch.
    
    Discussion
    ----------
    
    [Process] - update @throws phpdoc
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | no
    | License       | MIT
    | Doc PR        |
    
    Update PHPDoc throws Exceptions on https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Process/Process.php
    
    Commits
    -------
    
    2be7029 [Process] - update @throws phpdoc
  32. minor #35274 [PHPUnitBridge] file_get_contents() expects parameter 3 …

    nicolas-grekas committed Jan 9, 2020
    …to be resource (plozmun)
    
    This PR was squashed before being merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [PHPUnitBridge] file_get_contents() expects parameter 3 to be resource
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    file_get_contents 3rd parameter (context) expects resource or NULL to ignore them
    
    Commits
    -------
    
    a28a421 [PHPUnitBridge] file_get_contents() expects parameter 3 to be resource
  33. bug #35254 [PHPUnit-Bridge] Fail-fast in simple-phpunit if one of the…

    nicolas-grekas committed Jan 9, 2020
    … passthru() commands fails (mpdude)
    
    This PR was squashed before being merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [PHPUnit-Bridge] Fail-fast in simple-phpunit if one of the passthru() commands fails
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       |
    | License       | MIT
    | Doc PR        |
    
    Some commands executed by the `simple-phpunit` script are not checked for success. For example [here](https://travis-ci.org/twigphp/Twig/jobs/634110681), Composer fails with the message
    
    ```
      [InvalidArgumentException]
      Could not find package phpunit/phpunit with version 7.5.* in a version inst
      allable using your PHP version 7.0.25.
    ```
    
    Yet, the `simple-phpunit` script happily continues, going over failing `chdir()`, `file_get_contents()` and `include()` calls and eventually returns a successful `0` exit code. So CI tests look OK when in fact PHPUnit was not even downloaded.
    
    Commits
    -------
    
    576e185 [PHPUnit-Bridge] Fail-fast in simple-phpunit if one of the passthru() commands fails
Commits on Jan 8, 2020
  1. Merge branch '5.0'

    nicolas-grekas committed Jan 8, 2020
    * 5.0:
      [Debug] fix ClassNotFoundFatalErrorHandler
      [FrameworkBundle] Document the router.cache_class_prefix parameter removal
      [Routing] Fix using a custom matcher & generator dumper class
      [Notifier] Add more specific types at documentation level when php engine can't
      [Serializer] Fix cache in MetadataAwareNameConverter
      [Dotenv] Fixed infinite loop with missing quote followed by quoted value
      [HttpClient] Added missing sprintf
      [TwigBridge] button_widget now has its title attr translated even if its label = null or false
      [PhpUnitBridge] When using phpenv + phpenv-composer plugin, composer executable is wrapped into a bash script
      [Messenger] Added check if json_encode succeeded
      [Messenger] Added check if json_encode succeeded
      [FrameworkBundle][ContainerLintCommand] Only skip .errored. services
      [HttpClient] fix exception in case of PSR17 discovery failure
      [DependencyInjection] Handle ServiceClosureArgument for callable in container linting
      fix processing chain adapter based cache pool
      [HttpKernel] release lock explicitly
      [Security] Prevent canceled remember-me cookie from being accepted
      [FrameworkBundle][TranslationUpdateCommand] Do not output positive feedback on stderr
      [Security\Guard] Fix missing typehints
      do not render preferred choices as selected
Older
You can’t perform that action at this time.