Skip to content
Permalink
Branch: master
Commits on Mar 25, 2020
  1. [DI] dump factory files as classes

    nicolas-grekas committed Mar 24, 2020
Commits on Mar 24, 2020
  1. minor #36183 [Form] conflict with translation contracts < 1.1.7 (xabbuh)

    nicolas-grekas committed Mar 24, 2020
    This PR was merged into the 5.1-dev branch.
    
    Discussion
    ----------
    
    [Form] conflict with translation contracts < 1.1.7
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    d2197aa conflict with translation contracts < 1.1.7
Commits on Mar 23, 2020
  1. bug #36180 [Uid] work around buggy libuuid (nicolas-grekas)

    nicolas-grekas committed Mar 23, 2020
    This PR was merged into the 5.1-dev branch.
    
    Discussion
    ----------
    
    [Uid] work around buggy libuuid
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    As found while working on the polyfill, fixed upstream in
    karelzak/util-linux@d6ddf07
    
    Commits
    -------
    
    ebf601b [Uid] work around buggy libuuid
  2. [Uid] work around buggy libuuid

    nicolas-grekas committed Mar 23, 2020
  3. [Mailer] fix merge of MailgunApiTransportTest

    nicolas-grekas committed Mar 23, 2020
  4. Merge branch '5.0'

    nicolas-grekas committed Mar 23, 2020
    * 5.0:
      [Http Foundation] Fix clear cookie samesite
      [Security] Check if firewall is stateless before checking for session/previous session
      [Form] Support customized intl php.ini settings
      [Security] Remember me: allow to set the samesite cookie flag
      [Debug] fix for PHP 7.3.16+/7.4.4+
      [Validator] Backport translations
      [Mailer] Use %d instead of %s for error code in error messages
      [HttpKernel] fix locking for PHP 7.4+
      [Security] Fixed hardcoded value of SODIUM_CRYPTO_PWHASH_MEMLIMIT_INTERACTIVE
      Prevent warning in proc_open()
      [FrameworkBundle] Fix Router Cache
      Fix deprecation messages
  5. Merge branch '4.4' into 5.0

    nicolas-grekas committed Mar 23, 2020
    * 4.4:
      [Http Foundation] Fix clear cookie samesite
      [Security] Check if firewall is stateless before checking for session/previous session
      [Form] Support customized intl php.ini settings
      [Security] Remember me: allow to set the samesite cookie flag
      [Debug] fix for PHP 7.3.16+/7.4.4+
      [Validator] Backport translations
      [Mailer] Use %d instead of %s for error code in error messages
      [HttpKernel] fix locking for PHP 7.4+
      [Security] Fixed hardcoded value of SODIUM_CRYPTO_PWHASH_MEMLIMIT_INTERACTIVE
      Prevent warning in proc_open()
      [FrameworkBundle] Fix Router Cache
      Fix deprecation messages
  6. bug #36169 [HttpKernel] fix locking for PHP 7.4+ (nicolas-grekas)

    nicolas-grekas committed Mar 23, 2020
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [HttpKernel] fix locking for PHP 7.4+
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | #36132
    | License       | MIT
    | Doc PR        | -
    
    As explained in https://bugs.php.net/79398
    
    Commits
    -------
    
    f618b98 [HttpKernel] fix locking for PHP 7.4+
  7. Merge branch '3.4' into 4.4

    nicolas-grekas committed Mar 23, 2020
    * 3.4:
      [Http Foundation] Fix clear cookie samesite
      [Security] Check if firewall is stateless before checking for session/previous session
      [Form] Support customized intl php.ini settings
      [Security] Remember me: allow to set the samesite cookie flag
      [Debug] fix for PHP 7.3.16+/7.4.4+
      [Validator] Backport translations
      Prevent warning in proc_open()
  8. bug #36175 [Security/Http] Remember me: allow to set the samesite coo…

    nicolas-grekas committed Mar 23, 2020
    …kie flag (dunglas)
    
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Security/Http] Remember me: allow to set the samesite cookie flag
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    Similar to #35605, since Chrome 80 is going to require the `samesite` attribute.
    
    This is a cherry-pick of #27976
    
    Commits
    -------
    
    f0ceb73 [Security] Remember me: allow to set the samesite cookie flag
  9. bug #36173 [Http Foundation] Fix clear cookie samesite (guillbdx)

    nicolas-grekas committed Mar 23, 2020
    This PR was squashed before being merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Http Foundation] Fix clear cookie samesite
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix #36107
    | License       | MIT
    
    With Chrome Update 80, Cookies are required to be `secure` and `samesite=none` for cross site requests. However they are defaulted to `samesite=lax` if the samesite attribute is not set. In other words: developer has to explicitely opt-in for `samesite=none` in the case of a cross site request.
    
    More details: https://chromestatus.com/feature/5088147346030592
    
    We add the `samesite` argument to `clearCookie` method to allow developer to explicitely set this value.
    
    Commits
    -------
    
    4bdea1f [Http Foundation] Fix clear cookie samesite
  10. bug #36176 [Security] Check if firewall is stateless before checking …

    nicolas-grekas committed Mar 23, 2020
    …for session/previous session (koenreiniers)
    
    This PR was submitted for the 4.4 branch but it was squashed and merged into the 3.4 branch instead.
    
    Discussion
    ----------
    
    [Security] Check if firewall is stateless before checking for session/previous session
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4 <!-- see below -->
    | Bug fix?      | yes
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tickets       | - <!-- prefix each issue number with "Fix #", if any -->
    | License       | MIT
    | Doc PR        | -
    
    For one of our applications we had the issue that the session was always initialized, even for routes behind stateless firewalls. Using the redis session adapter this sometimes lead to exceptions if the connection failed. This change prevents the session from being initialized in the guard authentication handler for stateless firewalls
    
    Commits
    -------
    
    9bb1230 [Security] Check if firewall is stateless before checking for session/previous session
  11. minor #36177 Fix typo on deprecated parameter typehint on UPGRADE-5.1…

    nicolas-grekas committed Mar 23, 2020
    ….md file (jpjoao)
    
    This PR was merged into the 5.1-dev branch.
    
    Discussion
    ----------
    
    Fix typo on deprecated parameter typehint on UPGRADE-5.1.md file
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | None
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#13394
    
    Fix typo.
    
    Commits
    -------
    
    4939d4c [FrameworkBundle] Fix typo on deprecated parameter typehint
  12. bug #36149 [Form] Support customized intl php.ini settings (jorrit)

    nicolas-grekas committed Mar 23, 2020
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Form] Support customized intl php.ini settings
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | no
    | License       | MIT
    | Doc PR        | no
    
    `IntlDateParser->parse()` behaves differently when `intl.error_level` and/or `intl.use_exceptions` are not 0.
    
    This change makes sure `\IntlException` is caught when `intl.use_exceptions` is 1 and warnings thrown when `intl.error_level` is not 0 are ignored.
    
    Commits
    -------
    
    61025d1 [Form] Support customized intl php.ini settings
  13. minor #36137 [HttpClient] Issue notice when NativeHttpClient is used …

    nicolas-grekas committed Mar 23, 2020
    …(trowski)
    
    This PR was merged into the 5.1-dev branch.
    
    Discussion
    ----------
    
    [HttpClient] Issue notice when NativeHttpClient is used
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    Simple PR to issue a notice to notify the user that `ext-curl` or `amphp/http-client` should be installed to use an HTTP/2 capable HTTP client. Not sure on the notice wording.
    
    Commits
    -------
    
    874c1e6 [HttpClient] Issue notice when NativeHttpClient is used
  14. bug #36172 [Debug] fix for PHP 7.3.16+/7.4.4+ (nicolas-grekas)

    nicolas-grekas committed Mar 23, 2020
    This PR was merged into the 3.4 branch.
    
    Discussion
    ----------
    
    [Debug] fix for PHP 7.3.16+/7.4.4+
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    Should make tests green.
    Follows php/php-src#5206, which is part of PHP 7.4.4 and 7.3.16.
    The same patch is needed on the ErrorHandler component in 4.4 of course.
    
    Commits
    -------
    
    b3d9a8a [Debug] fix for PHP 7.3.16+/7.4.4+
  15. [Debug] fix for PHP 7.3.16+/7.4.4+

    nicolas-grekas committed Mar 23, 2020
Commits on Mar 22, 2020
  1. [HttpKernel] fix locking for PHP 7.4+

    nicolas-grekas committed Mar 22, 2020
Commits on Mar 20, 2020
  1. minor #36153 [Uid] minor improvements (nicolas-grekas)

    nicolas-grekas committed Mar 20, 2020
    This PR was merged into the 5.1-dev branch.
    
    Discussion
    ----------
    
    [Uid] minor improvements
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    660326b [Uid] minor improvements
  2. [Uid] minor improvements

    nicolas-grekas committed Mar 16, 2020
  3. bug #36151 [Security] Fixed hardcoded value of SODIUM_CRYPTO_PWHASH_M…

    nicolas-grekas committed Mar 20, 2020
    …EMLIMIT_INTERACTIVE (lyrixx)
    
    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [Security] Fixed hardcoded value of SODIUM_CRYPTO_PWHASH_MEMLIMIT_INTERACTIVE
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    6774294 [Security] Fixed hardcoded value of SODIUM_CRYPTO_PWHASH_MEMLIMIT_INTERACTIVE
Commits on Mar 19, 2020
  1. bug #36143 [FrameworkBundle] Fix Router Cache (guillbdx)

    nicolas-grekas committed Mar 19, 2020
    This PR was squashed before being merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Fix Router Cache
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | Fix #35932
    | License       | MIT
    
    RouteCollection config cache didn't have the container file in the tracked resources. If container was recompiled, routes cache was not regenerated. This PR adds the container file to the route collection resources.
    
    Commits
    -------
    
    c6ace13 [FrameworkBundle] Fix Router Cache
  2. minor #36128 [Form][CheckboxType] Remove _false_is_empty flag (fancyweb)

    nicolas-grekas committed Mar 19, 2020
    This PR was merged into the 5.1-dev branch.
    
    Discussion
    ----------
    
    [Form][CheckboxType] Remove _false_is_empty flag
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    Cleanup of #35938.
    
    Commits
    -------
    
    6fac6d4 [Form][CheckboxType] Remove _false_is_empty flag
Commits on Mar 18, 2020
  1. Merge branch '5.0'

    nicolas-grekas committed Mar 18, 2020
    * 5.0:
      [DI] Fix CheckTypeDeclarationPass
      [Security/Http] don't require the session to be started when tracking its id
      [DI] fix preloading script generation
  2. Merge branch '4.4' into 5.0

    nicolas-grekas committed Mar 18, 2020
    * 4.4:
      [DI] Fix CheckTypeDeclarationPass
      [Security/Http] don't require the session to be started when tracking its id
      [DI] fix preloading script generation
Commits on Mar 17, 2020
  1. [VarDumper] fix side-effect by not using mt_rand()

    nicolas-grekas committed Mar 17, 2020
  2. [Security/Http] don't require the session to be started when tracking…

    nicolas-grekas committed Mar 17, 2020
    … its id
  3. Merge branch '5.0'

    nicolas-grekas committed Mar 17, 2020
    * 5.0:
      fix merge
      Fix more quotes in exception messages
      Fix more quotes in exception messages
      Fix more quotes in exception messages
      [3.4] Minor fixes
      [PropertyAccess] Improved errors when reading uninitialized properties
  4. [DI] fix preloading script generation

    nicolas-grekas committed Sep 24, 2019
  5. Merge branch '4.4' into 5.0

    nicolas-grekas committed Mar 17, 2020
    * 4.4:
      fix merge
  6. fix merge

    nicolas-grekas committed Mar 17, 2020
Commits on Mar 16, 2020
  1. minor #35945 Leverage PHP8's get_debug_type() (nicolas-grekas)

    nicolas-grekas committed Mar 16, 2020
    This PR was merged into the 5.1-dev branch.
    
    Discussion
    ----------
    
    Leverage PHP8's get_debug_type()
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    See symfony/polyfill#226 for background.
    
    We might have to port part of the patch to 4.4 when we'll work on having it support PHP 8, but that's not needed for now.
    
    Commits
    -------
    
    daf1c66 Leverage PHP8's get_debug_type()
  2. Leverage PHP8's get_debug_type()

    nicolas-grekas committed Mar 3, 2020
Commits on Mar 15, 2020
  1. minor #36086 [UID] remove unused property (Tobion)

    nicolas-grekas committed Mar 15, 2020
    This PR was merged into the 5.1-dev branch.
    
    Discussion
    ----------
    
    [UID] remove unused property
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tickets       |
    | License       | MIT
    | Doc PR        |
    
    leftover from #36074
    
    Commits
    -------
    
    901e62a remove unused uuid property
Older
You can’t perform that action at this time.