Permalink
Commits on Aug 26, 2016
  1. bug #19743 [symfony/symfony] add "provides" for psr/cache-implementat…

    …ion (alcohol)
    
    This PR was merged into the 3.1 branch.
    
    Discussion
    ----------
    
    [symfony/symfony] add "provides" for psr/cache-implementation
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.1
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #19742
    | License       | MIT
    
    Commits
    -------
    
    2f4c801 add "provides" for psr/cache-implementation
    stof committed Aug 26, 2016
Commits on Aug 19, 2016
  1. minor #19675 [WebProfilerBundle] replaces tabs characters by spaces. …

    …(hhamon)
    
    This PR was merged into the 3.1 branch.
    
    Discussion
    ----------
    
    [WebProfilerBundle] replaces tabs characters by spaces.
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.1
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | ~
    | License       | MIT
    | Doc PR        | ~
    
    Commits
    -------
    
    dd10034 [WebProfilerBundle] replaces tabs characters by spaces.
    stof committed Aug 19, 2016
Commits on Jul 28, 2016
  1. minor #19459 [EventDispatcher] Removed unused variable (zomberg)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [EventDispatcher] Removed unused variable
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | ~
    | License       | MIT
    | Doc PR        | ~
    
    Commits
    -------
    
    891e2ea [EventDispatcher] Removed unused variable
    stof committed Jul 28, 2016
Commits on Jul 27, 2016
  1. bug #19439 [DependencyInjection] Fixed deprecated default message tem…

    …plate with XML (jeremyFreeAgent)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [DependencyInjection] Fixed deprecated default message template with XML
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    165529b [DependencyInjection] Fixed deprecated default message template with XML
    stof committed Jul 27, 2016
Commits on Jul 25, 2016
  1. [DomCrawler] Inherit the namespace cache in subcrawlers

    stof committed Jul 25, 2016
Commits on Jul 18, 2016
  1. Merge branch '2.7' into 2.8

    * 2.7:
      fixed CS
      Fix the DBAL session handler version check for Postgresql
    stof committed Jul 18, 2016
Commits on Jul 15, 2016
  1. Fix the DBAL session handler version check for Postgresql

    stof committed Jul 15, 2016
Commits on Jul 11, 2016
  1. Fix the retrieval of the last username when using forwarding

    stof committed Jul 11, 2016
Commits on Jun 13, 2016
  1. bug #19038 Fix feature detection for IE (Alsciende)

    This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #19038).
    
    Discussion
    ----------
    
    Fix feature detection for IE
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    operator `!` has higher precedence (4) than operator `in` (8). Parentheses are mandatory here to have a chance at passing the test.
    
    Commits
    -------
    
    b35658b Fix feature detection for IE
    stof committed Jun 13, 2016
Commits on Jun 2, 2016
  1. Skip some tests on HHVM due to a PHPunit bug

    stof committed Jun 2, 2016
  2. Use the Trusty Travis infrastructure for HHVM builds

    This allows running an uptodate version of HHVM rather than running the
    latest version supporting Precise, which is very old.
    stof committed Jun 2, 2016
Commits on May 30, 2016
  1. minor #18914 [#18838] add a test to avoid regressions (xabbuh)

    This PR was merged into the 3.1 branch.
    
    Discussion
    ----------
    
    [#18838] add a test to avoid regressions
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.1
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #18838
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    240cf0a [#18838] add a test to avoid regressions
    stof committed May 30, 2016
Commits on May 25, 2016
  1. bug #18858 [Yaml] fix falsely triggered deprecation (xabbuh)

    This PR was merged into the 3.1-dev branch.
    
    Discussion
    ----------
    
    [Yaml] fix falsely triggered deprecation
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | https://github.com/symfony/symfony/pull/18785/files#r64390640
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    89dd69a [Yaml] fix falsely triggered deprecation
    stof committed May 25, 2016
Commits on May 13, 2016
  1. minor #18770 Updated the link to the list of currency codes (javiereg…

    …uiluz)
    
    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    Updated the link to the list of currency codes
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.3
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #18758
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    09b70a1 Updated the link to the list of currency codes
    stof committed May 13, 2016
Commits on Apr 19, 2016
  1. minor #18591 [Config] Fix XmlUtilsTest namespace (JhonnyL)

    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [Config] Fix XmlUtilsTest namespace
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.3
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    58425eb [Config] Fix XmlUtilsTest namespace
    stof committed Apr 19, 2016
Commits on Apr 14, 2016
  1. minor #18534 [HttpKernel] Fix wrong number of arguments in call of Ex…

    …ceptionListener::logException() (chalasr)
    
    This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes #18534).
    
    Discussion
    ----------
    
    [HttpKernel] Fix wrong number of arguments in call of ExceptionListener::logException()
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #18527
    | License       | MIT
    | Doc PR        | n/a
    
    The `$original` argument has been removed from the method signature in [22f4807](22f4807).
    
    Commits
    -------
    
    00ae320 [HttpKernel] Fix wrong number of arguments in call of ExceptionListener::logException()
    stof committed Apr 14, 2016
Commits on Apr 7, 2016
  1. Add the kernel.controller_arguments event

    stof committed Apr 5, 2016
  2. bug #18469 Force profiler toolbar svg display (pyrech)

    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    Force profiler toolbar svg display
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | -
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    When applying `display: block` on all svg of our website, we found that toolbar's svg were also impacted:
    
    ![capture du 2016-04-07 10-57-05](https://cloud.githubusercontent.com/assets/2021641/14345830/7d531388-fcaf-11e5-88ad-92f5522b4e98.png)
    
    Just apply a default display on toolbar's svg fixes the issue.
    
    Commits
    -------
    
    467d8c7 Force profiler toolbar svg display
    stof committed Apr 7, 2016
  3. bug #18460 [DomCrawler] Fix select option with empty value (Matt Wells)

    This PR was merged into the 2.3 branch.
    
    Discussion
    ----------
    
    [DomCrawler] Fix select option with empty value
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.3+
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no?
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    While using the Laravel's testing suite which makes use of the Symfony DOM Crawler (v3.0.2). I have been populating a form with a select which has a value which can be an empty value.
    
    For example, with this select you can choose your gender or leave it empty if you don't want to specify:
    
    ```html
    <select name="gender">
      <option selected></option>
      <option>Female</option>
      <option>Male</option>
    </select>
    ```
    
    When the `DomCrawler\Field::getValue()` is called I was expect to get the value `''` however I was actually getting `'on'`. This is caused by the [DomCrawler\Field::buildOptionValue()](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DomCrawler/Field/ChoiceFormField.php#L262-L271) sets the default value to 'on' when there is no value which makes sense for ratios and checkboxes but not for select.
    
    I have tracked this bug back to v2.3 but it is still present in v3, however, the default value was changed from '1' to 'on' in v2.5 which means that this patch will conflict when merging up the maintained versions.
    
    Commits
    -------
    
    58276a2 Fix Dom Crawler select option with empty value
    stof committed Apr 7, 2016
Commits on Mar 17, 2016
  1. minor #18217 [Process] fix docblock syntax (xabbuh)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [Process] fix docblock syntax
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #18023 (comment)
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    f909fca [Process] fix docblock syntax
    stof committed Mar 17, 2016
Commits on Jan 7, 2016
  1. minor #17289 [VarDumper] Fix typo (nicolas-grekas)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [VarDumper] Fix typo
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    cb70360 [VarDumper] Fix typo
    stof committed Jan 7, 2016
Commits on Dec 30, 2015
  1. bug #17179 [WebProfiler] Removed an object as route generator argumen…

    …t (iltar)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [WebProfiler] Removed an object as route generator argument
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #17178
    | License       | MIT
    | Doc PR        | ~
    
    Commits
    -------
    
    43fd7bb Removed an object as route generator argument
    stof committed Dec 30, 2015
Commits on Dec 17, 2015
  1. bug #17059 [HttpFoundation] fix error level for deprecation (xabbuh)

    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [HttpFoundation] fix error level for deprecation
    
    | Q             | A
    | ------------- | ---
    | Fixed tickets | #17058
    | License       | MIT
    
    Commits
    -------
    
    4929634 fix error level for deprecation
    stof committed Dec 17, 2015
  2. Fix the logout path when not using the router

    This needs to use the base url, not the base path, so that it goes
    through the front controller when not using url rewriting.
    stof committed Dec 17, 2015
  3. Fix the logout path when not using the router

    This needs to use the base url, not the base path, so that it goes
    through the front controller when not using url rewriting.
    stof committed Dec 17, 2015
Commits on Dec 14, 2015
  1. bug #16955 [FrameworkBundle] ContainerDebugCommand: pass the right ob…

    …ject to the descriptors (xabbuh)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] ContainerDebugCommand: pass the right object to the descriptors
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | c5067da#commitcomment-14884960
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    8cf0022 pass the right object to the descriptors
    stof committed Dec 14, 2015
Commits on Dec 11, 2015
  1. minor #16944 [Security][Guard] checkCredentials() should have a @return

    … annotation (derrabus)
    
    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [Security][Guard] checkCredentials() should have a @return annotation
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | none
    | License       | MIT
    | Doc PR        | none
    
    According to its documentation, an implementation of the `GuardAuthenticatorInterface::checkCredentials()` method should return `true` on success. I've added a `@return` annotation to the PHPDoc block to reflect the fact that this method should actually return something.
    
    Commits
    -------
    
    4fd24a0 Added @return to checkCredentials()
    stof committed Dec 11, 2015
Commits on Dec 10, 2015
  1. bug #16953 return ajax collector to collectors.php (NothingWeAre)

    This PR was merged into the 3.0 branch.
    
    Discussion
    ----------
    
    return ajax collector to collectors.php
    
    | Q             | A
    | ------------- | ---
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | no
    | Fixed tickets | #16880
    | License       | MIT
    | Doc PR        |
    
    in symfony 3.0 there is no ajax collector declared. Because of that debug toolbar do not display ajax calls
    
    Commits
    -------
    
    8a2c757 return ajax collector to collectors.php
    stof committed Dec 10, 2015
Commits on Dec 5, 2015
  1. Merge branch '3.0'

    * 3.0:
      Fix the exception message expectation
    stof committed Dec 5, 2015
  2. Merge branch '2.8' into 3.0

    * 2.8:
      Fix the exception message expectation
    stof committed Dec 5, 2015
  3. Merge branch '2.7' into 2.8

    * 2.7:
      Fix the exception message expectation
    stof committed Dec 5, 2015
  4. Fix the exception message expectation

    The message was changed between 2.3 and 2.7.
    stof committed Dec 5, 2015
  5. Merge branch '3.0'

    * 3.0:
      [Process] Fix stopping a process on Windows
      [PhpUnitBridge] Add weak-verbose mode and match against message instead of test name
      Added a note about the new requirement iconv.
      Improved error messages for Yaml Deprecations
      Added a test case for the Logger class.
      [Form] Fix choices defined as Traversable
      CS: general fixes
      Suggested Process dependency
    stof committed Dec 5, 2015
  6. Merge branch '2.8' into 3.0

    * 2.8:
      [Process] Fix stopping a process on Windows
      [PhpUnitBridge] Add weak-verbose mode and match against message instead of test name
      Added a note about the new requirement iconv.
      Improved error messages for Yaml Deprecations
      Added a test case for the Logger class.
      [Form] Fix choices defined as Traversable
      CS: general fixes
      Suggested Process dependency
    stof committed Dec 5, 2015
  7. Merge branch '2.7' into 2.8

    * 2.7:
      [Process] Fix stopping a process on Windows
      Added a test case for the Logger class.
      CS: general fixes
    stof committed Dec 5, 2015