Permalink
Commits on Nov 28, 2016
  1. ensure the proper context for nested validations

    xabbuh committed Nov 28, 2016
  2. mark alias as private during creation

    xabbuh committed Nov 28, 2016
Commits on Nov 27, 2016
  1. bug #20653 [WebProfilerBundle] Profiler includes ghost panels

    jzawadzki committed Nov 27, 2016
  2. bug #20652 Fixed getRouteParams() when no parameters are available (w…

    …outerj)
    
    This PR was merged into the 3.2 branch.
    
    Discussion
    ----------
    
    Fixed getRouteParams() when no parameters are available
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #20650
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    040da81 Fixed getRouteParams() when no parameters are available
    nicolas-grekas committed Nov 27, 2016
  3. Fixed getRouteParams() when no parameters are available

    wouterj committed Nov 27, 2016
  4. bumped Symfony version to 3.2.0

    fabpot committed Nov 27, 2016
  5. Merge pull request #20649 from fabpot/release-3.2.0-RC2

    released v3.2.0-RC2
    fabpot committed on GitHub Nov 27, 2016
  6. updated VERSION for 3.2.0-RC2

    fabpot committed Nov 27, 2016
  7. updated CHANGELOG for 3.2.0-RC2

    fabpot committed Nov 27, 2016
  8. Merge branch '3.2'

    * 3.2:
      Fix tests that do not trigger any depreciation
      [HttpFoundation] Fix test ensuring isMethodSafe() checks cacheable
      [Cache] Mark FilesystemAdapterTrait as internal
      [FrameworkBundle] Dont rely on any parent definition for "cache.annotations"
    fabpot committed Nov 27, 2016
  9. Merge branch '3.1' into 3.2

    * 3.1:
      [HttpFoundation] Fix test ensuring isMethodSafe() checks cacheable
    fabpot committed Nov 27, 2016
  10. Merge branch '2.8' into 3.1

    * 2.8:
      [HttpFoundation] Fix test ensuring isMethodSafe() checks cacheable
    fabpot committed Nov 27, 2016
  11. Merge branch '2.7' into 2.8

    * 2.7:
      [HttpFoundation] Fix test ensuring isMethodSafe() checks cacheable
    fabpot committed Nov 27, 2016
Commits on Nov 26, 2016
  1. bug #20601 [FrameworkBundle] Don't rely on any parent definition for …

    …"cache.annotations" (nicolas-grekas)
    
    This PR was merged into the 3.2 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Don't rely on any parent definition for "cache.annotations"
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Instead of a generic approach that failed in #20537, let's focus on the `cache.annotations` service, which is the one that needs special care because it can be required while the container is being built. See e.g.:
    - #20234
    - http://stackoverflow.com/questions/39625863/vichuploadbundle-inb-symfony-3-cant-load-cache-annotations-service/40626277
    - schmittjoh/JMSDiExtraBundle#262
    
    When the service is required at build time, we can't provide it a logger, because no logger service is ready at that time. Still, that doesn't prevent the service from working. The late `CachePoolClearerPass` wires the logger for later instantiations so that `cache.annotations` has a properly configured logger *for the next requests*.
    
    Commits
    -------
    
    f62b820 [FrameworkBundle] Dont rely on any parent definition for "cache.annotations"
    fabpot committed Nov 26, 2016
  2. bug #20638 Fix legacy tests that do not trigger any depreciation (jul…

    …ienfalque)
    
    This PR was merged into the 3.2 branch.
    
    Discussion
    ----------
    
    Fix legacy tests that do not trigger any depreciation
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.2
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Fixes `implode(): Invalid arguments passed` error when a `@legacy` test with `@expectedDeprecation` does not actually trigger any deprecation.
    
    Commits
    -------
    
    9287b52 Fix tests that do not trigger any depreciation
    nicolas-grekas committed Nov 26, 2016
  3. minor #20639 [Cache] Mark FilesystemAdapterTrait as internal (nicolas…

    …-grekas)
    
    This PR was merged into the 3.2 branch.
    
    Discussion
    ----------
    
    [Cache] Mark FilesystemAdapterTrait as internal
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.2
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    62a1958 [Cache] Mark FilesystemAdapterTrait as internal
    nicolas-grekas committed Nov 26, 2016
  4. minor #20640 [HttpFoundation] Fix isMethodSafe test for cacheables (c…

    …halasr)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [HttpFoundation] Fix isMethodSafe test for cacheables
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Tests pass?   | yes
    | License       | MIT
    
    Commits
    -------
    
    2699009 [HttpFoundation] Fix test ensuring isMethodSafe() checks cacheable
    nicolas-grekas committed Nov 26, 2016
Commits on Nov 25, 2016
  1. Fix tests that do not trigger any depreciation

    julienfalque committed Nov 25, 2016
  2. [HttpFoundation] Fix test ensuring isMethodSafe() checks cacheable

    chalasr committed Nov 25, 2016
  3. [Cache] Mark FilesystemAdapterTrait as internal

    nicolas-grekas committed Nov 25, 2016
  4. Merge branch '3.2'

    * 3.2:
      [Routing] Fail properly when a route parameter name cannot be used as a PCRE subpattern name
      [FrameworkBundle] Improve performance of ControllerNameParser
      Update documentation link to the component
      [HttpFoundation] Add links to RFC-7231
      [DI] Initialize properties before method calls
      [Bridge/Doctrine] Use cache.prefix.seed parameter for generating cache namespace
      Tag missing internals
      Add missing example for 'path' argument in debug:config
      [WebProfilerBundle] Dont use request attributes in RouterController
      Fix complete config tests
    nicolas-grekas committed Nov 25, 2016
  5. Merge branch '3.1' into 3.2

    * 3.1:
      [Routing] Fail properly when a route parameter name cannot be used as a PCRE subpattern name
      [FrameworkBundle] Improve performance of ControllerNameParser
      Update documentation link to the component
      [HttpFoundation] Add links to RFC-7231
      [DI] Initialize properties before method calls
      Tag missing internals
      [WebProfilerBundle] Dont use request attributes in RouterController
      Fix complete config tests
    nicolas-grekas committed Nov 25, 2016
  6. Merge branch '2.8' into 3.1

    * 2.8:
      [Routing] Fail properly when a route parameter name cannot be used as a PCRE subpattern name
      [FrameworkBundle] Improve performance of ControllerNameParser
      Update documentation link to the component
      [HttpFoundation] Add links to RFC-7231
      [DI] Initialize properties before method calls
      Tag missing internals
      [WebProfilerBundle] Dont use request attributes in RouterController
      Fix complete config tests
    nicolas-grekas committed Nov 25, 2016
  7. Merge branch '2.7' into 2.8

    * 2.7:
      [Routing] Fail properly when a route parameter name cannot be used as a PCRE subpattern name
      [FrameworkBundle] Improve performance of ControllerNameParser
      Update documentation link to the component
      [HttpFoundation] Add links to RFC-7231
      [DI] Initialize properties before method calls
      Tag missing internals
      [WebProfilerBundle] Dont use request attributes in RouterController
      Fix complete config tests
    nicolas-grekas committed Nov 25, 2016
  8. bug #20374 [FrameworkBundle] Improve performance of ControllerNamePar…

    …ser (enumag)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Improve performance of ControllerNameParser
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets |
    | License       | MIT
    | Doc PR        |
    
    Today I was searching for bottlenecks in my application using Blackfire. And among other things I found one in Symfony. Blackfire showed that `Symfony\Bundle\FrameworkBundle\Controller\ControllerNameParser::findAlternative()` was called almost 300 times which took 28 miliseconds.
    
    It turns out that `Symfony\Bundle\FrameworkBundle\Routing\DelegatingLoader::load()` is calling `ControllerNameParser::parse()` without actually needing to do so because `$controller` is in the class::method notation already. `ControllerNameParser` threw an exception, DelegatingLoader caught and ignored it - that's ok. The problem is that generating the exception message took a lot of time because findAlternative is slow. In my case it called the levenshtein function over 5000 times which was completely useless because the exception is ignored anyway.
    
    Commits
    -------
    
    cf333f3 [FrameworkBundle] Improve performance of ControllerNameParser
    nicolas-grekas committed Nov 25, 2016
  9. bug #20474 [Routing] Fail properly when a route parameter name cannot…

    … be used as a PCRE subpattern name (fancyweb)
    
    This PR was squashed before being merged into the 2.7 branch (closes #20474).
    
    Discussion
    ----------
    
    [Routing] Fail properly when a route parameter name cannot be used as a PCRE subpattern name
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#7139
    
    This is a follow up PR to #20327.
    
    I also decided to improve the current `is_numeric()` check that is done by a truer one. The current limitation is that a PCRE subpattern name must not start with a digit which is different.
    
    Commits
    -------
    
    73fbd08 [Routing] Fail properly when a route parameter name cannot be used as a PCRE subpattern name
    nicolas-grekas committed Nov 25, 2016
  10. [Routing] Fail properly when a route parameter name cannot be used as…

    … a PCRE subpattern name
    fancyweb committed with nicolas-grekas Nov 10, 2016
  11. [FrameworkBundle] Improve performance of ControllerNameParser

    enumag committed Nov 1, 2016
  12. minor #20587 [SecurityBundle] Fix complete config tests (julienfalque)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [SecurityBundle] Fix complete config tests
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Fixes a little bug in `*CompleteConfigurationTest`: if a test fails for one format, subsequent tests for other formats will also fail. This is because subsequent tests actually use the container built from the very first tested config, which is PHP if all tests are ran.
    
    This can be reproduced by changing a value in the PHP config fixtures. `PhpCompleteConfigurationTest` will fail as expected but `XmlCompleteConfigurationTest` and `YamlCompleteConfigurationTest` will fail too, which is not expected.
    
    Commits
    -------
    
    b25c1d3 Fix complete config tests
    nicolas-grekas committed Nov 25, 2016
  13. minor #20629 [Form] [Validator] Update documentation link to the comp…

    …onent (CoolGoose)
    
    This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #20629).
    
    Discussion
    ----------
    
    [Form] [Validator] Update documentation link to the component
    
    - [x] Update documentation link to the component since it has standalone examples
    
    Commits
    -------
    
    25a6294 Update documentation link to the component
    nicolas-grekas committed Nov 25, 2016
  14. Update documentation link to the component

    Update documentation link to the component since it has standalone examples
    CoolGoose committed with nicolas-grekas Nov 25, 2016
  15. minor #20622 [WebProfilerBundle] Dont use request attributes in Route…

    …rController (nicolas-grekas)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [WebProfilerBundle] Dont use request attributes in RouterController
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    As spotted in #20621, it makes little sense to use request attributes here, and if it were to have, the current code is broken because the returned values here have already been processed by ValueExporter in RequestDataCollector.
    
    Commits
    -------
    
    962325a [WebProfilerBundle] Dont use request attributes in RouterController
    nicolas-grekas committed Nov 25, 2016
  16. minor #20630 [HttpFoundation] Add links to RFC-7231 (nicolas-grekas)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [HttpFoundation] Add links to RFC-7231
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | no
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    ping @xabbuh
    
    Commits
    -------
    
    c17a85b [HttpFoundation] Add links to RFC-7231
    nicolas-grekas committed Nov 25, 2016
  17. minor #20625 [FrameworkBundle] Add missing example for 'path' argumen…

    …t in debug:config (chalasr)
    
    This PR was merged into the 3.2 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Add missing example for 'path' argument in debug:config
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 3.2
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    The argument has been introduced in #18940 .
    
    Commits
    -------
    
    c6b7aeb Add missing example for 'path' argument in debug:config
    nicolas-grekas committed Nov 25, 2016
  18. minor #20626 Tag missing internals (ogizanagi)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Tag missing internals
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | N/A
    | License       | MIT
    | Doc PR        | N/A
    
    Commits
    -------
    
    97e94b4 Tag missing internals
    nicolas-grekas committed Nov 25, 2016