Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let's stop adding the v prefix on tags #10441

Closed
cordoval opened this issue Mar 13, 2014 · 4 comments
Closed

let's stop adding the v prefix on tags #10441

cordoval opened this issue Mar 13, 2014 · 4 comments

Comments

@cordoval
Copy link
Contributor

@cordoval cordoval commented Mar 13, 2014

let's stop adding the v prefix on tags

it promotes practices that are different from semver
although most of the stuff would work, others can copy this approach and repeat it.

Of course it could be worst:

not so correct
https://github.com/zendframework/zf2/releases
https://github.com/laravel/framework/releases

correct imo
https://github.com/Ocramius/ProxyManager/releases

@fabpot
Copy link
Member

@fabpot fabpot commented Mar 13, 2014

Closing this as we won't change this now.

@fabpot fabpot closed this Mar 13, 2014
@cordoval
Copy link
Contributor Author

@cordoval cordoval commented Mar 13, 2014

it is never late https://github.com/gushphp/gush/releases but I guess it could potentially break all other automation around it. I agree then.

@stof
Copy link
Member

@stof stof commented Mar 13, 2014

Semver does not forbid using a v prefix (actually, the semver spec itself prefixes its versions: https://github.com/mojombo/semver/tags). Semver is about the version number, not the tag name

And the v prefix is nice for the autocompletion of git branches: it avoids getting all tags in the autocompletion when switching to the 2.3 branch (which would make the autocompletion totally unusable)

@cordoval
Copy link
Contributor Author

@cordoval cordoval commented Mar 13, 2014

oh wow, thanks @stof, i will switch Gush back to v then 👶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants