[Process] Deprecate Process::setStdin in favor of Process::setInput #10932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1038,10 +1038,22 @@ public function setEnv(array $env) | |||
| * Gets the contents of STDIN. | |||
| * | |||
| * @return string|null The current contents | |||
| * | |||
| * @deprecated As of Symfony 2.6 This method is deprecated in favor of setInput | |||
romainneutron
changed the title
|
PR updated, typo fixed |
| @@ -224,7 +224,7 @@ public function mustRun($callback = null) | |||
| } | |||
|
|
|||
| /** | |||
| * Starts the process and returns after sending the STDIN. | |||
| * Starts the process and returns after writing the input to STDIN. | |||
There was a problem hiding this comment.
It does not always write to stdin anymore, does it?
There was a problem hiding this comment.
If an input is passed, yes it's written to the underlying process's stdin.
|
PR Updated, comments addressed |
|
|
||
| ### Process | ||
|
|
||
| * Process::setStdin and Process::getStdin have been removed. Use |
There was a problem hiding this comment.
The method names should end with ()
|
@fabpot updated, changed target to 2.5 instead of 2.6 |
|
Thanks @romainneutron. |
fabpot
added a commit
that referenced
this pull request
May 22, 2014
…ess::setInput (romainneutron) This PR was merged into the 2.3-dev branch. Discussion ---------- [Process] Deprecate Process::setStdin in favor of Process::setInput | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | n/a | License | MIT From the `Process` point of view, what we pass is an *input*, as well as we retrieve *output* and *error output*. As we use `getOutput` and `getErrorOutput` we should use `setInput` and let the underlying `ProcessPipes` deal with the actual `STDIN`. By the way, `ProcessBuilder` already has `setInput` method and no `setStdin` method Commits ------- 53b9d73 [Process] Deprecate Process::setStdin in favor of Process::setInput
|
it does not pass tests... please change tested exception messages! |
|
Thanks for the report @MarcomTeam. The issue has been introduced while merging 2.3 in master. A PR has been submitted, it should be fixed soon. |
fabpot
added a commit
that referenced
this pull request
May 22, 2014
…recation (romainneutron) This PR was merged into the 2.3-dev branch. Discussion ---------- [Process] Fix conflicts between latest 2.3 fix and 2.5 deprecation | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT As reported in #10932 (comment), it's been introduced when merging 2.3 in master Commits ------- 3454d60 [Process] Fix conflicts between latest 2.3 fix and 2.5 deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the
Processpoint of view, what we pass is an input, as well as we retrieve output and error output.As we use
getOutputandgetErrorOutputwe should usesetInputand let the underlyingProcessPipesdeal with the actualSTDIN.By the way,
ProcessBuilderalready hassetInputmethod and nosetStdinmethod