Overriding test.client.parameters for HTTP_HOST does not work with WebTestCase

[adrienbrault]

Hi,

I've tried to override the test client HTTP_HOST server param in my app config:

parameters:
    test.client.parameters:
        HTTP_HOST: symfony.com

However, in functional tests (WebTestCase), $client->getServerParameter('HTTP_HOST') does not return symfony.com but the default localhost.

The client is actually correctly configured at

symfony/src/Symfony/Bundle/FrameworkBundle/Test/WebTestCase.php

Line 35 in cf3cd95

$client = static::$kernel->getContainer()->get('test.client');

but the call on the next line $client->setServerParameters($server); with an empty array erases HTTP_HOST because of the method definition:

symfony/src/Symfony/Component/BrowserKit/Client.php

Lines 113 to 119 in cf3cd95

	public function setServerParameters(array $server)
	{
	$this->server = array_merge(array(
	'HTTP_HOST' => 'localhost',
	'HTTP_USER_AGENT' => 'Symfony2 BrowserKit',
	), $server);
	}

[stayeronglass]

any progress?

[jakzal]

should be fixed by #16265

[aistis-]

Does anyone face the same problem with other parameters?

# config_test.yml
...
parameters:
    test.client.parameters:
        HTTPS: true

[MacDada]

That's still an issue when using a default WebTestCase:

# services_test.yml
parameters:
    test.client.parameters:
        HTTP_HOST: 'example.dev'

The config works and in the Client constructor the host is being configured: https://github.com/symfony/symfony/blob/v3.4.45/src/Symfony/Component/BrowserKit/Client.php#L55

BUT, WebTestCase overrides it: https://github.com/symfony/symfony/blob/v3.4.45/src/Symfony/Bundle/FrameworkBundle/Test/WebTestCase.php#L45

And that forces me to override WebTestCase and set proper host manually instead of depending on config.

---

Possible solution: #20535 – it was a good one – overriding just the parameters that are needed, not all of them.

There was a concern about BC, but it can be handled: #20535 (comment)

I can make a new PR if this is acceptable solution.

[MacDada]

Where should I add test for that?