[PropertyAccess] Fixed invalid feedback -> foodback singularization #13618
Conversation
wouterj
commented
Feb 7, 2015
wouterj
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #13613 |
| License | MIT |
| Doc PR | - |
|
@fabpot maybe it's better if fabbot would ignore these 2 files when checking for typos :) |
| @@ -67,6 +68,7 @@ public function singularifyProvider() | |||
| array('emphases', array('emphas', 'emphase', 'emphasis')), | |||
| array('faxes', 'fax'), | |||
| array('feet', 'foot'), | |||
| array('feedback', 'feedback'), | |||
There was a problem hiding this comment.
Isn't it a problem to have the same plural and singular?
There was a problem hiding this comment.
Hmm, I'm not sure what you mean. Feedback is not a coutable noun and by that, it can't be pluralized. See http://english.stackexchange.com/questions/176805/plural-of-feedback
The StringUtil already coped with this well, the only bug was that it was replacing all words with "ee" in it and longer than 3 characters with "oo", turing "feedback" into "foodback".
This PR adds "feedback" as an exception to this replacement statement (we may benefit from a more general fix for this, but I do not consider myself skilled enough to do that).
There was a problem hiding this comment.
@wouterj I think the question was more related to problems in how property accessor uses singular/plural forms, and possible issues when these forms are the same.
There was a problem hiding this comment.
Exactly, I was just wondering if having the same word for a singular and a plural would not lead to issues when using such code. getFeedback() -> plural or singular? $this->feedback -> plural or singular?
There was a problem hiding this comment.
I don't think Symfony has to worry about it? (or maybe I'm not fully aware of the usage of this class) Does it matter to Symfony whether getFeedback() is a plural or a singular? It might not be the best choice because of this, but that's a problem of the project imo.
|
Thank you @wouterj. |
…arization (WouterJ) This PR was merged into the 2.3 branch. Discussion ---------- [PropertyAccess] Fixed invalid feedback -> foodback singularization | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #13613 | License | MIT | Doc PR | - Commits ------- bc50125 Fixed invalid feedback -> foodback singularization
