[FrameworkBundle] fixes displaying of deprecation notices. #14182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hhamon
commented
Apr 2, 2015
hhamon
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
hhamon
force-pushed
the
webprofiler-deprecations-fix
branch
3 times, most recently
from
5dcfb74
to
71e19de
Compare
| @@ -16,7 +16,7 @@ | |||
| <tag name="monolog.logger" channel="php" /> | |||
| <argument /><!-- Exception handler --> | |||
| <argument type="service" id="logger" on-invalid="null" /> | |||
| <argument /><!-- Log levels map for enabled error levels --> | |||
| <argument>null</argument><!-- Log levels map for enabled error levels --> | |||
There was a problem hiding this comment.
For reference, here is the line that controls what happens in prod:
https://github.com/hhamon/symfony/blob/71e19de147f9d5c7688a827b2915510f298470eb/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L145
hhamon
force-pushed
the
webprofiler-deprecations-fix
branch
from
71e19de
to
ab37040
Compare
|
👍 |
1 similar comment
|
👍 |
|
Thank you @hhamon. |
fabpot
added a commit
that referenced
this pull request
Apr 3, 2015
… (hhamon) This PR was merged into the 2.6 branch. Discussion ---------- [FrameworkBundle] fixes displaying of deprecation notices. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- ab37040 [FrameworkBundle] fixes displaying of deprecation notices.
fabpot
added a commit
that referenced
this pull request
May 19, 2015
This PR was merged into the 2.6 branch. Discussion ---------- Fix the rendering of deprecation log messages | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14695 | License | MIT | Doc PR | n/a A Twig variable was removed by mistake in #14182 Commits ------- 8b6efff Fix the rendering of deprecation log messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.