Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transient tests hunting #15617

Closed
nicolas-grekas opened this issue Aug 25, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@nicolas-grekas
Copy link
Member

commented Aug 25, 2015

Let's link travis/appveyor failures to this issue, and fix tests volatility.

nicolas-grekas added a commit that referenced this issue Oct 10, 2015

minor #16191 [HttpFoundation] Extend ClockMock to session storage tes…
…ts (nicolas-grekas)

This PR was merged into the 2.3 branch.

Discussion
----------

[HttpFoundation] Extend ClockMock to session storage tests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15617
| License       | MIT
| Doc PR        | -

Commits
-------

93a06df [HttpFoundation] Extend ClockMock to session storage tests

fabpot added a commit that referenced this issue Oct 13, 2015

minor #16221 [Http*] Mock time() to fix transient tests (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[Http*] Mock time() to fix transient tests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15617
| License       | MIT
| Doc PR        | -

Commits
-------

fa604d3 [Http*] Mock time() to fix transient tests

fabpot added a commit that referenced this issue Oct 28, 2015

minor #16362 [HttpKernel] Add `@group time-sensitive` on some transie…
…nt tests (nicolas-grekas)

This PR was merged into the 2.3 branch.

Discussion
----------

[HttpKernel] Add `@group time-sensitive` on some transient tests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15617
| License       | MIT
| Doc PR        | -

Commits
-------

6a7d270 [HttpKernel] Add `@group time-sensitive` on some transient tests

fabpot added a commit that referenced this issue Nov 4, 2015

minor #16443 [travis] session.gc_probability=0 to fix transient tests…
… on hhvm (nicolas-grekas)

This PR was merged into the 2.3 branch.

Discussion
----------

[travis] session.gc_probability=0 to fix transient tests on hhvm

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15617
| License       | MIT
| Doc PR        | -

Should fix tests failing with:
`ps_files_cleanup_dir: opendir(/var/lib/hhvm/sessions) failed: Permission denied (13)`

Commits
-------

b4dd254 [travis] session.gc_probability=0 to fix transient tests on hhvm

nicolas-grekas added a commit that referenced this issue Nov 27, 2015

minor #16684 [appveyor] Workaround transient segfault when APCu is en…
…abled (nicolas-grekas)

This PR was merged into the 2.3 branch.

Discussion
----------

[appveyor] Workaround transient segfault when APCu is enabled

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15617
| License       | MIT
| Doc PR        | -

See e.g. https://ci.appveyor.com/project/nicolas-grekas/symfony/build/1.0.4#L1186

Commits
-------

12a152b [appveyor] Workaround transient segfault when APCu is enabled

stof added a commit that referenced this issue Dec 5, 2015

minor #16813 [Process] Fix stopping a process on Windows (nicolas-gre…
…kas)

This PR was merged into the 2.3 branch.

Discussion
----------

[Process] Fix stopping a process on Windows

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15617
| License       | MIT
| Doc PR        | -

Commits
-------

80fb51c [Process] Fix stopping a process on Windows

nicolas-grekas added a commit that referenced this issue Dec 8, 2015

minor #16875 [Process] Always call proc_close (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[Process] Always call proc_close

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15617
| License       | MIT
| Doc PR        | -

This should fix one more transient test, and a wrong behavior.

Commits
-------

ccb67d7 [Process] Always call proc_close

fabpot added a commit that referenced this issue Dec 23, 2015

bug #17094 [Process] More robustness and deterministic tests (nicolas…
…-grekas)

This PR was merged into the 2.3 branch.

Discussion
----------

[Process] More robustness and deterministic tests

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16988, #15617
| License       | MIT
| Doc PR        | -

Commits
-------

d1a178a [Process] More robustness and deterministic tests

nicolas-grekas added a commit that referenced this issue Dec 30, 2015

minor #17176 [Process] Fix a transient test (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[Process] Fix a transient test

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15617
| License       | MIT
| Doc PR        | -

Commits
-------

7e2c67c [Process] Fix a transient test

nicolas-grekas added a commit that referenced this issue Dec 30, 2015

bug #17177 [Process] Fix potential race condition leading to transien…
…t tests (nicolas-grekas)

This PR was merged into the 2.3 branch.

Discussion
----------

[Process] Fix potential race condition leading to transient tests

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15617
| License       | MIT
| Doc PR        | -

Sibling of #17176 on 2.3

Commits
-------

99fc428 [Process] Fix potential race condition leading to transient tests
@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Dec 31, 2015

With PHP 5.5

  1. Symfony\Component\HttpKernel\Tests\HttpCache\HttpCacheTest::testAssignsDefaultTtlWhenResponseHasNoFreshnessInformationAndAfterTtlWasExpiredWithStatus304
    Failed asserting that 'public, s-maxage=3' matches PCRE pattern "/s-maxage=2/".
    /home/travis/build/symfony/symfony/src/Symfony/Component/HttpKernel/Tests/HttpCache/HttpCacheTest.php:650

nicolas-grekas added a commit that referenced this issue Feb 2, 2016

minor #17650 [Process] Fix transient tests for incremental outputs (n…
…icolas-grekas)

This PR was merged into the 2.3 branch.

Discussion
----------

[Process] Fix transient tests for incremental outputs

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15617
| License       | MIT
| Doc PR        | -

Commits
-------

90455df [Process] Fix transient tests for incremental outputs

nicolas-grekas added a commit that referenced this issue Feb 4, 2016

minor #17686 [appveyor] Ignore failures due to STATUS_ACCESS_VIOLATIO…
…N errors (nicolas-grekas)

This PR was merged into the 2.3 branch.

Discussion
----------

[appveyor] Ignore failures due to STATUS_ACCESS_VIOLATION errors

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15617
| License       | MIT
| Doc PR        | -

E.g. https://ci.appveyor.com/project/fabpot/symfony/build/1.0.5754#L1525

Commits
-------

1d4ea39 [appveyor] Ignore failures due to STATUS_ACCESS_VIOLATION errors
@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Feb 5, 2016

  1. Symfony\Bundle\SecurityBundle\Tests\Functional\AuthenticationCommencingTest::testAuthenticationIsCommencingIfAccessDeniedExceptionIsWrapped
    RuntimeException: Unable to create the cache directory (/tmp/3.1.0-DEV/StandardFormLogin/cache/securitybundleteststandardformlogin)
    /home/travis/build/symfony/symfony/src/Symfony/Component/HttpKernel/Kernel.php:552
    /home/travis/build/symfony/symfony/src/Symfony/Component/HttpKernel/Kernel.php:476
    /home/travis/build/symfony/symfony/src/Symfony/Component/HttpKernel/Kernel.php:117
    /home/travis/build/symfony/symfony/src/Symfony/Bundle/FrameworkBundle/Test/KernelTestCase.php:146
    /home/travis/build/symfony/symfony/src/Symfony/Bundle/FrameworkBundle/Test/WebTestCase.php:33
    /home/travis/build/symfony/symfony/src/Symfony/Bundle/SecurityBundle/Tests/Functional/AuthenticationCommencingTest.php:18
@xabbuh

This comment has been minimized.

Copy link
Member

commented Mar 15, 2016

1) Symfony\Component\Console\Tests\Helper\ProgressIndicatorTest::testDefaultIndicator
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
  - Starting...
- \ Starting...
+ - Advancing...
  \ Advancing...
- | Advancing...
- | Done...     
+ \ Done...     
  - Starting Again...
  \ Starting Again...
  \ Done Again...    
 '

C:\projects\symfony\src\Symfony\Component\Console\Tests\Helper\ProgressIndicatorTest.php:51

https://ci.appveyor.com/project/fabpot/symfony/build/1.0.7036#L964

@xabbuh

This comment has been minimized.

Copy link
Member

commented Mar 16, 2016

Ah, looks like that test simply always fails on Windows.

nicolas-grekas added a commit that referenced this issue Mar 16, 2016

minor #18200 use the clock mock for progress indicator tests (xabbuh)
This PR was merged into the 3.0 branch.

Discussion
----------

use the clock mock for progress indicator tests

| Q             | A
| ------------- | ---
| Branch?       | 3.0
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15617 (comment)
| License       | MIT
| Doc PR        |

Commits
-------

dbde648 use the clock mock for progress indicator tests
@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Jun 16, 2016

Happy to close this one eventually :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.