[DoctrineBridge] Fix issue which prevent the profiler to explain a query #16306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baachi
force-pushed
the
bugfix/profiler-fix
branch
from
d171422
to
7fd30ee
Compare
Baachi
force-pushed
the
bugfix/profiler-fix
branch
from
7fd30ee
to
3b7bb6b
Compare
| $c = $this->createCollector($queries); | ||
| $c->collect(new Request(), new Response()); | ||
|
|
||
| $collected_queries = $c->getQueries(); |
There was a problem hiding this comment.
Should be camel cased: $collectedQueries.
There was a problem hiding this comment.
I just noticed it's also snaked_cased in the other test case. Feel free to fix that one as well.
There was a problem hiding this comment.
Fixed it in all testcases
|
👍 should be merged to 2.3 status: reviewed |
|
Thank you @Baachi. |
fabpot
added a commit
that referenced
this pull request
Oct 28, 2015
…xplain a query (Baachi) This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes #16306). Discussion ---------- [DoctrineBridge] Fix issue which prevent the profiler to explain a query | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT We currently develop a application which only use the doctrine/dbal and not the orm. And we run into a issue that the profiler can't explained any query. This is because the `SQLLogger` will pass `null` instead of an empty array. And the `sanitizeQuery` method will currently transform this to `array(null)` which leads to an error. I created an fork, so everyone can reproduce this. https://github.com/Baachi/symfony-standard Commits ------- 3490e98 [DoctrineBridge] Fix issue which prevent the profiler to explain a query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently develop a application which only use the doctrine/dbal and not the orm. And we run into a issue that the profiler can't explained any query.
This is because the
SQLLoggerwill passnullinstead of an empty array. And thesanitizeQuerymethod will currently transform this toarray(null)which leads to an error.I created an fork, so everyone can reproduce this.
https://github.com/Baachi/symfony-standard