Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate support for absolute path in templating #17999

Closed
fabpot opened this issue Mar 3, 2016 · 1 comment
Closed

Deprecate support for absolute path in templating #17999

fabpot opened this issue Mar 3, 2016 · 1 comment

Comments

@fabpot
Copy link
Member

@fabpot fabpot commented Mar 3, 2016

see #17894 and related.

@robfrawley

This comment has been minimized.

Copy link
Contributor

@robfrawley robfrawley commented Mar 4, 2016

Absolute paths seem like an awfully limiting choice. Using the "Symfony syntax" allows for both core and users to change defaults in directory structure in future releases painlessly, as it wouldn't affect the actual callouts within templates. It's also shorter to type. ;-)

I'm not too familiar with the handling of template resolution and loading within the framework, but based on my experience with Symfony elsewhere, I'm confident those who want absolute paths can easily achieve such with a custom loader implementation.

👍

fabpot added a commit that referenced this issue Mar 15, 2016
…akzal)

This PR was merged into the 3.1-dev branch.

Discussion
----------

[FrameworkBundle] Deprecate absolute template paths

| Q             | A
| ------------- | ---
| Branch        | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #17999
| License       | MIT
| Doc PR        | -

Commits
-------

85a9d67 [FrameworkBundle] Deprecate absolute template paths
@fabpot fabpot closed this Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.