[FrameworkBundle] Fix unresolved parameters from default configs in debug:config

[chalasr]

Q	A
Branch?	2.7
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

When using the debug:config command, if the dumped configuration is explicitly defined by the user, then parameters are properly resolved in the output. If it is not, and values come from the bundle default configuration directly, they are not.

Steps to reproduce:

• Checkout the symfony demo
• Run debug:config twig
• Look at the debug key, it is the kernel.debug parameter properly resolved: true
• Look at the cache key, it is not resolved: '%kernel.cache_dir%/twig'

This fixes it by resolving configs once again after processing the configuration.
ping @weaverryan

[ogizanagi]

👍

Status: Reviewed

[nicolas-grekas]

Maybe not what you'd expect, yet the current behavior on 2.7 is consistent, not buggy.
If we need to reconsider this, we should do it on 3.3 IMHO.

[chalasr]

@nicolas-grekas Not sure to understand. Why should parameters be resolved only for explicitly defined configuration?

On the current 2.7, I can get both %kernel.root_dir% for a key and its value for another, imho it's not a consistent behavior. Whether we dump placeholders or values, but not both.

[chalasr]

Maybe it's not clear what I mean.

config:

twig:
    debug:            "%kernel.debug%"
    strict_variables: "%kernel.debug%"
    form_themes:
        - "bootstrap_3_layout.html.twig"
        - "form/fields.html.twig"

output before:

output after:

I find the debug:config command especially useful to be aware of what is configured implicitly (i.e. default bundle configurations), which is no more true if the output doesn't contain real values, and quite confusing if one key contains the real value and the second doesn't.

[chalasr]

So isn't this the expected behavior? Is there any blocker for merging this as a bugfix?

[nicolas-grekas]

👍

[stof]

👍

[fabpot]

Thanks for fixing this bug @chalasr.