[PropertyAccess] Handle interfaces in the invalid argument exception #21360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this? |
xabbuh
reviewed
Jan 25, 2017
|
|
||
| /** | ||
| * @expectedException \Symfony\Component\PropertyAccess\Exception\InvalidArgumentException | ||
| * @expectedExceptionMessage Expected argument of type "Countable", "string" given |
There was a problem hiding this comment.
I would have expected a test checking for the new "must implement interface" string in the exception message.
There was a problem hiding this comment.
I don't get it : the "must implement interface" comes from the PHP exception that is handled and then the InvalidArgumentException is thrown.
There was a problem hiding this comment.
Sorry, you are right. I misread the changes you made.
|
Thank you @fancyweb. |
fabpot
added a commit
that referenced
this pull request
Jan 25, 2017
… exception (fancyweb) This PR was squashed before being merged into the 2.7 branch (closes #21360). Discussion ---------- [PropertyAccess] Handle interfaces in the invalid argument exception | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | - | License | MIT | Doc PR | - Before : `Expected argument of type "dule\MenuBundle\Entity\AbstractMenu::setMenuElements() must implement interface Doctrine\Common\Collections\Collection", "array" given` After : `Expected argument of type "Doctrine\Common\Collections\Collection", "array" given` Commits ------- be52b39 [PropertyAccess] Handle interfaces in the invalid argument exception
Merged
This was referenced Feb 6, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before :
Expected argument of type "dule\MenuBundle\Entity\AbstractMenu::setMenuElements() must implement interface Doctrine\Common\Collections\Collection", "array" givenAfter :
Expected argument of type "Doctrine\Common\Collections\Collection", "array" given