Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[RFC] [BrowserKit] HTTPS and HTTP_HOST - uri vs server precedence #22933
The problem comes from the precedence of the uri passed to the client over the server parameters.
I must say I don't really understand the original bug since we're simulating the http context, and why we had to fix it since the fix basically reverts #10549.
And if there was a problem back then for HTTP_HOST, it still exists for HTTPS.
I encountered the BC break while migrating an app from Symfony 2.6 to 2.8.
Use case: dynamic sub domains need to be defined per request and this was done thanks to the server var
I understand that it is now too late to revert that fix in 2.x branches, but I think we should definitely fix this is 3.4 by deprecating one way or the other, because in the end, the uri requested is not "synchronized" with those variables in some cases.
I suggest to deprecated the precedence of the guessing from uri in favor of server parameters for both HTTPS and HOST.
What do you think is best? Thanks!