New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctrine bigint from int to string #23406

Closed
steevanb opened this Issue Jul 5, 2017 · 3 comments

Comments

Projects
None yet
5 participants
@steevanb

steevanb commented Jul 5, 2017

Q A
Bug report? yes
Feature request? no
BC Break report? yes
RFC? no
Symfony version 3.2.10

Hi :)

This PR is a huge BC : https://github.com/symfony/symfony/pull/22988/files

Every PHP 7 return type are broken :

public function getId(): int {}

Every test with === are broken :

if ($id === 1) {}

I understand bigint is a problem in PHP, but i don't think this BC is the solution ... All my application is down, and i think i'm not alone ;)

@fabpot

This comment has been minimized.

Member

fabpot commented Jul 5, 2017

@dunglas

This comment has been minimized.

Member

dunglas commented Jul 5, 2017

It was a bug since the very beginning. Doctrine explicitly documents bigint as being converted to string.
The mentionned PR does'nt change the behavior. It just fixes the type mismatch (Doctrine will return a string anyway).

@steevanb

This comment has been minimized.

steevanb commented Jul 5, 2017

Ok, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment