New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ClassLoader] provide a tool chain to generate class maps #2407

Closed
lsmith77 opened this Issue Oct 16, 2011 · 3 comments

Comments

Projects
None yet
4 participants
@lsmith77
Contributor

lsmith77 commented Oct 16, 2011

it appears we do not have tools to generate a class map to be used in the map class loader. maybe we should even provide a command. then again maybe this should be handled by https://github.com/sensio/SensioDistributionBundle/tree/master/Resources/bin ?

@stof

This comment has been minimized.

Show comment
Hide comment
@stof

stof Oct 16, 2011

Member

I disagree about putting it in SensioDistributionBundle. Due to the way it works, this bundle breaks everything when your app does not use the parameters.yml (previously .ini) file to set some of the parameters. My own projects don't use this file so other features added in the bundle would simply be unusable in this case.

Member

stof commented Oct 16, 2011

I disagree about putting it in SensioDistributionBundle. Due to the way it works, this bundle breaks everything when your app does not use the parameters.yml (previously .ini) file to set some of the parameters. My own projects don't use this file so other features added in the bundle would simply be unusable in this case.

fabpot added a commit that referenced this issue Feb 6, 2012

merged branch thesalla/mapfiledumper (PR #2471)
Commits
-------

ba3b321 [ClassLoader] Added a class map file generator utility

Discussion
----------

[ClassLoader] Added a class map file generator utility

Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #2407

---------------------------------------------------------------------------

by lsmith77 at 2011-11-30T19:33:52Z

@thesalla do you have time/interest to finish this up?

---------------------------------------------------------------------------

by thesalla at 2011-12-01T09:55:50Z

sure (will attempt at least), but no sooner than tomorrow

---------------------------------------------------------------------------

by stof at 2011-12-12T20:41:41Z

@thesalla @fabpot what is the state of this PR ?

---------------------------------------------------------------------------

by thesalla at 2011-12-17T19:36:58Z

If you don't have any other suggestions or ideas, I'd consider it finished.

---------------------------------------------------------------------------

by lsmith77 at 2012-01-24T09:27:12Z

ping

---------------------------------------------------------------------------

by fabpot at 2012-02-02T08:21:38Z

@thesalla: Can you rename the ClassMapDumper class to ClassMapGenerator and then squash your commit before the merge? Thanks.

---------------------------------------------------------------------------

by thesalla at 2012-02-04T12:55:48Z

@fabpot done.
@sliver

This comment has been minimized.

Show comment
Hide comment
@sliver

sliver Mar 3, 2012

How about provide it first, no better where it is. This could help performance a lot.
Or, since symfony-standard is using composer, we could put it in there. Check this composer/composer#127

sliver commented Mar 3, 2012

How about provide it first, no better where it is. This could help performance a lot.
Or, since symfony-standard is using composer, we could put it in there. Check this composer/composer#127

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Mar 3, 2012

Member

We have a class map generator now in master, so closing this issue.

Member

fabpot commented Mar 3, 2012

We have a class map generator now in master, so closing this issue.

@fabpot fabpot closed this Mar 3, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment