Enable / disable form in configuration

[steevanb]

Q	A
Bug report?	yes
Feature request?	no
BC Break report?	yes
RFC?	no
Symfony version	3.3.*

Hi !

In app/config/config.yml, this 2 configurations should have same behavior :

framework:
    form: ~

framework:
    # no form key

But first one enable form, and second one, disable it (framework.form.enabled default value is false : https://symfony.com/doc/current/reference/configuration/framework.html#reference-form-enabled)

Or maybe ~ is not exactly same as "default values" ?
In this case, how can we know differences between ~ and default values ?

[chalasr]

This is a documentation issue, as of 3.3 the framework.form.enabled config option is default true if you are requiring symfony/symfony.

[chalasr]

See symfony/symfony-docs#8412

[steevanb]

So, i don't understand why form: ~ and no form key does not have same behavior ?

[chalasr]

Just tried out, not adding the form key at all gives enabled: false at end. ping @ogizanagi

[steevanb]

When i dump Configuration object, i have 2 properties : $defaultValue = false, and $default = true.

I'm not sure about it, but maybe when you define form key, default value is readed in $default, not $defaultValue ?

[ogizanagi]

If you're using the fullstack (symfony/symfony), the framework.form node is built using canBeEnabled (for BC reasons, as the original way before the framework Configuration object was tweaked in #21196 was to have everything disabled by default).

So

framework:
    form: ~

is not the same as

framework:
    # no form key

because canBeEnabled treats null as ['enabled' => true]. The ~ char in yaml does not mean "take default values". It's just null. What is really configured behind depends on the way the node was built.

#21196 changed the framework Configuration object for Flex projects in order to cleverly auto-enable available features according to the components you've installed. So given you're using flex in your project instead of the fullstack and have the symfony/form component installed, canBeDisabled is used, which means no framework.form key is even required, as it defaults to ['enabled' => true] when not set.

So in conclusion, I see no issue here, unless I missed something.

Thanks for opening this though. We should probably upgrade the documentation to explain how defaults behaves with Flex. symfony/symfony-docs#8412 will be a good start.

[steevanb]

Ok, to me, that's a bug.

But if you don't think so ...