New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VarDumper] New Version of Chrome(62.0.3202.66) cannot render dd function in network preview window #24688

Closed
friparia opened this Issue Oct 25, 2017 · 7 comments

Comments

Projects
None yet
6 participants
@friparia

friparia commented Oct 25, 2017

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no
Symfony version 3.3

Description:

When updated to chrome version 62.0.3202.66, dd function cannot be rendered by chrome network preview window.

fzr n2qqt 1c4hpj wu6a

And I have found the changelog of chrome. This commit says it will not render as HTML agressively if requested via XHR. It will use base64 to encode the response body first, and then render the html, so it may cause javascript not be rendered ?

Steps To Reproduce:

  1. Update to chrome version 62.0.3202.66
  2. Execute a dd function
  3. Check the chrome network preview window

This bug is found in laravel framework when using the symfony/var-dumper package.

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Oct 25, 2017

Member

@friparia do you know any way to make it work again? Can it be made to work at all now?

Member

nicolas-grekas commented Oct 25, 2017

@friparia do you know any way to make it work again? Can it be made to work at all now?

@friparia

This comment has been minimized.

Show comment
Hide comment
@friparia

friparia Oct 25, 2017

Well, I have found the newly updated chrome network preview also cannot render pure html document.

It is not a symfony bug, it is a chrome bug.

friparia commented Oct 25, 2017

Well, I have found the newly updated chrome network preview also cannot render pure html document.

It is not a symfony bug, it is a chrome bug.

@friparia friparia closed this Oct 25, 2017

@jasonvarga

This comment has been minimized.

Show comment
Hide comment
@jasonvarga

jasonvarga Nov 7, 2017

This is not a solution, just a workaround - but I noticed that Chrome will render errors as HTML, so setting the response code first will bypass the new behavior.

http_response_code(500);
dd('foo');

Of course, it means the request will also be a 500.

jasonvarga commented Nov 7, 2017

This is not a solution, just a workaround - but I noticed that Chrome will render errors as HTML, so setting the response code first will bypass the new behavior.

http_response_code(500);
dd('foo');

Of course, it means the request will also be a 500.

@joebenson

This comment has been minimized.

Show comment
Hide comment
@joebenson

joebenson Nov 22, 2017

For convenience until it's resolved, consider creating a new helper function:

function ddd(...$args){
    http_response_code(500);
    call_user_func_array('dd', $args);
}

joebenson commented Nov 22, 2017

For convenience until it's resolved, consider creating a new helper function:

function ddd(...$args){
    http_response_code(500);
    call_user_func_array('dd', $args);
}
@iulian34

This comment has been minimized.

Show comment
Hide comment
@iulian34

iulian34 Nov 24, 2017

This problem is on all browsers. Tested with Chrome/Firefox/Edge/Opera

iulian34 commented Nov 24, 2017

This problem is on all browsers. Tested with Chrome/Firefox/Edge/Opera

@kylesean

This comment has been minimized.

Show comment
Hide comment
@kylesean

kylesean Nov 28, 2017

@iulian34 ,So,the issue lies in the dd method?

kylesean commented Nov 28, 2017

@iulian34 ,So,the issue lies in the dd method?

@friparia

This comment has been minimized.

Show comment
Hide comment
@friparia

friparia Jun 22, 2018

new version of chrome has fixed this...

friparia commented Jun 22, 2018

new version of chrome has fixed this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment