Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide intuitive error message when a controller fails because it's not registered as a service #27787

Open
nicolas-grekas opened this Issue Jul 1, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jul 1, 2018

Would make symfony/symfony-docs#7988 unneeded.

When a controller is not found as a service, is thus directly instantiated, but fails as described in #23033 (Symfony requires that you provide a value for the $passwordEncoder argument), could we provide a nicer error message, e.g. by registering a very late argument resolver?

@gonzalovilaseca

This comment has been minimized.

Copy link
Contributor

gonzalovilaseca commented Jul 5, 2018

@nicolas-grekas I can help with this but I'd need some clarification first: Are you sugesting registering an argument resolver that is executed after ServiceValueResolver, supports controllers and just throws an exception with a nice error message?

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

nicolas-grekas commented Feb 25, 2019

@gonzalovilaseca correct!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.