Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form][Date] date_format option in datetime form fields #2849

Closed
dinamic opened this issue Dec 12, 2011 · 3 comments

Comments

Projects
None yet
5 participants
@dinamic
Copy link

commented Dec 12, 2011

Specifying 'date_format' in a datetime form field does not work if 'widget' => 'single_text' has been used.

I've found several pull requests for this issue, but none of them seem to be merged, so the problem persist in 2.0.

I hope it will get fixed soon.

@stealth35

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2011

could you post your test code

@alexandresalome

This comment has been minimized.

Copy link
Contributor

commented Jan 21, 2012

Any update of this issue?

@webmozart

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2012

See #3162

fabpot added a commit that referenced this issue Jul 11, 2012

merged branch bschussek/issue3162 (PR #4839)
Commits
-------

ded6c03 [Form] DateTimeType now handles RFC 3339 dates as provided by HTML5
7e8b622 [Form] Added the option "format" to DateTimeType
9eeb200 [Form] Changed the default format of DateType to "yyyy-MM-dd" to support HTML 5 out of the box
d621a76 [Form] Improved DateTimeType code

Discussion
----------

[Form] Changed DateType and DateTimeType to support HTML5 by default

Bug fix: no
Feature addition: yes
Backwards compatibility break: yes
Symfony2 tests pass: yes
Fixes the following tickets: #2849, #3162
Todo: -

This PR changes DateType and DateTimeType to support HTML5 by default when setting the option "widget" to "single_text".

Also, the option "format" was added to DateTimeType.

---------------------------------------------------------------------------

by stof at 2012-07-10T15:38:44Z

This loos OK to me

---------------------------------------------------------------------------

by MDrollette at 2012-07-10T16:36:26Z

@stof typo: "looks" #meta-stoffed

@fabpot fabpot closed this Jul 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.