check_cs incompatible with javascript #2961

Closed
ghost opened this Issue Dec 26, 2011 · 0 comments

1 participant

@ghost

The check_cs script scan .twig files which may contain javascript. However, javascript syntax for else if requires a space which conflicts with the coding standards checks. Either the script should change to exclude .twig files or the coding standard should be amended to include a space in else if.

@fabpot fabpot added a commit that closed this issue Dec 28, 2011
@fabpot fabpot merged branch aerialls/check_cs_fix (PR #2975)
Commits
-------

0797564 [Check CS] don't replace 'else if' on twig files (closes #2961)

Discussion
----------

[Check CS] don't replace 'else if' on twig files (closes #2961)
e6c6b46
@fabpot fabpot closed this in e6c6b46 Dec 28, 2011
@mmucklo mmucklo pushed a commit that referenced this issue May 23, 2013
@fabpot fabpot merged branch aerialls/check_cs_fix (PR #2975)
Commits
-------

0797564 [Check CS] don't replace 'else if' on twig files (closes #2961)

Discussion
----------

[Check CS] don't replace 'else if' on twig files (closes #2961)
f2f863d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment