Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle][DX] Where are the deprecation messages coming from? #29876

Closed
gharlan opened this issue Jan 14, 2019 · 6 comments

Comments

Projects
None yet
7 participants
@gharlan
Copy link
Contributor

commented Jan 14, 2019

Example:

screenshot 2019-01-14 12 36 24

Now I want to help and fix all of them by creating pull requests to the corresponding bundles.
But which bundles are affected?

I click on "Show trace":

screenshot 2019-01-14 12 40 06

Ok, stof/doctrine-extensions-bundles is one of them. There is already a PR for this, so nothing to do for me.

So how do I get the other affected bundles? Do I have to wait for the fix in stof/doctrine-extensions-bundles to see the next affected bundle?

@mhujer

This comment has been minimized.

Copy link
Contributor

commented Jan 20, 2019

@gharlan As a workaround, you can get the other errors by updating the package to the branch fixed in fork (see composer docs)

I already asked same thing some time before in #29392 - the reason given was performance (if there were hundreds of errors, the dev mode performance would be terrible).

But maybe we can either collect at least some arbitrary number of errors without grouping (e.g. 5 or 10) or make it configurable.

@Simperfit

This comment has been minimized.

Copy link
Contributor

commented Apr 6, 2019

@mhujer Do you want to work on something like this ?

@mhujer

This comment has been minimized.

Copy link
Contributor

commented Apr 7, 2019

@Simperfit feel free to work on it :-) My comment above was just an idea how to resolve it, not a plan to work on it.

@curry684

This comment has been minimized.

Copy link
Contributor

commented Apr 7, 2019

@stof should just fix his bundle 😉

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

A solution would be to add some context in the deprecation message itself. That would help defeat aggregation.
PR welcome.

@Simperfit

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

I'm looking into it.

@fabpot fabpot closed this Apr 9, 2019

fabpot added a commit that referenced this issue Apr 9, 2019

feature #31027 [Config] Deprecate TreeBuilder::root (gharlan)
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Config] Deprecate TreeBuilder::root

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   |
| Fixed tickets | #29876
| License       | MIT
| Doc PR        | —

Alternative idea to #31015. Or is the `root` method still needed?

It would look like this:

![Screenshot 2019-04-09 01 15 04](https://user-images.githubusercontent.com/330436/55762865-fbd85900-5a64-11e9-9680-0870c85d1c09.png)

Commits
-------

ff6bc79 Deprecate TreeBuilder::root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.