Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Being able to have more than one initial_place when using multiple_state store #30080

Closed
Korbeil opened this issue Feb 5, 2019 · 1 comment

Comments

@Korbeil
Copy link
Contributor

Korbeil commented Feb 5, 2019

Description
When we are using multiple_state marking store, we should be able to have multiple initial_place as well.

Example
Before

framework:
  workflows:
    order:
      supports:
      - 'Foo\Bar\Order'
      audit_trail:
        enabled: true
      type: workflow
      marking_store:
        type: 'multiple_state'
        arguments:
        - 'marking'
      places:
      initial_place: 'order_created'

After

framework:
  workflows:
    order:
      supports:
      - 'Foo\Bar\Order'
      audit_trail:
        enabled: true
      type: workflow
      marking_store:
        type: 'multiple_state'
        arguments:
        - 'marking'
      places:
      initial_place:
      - 'order_created'
      - 'order_cart'

Since multiple_state allow us to handle more than one marking, it should be same for initial_place.

@Nyholm
Copy link
Member

Nyholm commented Feb 10, 2019

👍
Great suggestion. I think this makes a lot of sense.

lyrixx added a commit that referenced this issue Mar 22, 2019
This PR was merged into the 4.3-dev branch.

Discussion
----------

[Workflow] Added support for many inital places

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #30080
| License       | MIT
| Doc PR        |

Commits
-------

1af1bf2 Added support for many inital places
@lyrixx lyrixx closed this as completed Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants